Bug 1348375 - Stop using a wildcard import in treeherder.client

This import only affects internal treeherder usage, people using the
PyPI package import from the `thclient` subdirectory instead.

Fixes:

treeherder/client/__init__.py:1:1: F401 '.thclient.*' imported but unused

docs/code_style.rst

@@ -23,8 +23,8 @@ In addition:
 
   .. code-block:: python
 
-     from treeherder.client import (HawkAuth,
-                                    TreeherderClient)
+     from django.db import (models,
+                            transaction)
 
 The quickest way to correct import style locally is to let isort make the changes for you - see :ref:`running the tests <running-tests>`.
 

tests/client/test_perfherder_client.py

@@ -2,7 +2,7 @@ import unittest
 
 import responses
 
-from treeherder.client import PerfherderClient
+from treeherder.client.thclient import PerfherderClient
 
 
 class PerfherderClientTest(unittest.TestCase):

tests/client/test_treeherder_client.py

@@ -7,15 +7,15 @@ import unittest
 import responses
 from requests_hawk import HawkAuth
 
-from treeherder.client import (TreeherderArtifact,
-                               TreeherderArtifactCollection,
-                               TreeherderClient,
-                               TreeherderClientError,
-                               TreeherderJob,
-                               TreeherderJobCollection,
-                               TreeherderResultSet,
-                               TreeherderResultSetCollection,
-                               TreeherderRevision)
+from treeherder.client.thclient import (TreeherderArtifact,
+                                        TreeherderArtifactCollection,
+                                        TreeherderClient,
+                                        TreeherderClientError,
+                                        TreeherderJob,
+                                        TreeherderJobCollection,
+                                        TreeherderResultSet,
+                                        TreeherderResultSetCollection,
+                                        TreeherderRevision)
 
 
 class DataSetup(unittest.TestCase):

tests/conftest.py

@@ -11,7 +11,7 @@ from requests import Request
 from requests_hawk import HawkAuth
 from webtest.app import TestApp
 
-from treeherder.client import TreeherderClient
+from treeherder.client.thclient import TreeherderClient
 from treeherder.config.wsgi import application
 from treeherder.etl.jobs import store_job_data
 from treeherder.etl.resultset import store_result_set_data

tests/e2e/conftest.py

@@ -6,7 +6,7 @@ from django.template import (Context,
                              Template)
 
 from tests import test_utils
-from treeherder.client import TreeherderJobCollection
+from treeherder.client.thclient import TreeherderJobCollection
 
 base_dir = os.path.dirname(__file__)
 

tests/test_utils.py

@@ -2,7 +2,7 @@ import datetime
 import json
 
 from tests.sampledata import SampleData
-from treeherder.client import TreeherderClient
+from treeherder.client.thclient import TreeherderClient
 from treeherder.etl.jobs import store_job_data
 from treeherder.etl.resultset import store_result_set_data
 from treeherder.model import models

tests/webapp/api/test_resultset_api.py

@@ -6,7 +6,7 @@ from django.core.urlresolvers import reverse
 from rest_framework.test import APIClient
 
 from tests import test_utils
-from treeherder.client import TreeherderResultSetCollection
+from treeherder.client.thclient import TreeherderResultSetCollection
 from treeherder.etl.resultset import store_result_set_data
 from treeherder.model.models import (FailureClassification,
                                      Job,

treeherder/client/__init__.py

@@ -1 +0,0 @@
-from .thclient import *

treeherder/etl/buildapi.py

@@ -7,7 +7,7 @@ import simplejson as json
 from django.conf import settings
 from django.core.cache import cache
 
-from treeherder.client import TreeherderJobCollection
+from treeherder.client.thclient import TreeherderJobCollection
 from treeherder.etl import (buildbot,
                             common)
 from treeherder.etl.jobs import store_job_data

treeherder/etl/pushlog.py

@@ -5,7 +5,7 @@ import newrelic.agent
 import requests
 from django.core.cache import cache
 
-from treeherder.client import TreeherderResultSetCollection
+from treeherder.client.thclient import TreeherderResultSetCollection
 from treeherder.etl.common import (CollectionNotStoredException,
                                    fetch_json,
                                    generate_revision_hash)

treeherder/model/management/commands/import_reference_data.py

@@ -1,6 +1,6 @@
 from django.core.management.base import BaseCommand
 
-from treeherder.client import TreeherderClient
+from treeherder.client.thclient import TreeherderClient
 from treeherder.model.models import (BuildPlatform,
                                      FailureClassification,
                                      JobGroup,

treeherder/perf/management/commands/import_perf_data.py

@@ -6,8 +6,8 @@ from django.core.management.base import (BaseCommand,
 from django.db import (IntegrityError,
                        transaction)
 
-from treeherder.client import (PerfherderClient,
-                               PerformanceTimeInterval)
+from treeherder.client.thclient import (PerfherderClient,
+                                        PerformanceTimeInterval)
 from treeherder.model.models import (MachinePlatform,
                                      OptionCollection,
                                      Repository)

treeherder/perf/management/commands/test_analyze_perf.py

@@ -2,8 +2,8 @@ from django.conf import settings
 from django.core.management.base import (BaseCommand,
                                          CommandError)
 
-from treeherder.client import (PerfherderClient,
-                               PerformanceTimeInterval)
+from treeherder.client.thclient import (PerfherderClient,
+                                        PerformanceTimeInterval)
 from treeherder.perfalert import (Datum,
                                   detect_changes)