Bug 1183749 - Enable eslint rule: react/no-unused-state (#4240)

.eslintrc.js

@@ -60,6 +60,5 @@ module.exports = {
     'react/jsx-wrap-multilines': 'off',
     'react/no-access-state-in-setstate': 'off',
     'react/no-multi-comp': 'off',
-    'react/no-unused-state': 'off',
   },
 };

ui/job-view/App.jsx

@@ -53,7 +53,6 @@ class App extends React.Component {
       user: { isLoggedIn: false, isStaff: false },
       filterModel,
       isFieldFilterVisible: false,
-      pushListPct: hasSelectedJob ? 100 - DEFAULT_DETAILS_PCT : 100,
       serverChangedDelayed: false,
       serverChanged: false,
       repos: [],

ui/job-view/details/BugFiler.jsx

@@ -110,11 +110,9 @@ export class BugFilerClass extends React.Component {
     this.state = {
       tooltipOpen: {},
       summary: `Intermittent ${summaryString}`,
-      parsedLog: null,
       productSearch: null,
       suggestedProducts: [],
       isFilerSummaryVisible: false,
-      possibleFilename: null,
       selectedProduct: null,
       isIntermittent: true,
       searching: false,

ui/job-view/details/DetailsPanel.jsx

@@ -32,7 +32,6 @@ class DetailsPanel extends React.Component {
       jobDetails: [],
       jobLogUrls: [],
       jobDetailLoading: false,
-      jobLogsAllParsed: false,
       logViewerUrl: null,
       logViewerFullUrl: null,
       reftestUrl: null,
@@ -187,11 +186,6 @@ class DetailsPanel extends React.Component {
           logParseStatus = jobLogUrls[0].parse_status;
         }
 
-        // Provide a parse status for the model
-        const jobLogsAllParsed = (jobLogUrls ?
-          jobLogUrls.every(jlu => jlu.parse_status !== 'pending') :
-          false);
-
         const logViewerUrl = getLogViewerUrl(selectedJob.id, repoName);
         const logViewerFullUrl = `${location.origin}/${logViewerUrl}`;
         const reftestUrl = jobLogUrls.length ? getReftestUrl(jobLogUrls[0].url) : '';
@@ -218,7 +212,6 @@ class DetailsPanel extends React.Component {
         this.setState({
           jobLogUrls,
           jobDetails,
-          jobLogsAllParsed,
           logParseStatus,
           logViewerUrl,
           logViewerFullUrl,

ui/job-view/details/tabs/TabsPanel.jsx

@@ -22,8 +22,6 @@ class TabsPanel extends React.Component {
     this.state = {
       showAutoclassifyTab: getAllUrlParams().has('autoclassify'),
       tabIndex: 0,
-      perfJobDetailSize: 0,
-      jobId: null,
     };
   }
 

ui/job-view/details/tabs/autoclassify/AutoclassifyTab.jsx

@@ -172,9 +172,6 @@ class AutoclassifyTab extends React.Component {
             const selected = errorLines.find(line => !line.verified);
             this.setState({
               selectedLineIds: new Set([selected ? selected.id : null]),
-              editableLines: errorLines.reduce((pending, line) => (
-                !line.verified ? { ...pending, [line.id]: line } : pending
-              ), {}),
             });
           }
 
@@ -286,7 +283,6 @@ class AutoclassifyTab extends React.Component {
     this.setState({
       loadStatus: newLoadStatus,
       selectedLineIds: new Set(),
-      editableLines: new Set(),
       inputByLine: new Map(),
       autoclassifyStatusOnLoad: null,
     });