Improve comments.
This commit is contained in:
Robin Jones 2022-11-15 23:26:29 +00:00
Родитель 2e299c0a46
Коммит 42e50b1822
1 изменённых файлов: 9 добавлений и 6 удалений

15
.github/workflows/ci.yml поставляемый
Просмотреть файл

@ -9,7 +9,6 @@ jobs:
env:
CI: true
strategy:
matrix:
node-version: [14.x, 16.x, lts/*, latest]
@ -40,7 +39,11 @@ jobs:
- name: Rebuild and prepare depencencies
continue-on-error: true #TODO: we currently continue as a warning!
# `npm rebuild` will run all those post-install scripts for us.
run: npm rebuild && npm run prepare --if-present
run: |
if npm rebuild && npm run prepare --if-present ; then
# ensure it is a warning, rather than an error, as GH workflow does not support it!
echo '### :warning: issues encountered with `npm rebuild && npm run prepare`' >> $GITHUB_STEP_SUMMARY
fi
- name: Run License check
continue-on-error: true #TODO: we currently continue as a warning!
@ -52,18 +55,18 @@ jobs:
continue-on-error: true #TODO: we currently continue as a warning!
run: |
if npm run check-package-outdated --if-present ; then
# ensure it is a warning, rather than an error!
# ensure it is a warning, rather than an error, as GH workflow does not support it!
echo '### :warning: Outdated packages detected!, check `npm run check-package-outdated`' >> $GITHUB_STEP_SUMMARY
exit 0
exit 0 #TODO: we currently just ignore this error and raise it as a warning!
fi
- name: Run audit package check
continue-on-error: true #TODO: we currently continue as a warning!
run: |
if npm audit --dry-run --if-present ; then
# ensure it is a warning, rather than an error!
# ensure it is a warning, rather than an error, as GH workflow does not support it!
echo '### :warning: Package audit check failed!, check `npm audit`' >> $GITHUB_STEP_SUMMARY
exit 0
exit 0 #TODO: we currently just ignore this error and raise it as a warning!
fi
- name: Run lint checks