Simplify temp local file creation while fetching contents, use File Provider volume

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/FileProviderExtension.swift

@@ -145,7 +145,7 @@ class FileProviderExtension: NSObject, NSFileProviderReplicatedExtension, NKComm
 
         // TODO: Handle folders nicely
         do {
-            let fileNameLocalPath = try localPathForNCFile(ocId: metadata.ocId, fileNameView: metadata.fileNameView)
+            let fileNameLocalPath = try localPathForNCFile(ocId: metadata.ocId, fileNameView: metadata.fileNameView, domain: self.domain)
 
             dbManager.setStatusForItemMetadata(metadata, status: NextcloudItemMetadataTable.Status.downloading) { updatedMetadata in
 

shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/LocalFilesUtils.swift

@@ -30,29 +30,21 @@ func pathForFileProviderExtData() -> URL? {
     return containerUrl?.appendingPathComponent("FileProviderExt/")
 }
 
-func pathForFileProviderExtFiles() -> URL? {
-    let fileProviderDataUrl = pathForFileProviderExtData()
-    return fileProviderDataUrl?.appendingPathComponent("Files/")
+func pathForFileProviderTempFilesForDomain(_ domain: NSFileProviderDomain) throws -> URL? {
+    guard let fpManager = NSFileProviderManager(for: domain) else {
+        throw NSFileProviderError(.providerNotFound)
+    }
+
+    let fileProviderDataUrl = try fpManager.temporaryDirectoryURL()
+    return fileProviderDataUrl.appendingPathComponent("TemporaryNextcloudFiles/")
 }
 
-@discardableResult func localPathForNCDirectory(ocId: String) throws -> URL {
-    guard let fileProviderFilesPathUrl = pathForFileProviderExtFiles() else {
+func localPathForNCFile(ocId: String, fileNameView: String, domain: NSFileProviderDomain) throws -> URL {
+    guard let fileProviderFilesPathUrl = try pathForFileProviderTempFilesForDomain(domain) else {
         throw URLError(.badURL)
     }
 
-    let folderPathUrl = fileProviderFilesPathUrl.appendingPathComponent(ocId)
-    let folderPath = folderPathUrl.path
-
-    if !FileManager.default.fileExists(atPath: folderPath) {
-        try FileManager.default.createDirectory(at: folderPathUrl, withIntermediateDirectories: true)
-    }
-
-    return folderPathUrl
-}
-
-@discardableResult func localPathForNCFile(ocId: String, fileNameView: String) throws -> URL {
-    let fileFolderPathUrl = try localPathForNCDirectory(ocId: ocId)
-    let filePathUrl = fileFolderPathUrl.appendingPathComponent(fileNameView)
+    let filePathUrl = fileProviderFilesPathUrl.appendingPathComponent(fileNameView)
     let filePath = filePathUrl.path
 
     if !FileManager.default.fileExists(atPath: filePath) {