From 81b7798ac220c8a3413a7f4e4ed6c80f1d89a0fc Mon Sep 17 00:00:00 2001 From: Olivier Goffart Date: Thu, 7 Jan 2016 14:58:02 +0100 Subject: [PATCH] HttpCredentials::slotAuthentication: fix comment The recent revert did no fix the comment --- src/libsync/creds/httpcredentials.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/libsync/creds/httpcredentials.cpp b/src/libsync/creds/httpcredentials.cpp index d30c009f0..fbe78fadd 100644 --- a/src/libsync/creds/httpcredentials.cpp +++ b/src/libsync/creds/httpcredentials.cpp @@ -308,9 +308,8 @@ void HttpCredentials::slotWriteJobDone(QKeychain::Job *job) void HttpCredentials::slotAuthentication(QNetworkReply* reply, QAuthenticator* authenticator) { Q_UNUSED(authenticator) - // we cannot use QAuthenticator, because it sends username and passwords with latin1 - // instead of utf8 encoding. Instead, we send it manually. Thus, if we reach this signal, - // those credentials were invalid and we terminate. + // Because of issue #4326, we need to set the login and password manually at every requests + // Thus, if we reach this signal, those credentials were invalid and we terminate. qDebug() << "Stop request: Authentication failed for " << reply->url().toString(); reply->setProperty(authenticationFailedC, true); reply->close();