more cleanup

service/feedservice.php

@@ -421,13 +421,9 @@ class FeedService extends Service {
     public function patch($feedId, $userId, $diff=[]) {
         $feed = $this->find($feedId, $userId);
 
-        // these attributes just map onto the feed object without extra logic
+        foreach ($diff as $attribute => $value) {
-        $simplePatches = ['ordering', 'pinned', 'updateMode', 'title', 'folderId'];
+            $method = 'set' . ucfirst($attribute);
-        foreach ($simplePatches as $attribute) {
+            $feed->$method($value);
-            if (array_key_exists($attribute, $diff)) {
-                $method = 'set' . ucfirst($attribute);
-                $feed->$method($diff[$attribute]);
-            }
         }
 
         // special feed updates
@@ -435,7 +431,6 @@ class FeedService extends Service {
             // disable caching for the next update
             $feed->setEtag('');
             $feed->setLastModified(0);
-            $feed->setFullTextEnabled($diff['fullTextEnabled']);
             $this->feedMapper->update($feed);
             return $this->update($feedId, $userId, true);
         }