From 5cf16e52a87e8f1d715a1ef1d7dc450ec04bd72f Mon Sep 17 00:00:00 2001 From: Ferdinand Thiessen Date: Thu, 29 Aug 2024 16:39:30 +0200 Subject: [PATCH] fix(NcActions): Role `menu` needs a label assigned so label by trigger Signed-off-by: Ferdinand Thiessen --- src/components/NcActions/NcActions.vue | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/components/NcActions/NcActions.vue b/src/components/NcActions/NcActions.vue index ec4c0e5e..4f418fcc 100644 --- a/src/components/NcActions/NcActions.vue +++ b/src/components/NcActions/NcActions.vue @@ -1779,8 +1779,9 @@ export default { tabindex: '-1', ref: 'menuList', role: this.config.popupRole, - // Dialog must have a label - 'aria-labelledby': this.actionsMenuSemanticType === 'dialog' ? triggerRandomId : undefined, + // For most roles a label is required (dialog, menu), but also in general nothing speaks against labelling a list. + // It is even recommended to do so. + 'aria-labelledby': triggerRandomId, 'aria-modal': this.actionsMenuSemanticType === 'dialog' ? 'true' : undefined, }, [ actions,