make adjustments based on the review

Co-authored-by: binsky <timo@binsky.org>
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>

lib/Controller/InternalController.php

@@ -21,7 +21,6 @@ use OCP\Notification\IManager;
 
 class InternalController extends ApiController {
 	private $userId;
-	private $manager;
 
 	public function __construct(
 		$AppName,
@@ -29,7 +28,7 @@ class InternalController extends ApiController {
 		$UserId,
 		private CredentialService $credentialService,
 		private IConfig $config,
-		IManager $IManager,
+		private IManager $manager,
 		private IAppManager $appManager,
 	) {
 		parent::__construct(
@@ -39,7 +38,6 @@ class InternalController extends ApiController {
 			'Authorization, Content-Type, Accept',
 			86400);
 		$this->userId = $UserId;
-		$this->manager = $IManager;
 	}
 
 	/**

lib/Controller/ShareController.php

@@ -36,8 +36,6 @@ use OCP\Notification\IManager;
 
 class ShareController extends ApiController {
 	private $userId;
-	private $settings;
-	private $manager;
 
 	private $limit = 50;
 	private $offset = 0;
@@ -54,8 +52,8 @@ class ShareController extends ApiController {
 		private CredentialService $credentialService,
 		private NotificationService $notificationService,
 		private FileService $fileService,
-		SettingsService $config,
-		IManager $IManager,
+		private SettingsService $settings,
+		private IManager $manager,
 	) {
 		parent::__construct(
 			$AppName,
@@ -65,8 +63,6 @@ class ShareController extends ApiController {
 			86400);
 
 		$this->userId = $UserId;
-		$this->settings = $config;
-		$this->manager = $IManager;
 	}
 
 

lib/Migration/ServerSideEncryption.php

@@ -48,7 +48,8 @@ class ServerSideEncryption implements IRepairStep {
 		private LoggerInterface $logger,
 		private CredentialService $credentialService,
 		private CredentialRevisionService $revisionService,
-		private FileService    $fileService, IConfig $config,
+		private FileService $fileService,
+		IConfig $config,
 	) {
 		$this->installedVersion = $config->getAppValue('passman', 'installed_version');
 	}

lib/Service/NotificationService.php

@@ -28,14 +28,10 @@ use OCP\IURLGenerator;
 use OCP\Notification\IManager;
 
 class NotificationService {
-
-	private IManager $manager;
-
 	public function __construct(
-		IManager $IManager,
+		private IManager $manager,
 		private IURLGenerator $urlGenerator,
 	) {
-		$this->manager = $IManager;
 	}
 
 	function credentialExpiredNotification($credential) {

lib/Service/ShareService.php

@@ -38,18 +38,14 @@ use OCP\DB\IResult;
 use OCP\Notification\IManager;
 
 class ShareService {
-	private CredentialMapper $credential;
-
-
 	public function __construct(
-		private SharingACLMapper          $sharingACL,
-		private ShareRequestMapper        $shareRequest,
-		CredentialMapper                  $credentials,
+		private SharingACLMapper $sharingACL,
+		private ShareRequestMapper $shareRequest,
+		private CredentialMapper $credential,
 		private CredentialRevisionService $revisions,
-		private EncryptService            $encryptService,
-		private IManager				  $IManager,
+		private EncryptService $encryptService,
+		private IManager $IManager,
 	) {
-		$this->credential = $credentials;
 	}
 
 	/**