Refactor joinRoomHelper

Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>

NextcloudTalk/NCRoomsManager.m

@@ -183,9 +183,18 @@ static NSInteger kIgnoreStatusCode = 999;
             return;
         }
 
-        if (!error) {
+        if (error) {
+            if (block) {
+                // Failed to join room in NC.
+                block(nil, error, statusCode);
+            }
+
+            return;
+        }
+
         [NCUtils log:[NSString stringWithFormat:@"Joined room %@ in NC successfully.", token]];
         NCExternalSignalingController *extSignalingController = [[NCSettingsController sharedInstance] externalSignalingControllerForAccountId:activeAccount.accountId];
+        
         if ([extSignalingController isEnabled]) {
             [NCUtils log:[NSString stringWithFormat:@"Trying to join room %@ in external signaling server...", token]];
             [extSignalingController joinRoom:token withSessionId:sessionId withCompletionBlock:^(NSError *error) {
@@ -201,10 +210,6 @@ static NSInteger kIgnoreStatusCode = 999;
             // Joined room in NC successfully and no external signaling server configured.
             block(sessionId, nil, 0);
         }
-        } else if (block) {
-            // Failed to join room in NC.
-            block(nil, error, statusCode);
-        }
     }];
 }