Open up localization for custom implementations

MvvmCross.Plugins/JsonLocalization/MvxDictionaryTextProvider.cs

@@ -26,8 +26,6 @@ namespace MvvmCross.Plugins.JsonLocalization
             _entries[key] = value;
         }
         
-        #region Implementation of IMvxTextProvider
-
         public override string GetText(string namespaceKey, string typeKey, string name)
         {
             var key = MakeLookupKey(namespaceKey, typeKey, name);
@@ -54,7 +52,5 @@ namespace MvvmCross.Plugins.JsonLocalization
             textValue = key;
             return false;
         }
-
-        #endregion Implementation of IMvxTextProvider
     }
 }

MvvmCross.Plugins/JsonLocalization/MvxJsonDictionaryTextProvider.cs

@@ -17,13 +17,19 @@ namespace MvvmCross.Plugins.JsonLocalization
         {
         }
         
-        private IMvxJsonConverter JsonConvert => Mvx.Resolve<IMvxJsonConverter>();
-
-        #region IMvxJsonDictionaryTextLoader Members
+        private IMvxJsonConverter _jsonConvert;
+        protected IMvxJsonConverter JsonConvert
+        {
+            get
+            {
+                _jsonConvert = _jsonConvert ?? Mvx.Resolve<IMvxJsonConverter>();
+                return _jsonConvert;
+            }
+        }
         
         public abstract void LoadJsonFromResource(string namespaceKey, string typeKey, string resourcePath);
 
-        public void LoadJsonFromText(string namespaceKey, string typeKey, string rawJson)
+        public virtual void LoadJsonFromText(string namespaceKey, string typeKey, string rawJson)
         {
             var entries = JsonConvert.DeserializeObject<Dictionary<string, string>>(rawJson);
             foreach (var kvp in entries)
@@ -31,7 +37,5 @@ namespace MvvmCross.Plugins.JsonLocalization
                 AddOrReplace(namespaceKey, typeKey, kvp.Key, kvp.Value);
             }
         }
-
-        #endregion IMvxJsonDictionaryTextLoader Members
     }
 }

MvvmCross.Plugins/JsonLocalization/MvxTextProvider.cs

@@ -10,11 +10,9 @@ namespace MvvmCross.Plugins.JsonLocalization
     public abstract class MvxTextProvider :
         MvxResourceProvider, IMvxTextProvider
     {
-        #region Implementation of IMvxTextProvider
-
         public abstract string GetText(string namespaceKey, string typeKey, string name);
 
-        public string GetText(string namespaceKey, string typeKey, string name, params object[] formatArgs)
+        public virtual string GetText(string namespaceKey, string typeKey, string name, params object[] formatArgs)
         {
             var baseText = GetText(namespaceKey, typeKey, name);
             if (string.IsNullOrEmpty(baseText))
@@ -28,7 +26,7 @@ namespace MvvmCross.Plugins.JsonLocalization
 
         public abstract bool TryGetText(out string textValue, string namespaceKey, string typeKey, string name);
 
-        public bool TryGetText(out string textValue, string namespaceKey, string typeKey, string name, params object[] formatArgs)
+        public virtual bool TryGetText(out string textValue, string namespaceKey, string typeKey, string name, params object[] formatArgs)
         {
             if (!TryGetText(out textValue, namespaceKey, typeKey, name)) return false;
 
@@ -43,7 +41,5 @@ namespace MvvmCross.Plugins.JsonLocalization
             textValue = string.Format(textValue, formatArgs);
             return true;
         }
-
-        #endregion Implementation of IMvxTextProvider
     }
 }

MvvmCross.Plugins/ResxLocalization/MvxResxTextProvider.cs

@@ -51,7 +51,7 @@ namespace MvvmCross.Plugins.ResxLocalization
             return null;
         }
 
-        public string GetText(string namespaceKey, string typeKey, string name, params object[] formatArgs)
+        public virtual string GetText(string namespaceKey, string typeKey, string name, params object[] formatArgs)
         {
             var baseText = GetText(namespaceKey, typeKey, name);
 
@@ -69,7 +69,7 @@ namespace MvvmCross.Plugins.ResxLocalization
             return textValue != null;
         }
 
-        public bool TryGetText(out string textValue, string namespaceKey, string typeKey, string name, params object[] formatArgs)
+        public virtual bool TryGetText(out string textValue, string namespaceKey, string typeKey, string name, params object[] formatArgs)
         {
             if(!TryGetText(out textValue, namespaceKey, typeKey, name))
                 return false;