Remove unused member field from CalculatorHistory (#330)

This commit is contained in:
Michał Janiszewski 2019-03-20 18:58:32 +01:00 коммит произвёл Daniel Belcher
Родитель 3bff99b323
Коммит 462694dcef
4 изменённых файлов: 5 добавлений и 7 удалений

Просмотреть файл

@ -7,8 +7,7 @@
using namespace std; using namespace std;
using namespace CalculationManager; using namespace CalculationManager;
CalculatorHistory::CalculatorHistory(CALCULATOR_MODE eMode, size_t maxSize) : CalculatorHistory::CalculatorHistory(size_t maxSize) :
m_mode(eMode),
m_maxHistorySize(maxSize) m_maxHistorySize(maxSize)
{} {}

Просмотреть файл

@ -31,7 +31,7 @@ namespace CalculationManager
{ {
public: public:
CalculatorHistory(CALCULATOR_MODE eMode, const size_t maxSize); CalculatorHistory(const size_t maxSize);
unsigned int AddToHistory(_In_ std::shared_ptr<CalculatorVector <std::pair<std::wstring, int>>> const &spTokens, _In_ std::shared_ptr<CalculatorVector<std::shared_ptr<IExpressionCommand>>> const &spCommands, std::wstring_view result); unsigned int AddToHistory(_In_ std::shared_ptr<CalculatorVector <std::pair<std::wstring, int>>> const &spTokens, _In_ std::shared_ptr<CalculatorVector<std::shared_ptr<IExpressionCommand>>> const &spCommands, std::wstring_view result);
std::vector<std::shared_ptr<HISTORYITEM>> const& GetHistory(); std::vector<std::shared_ptr<HISTORYITEM>> const& GetHistory();
std::shared_ptr<HISTORYITEM> const& GetHistoryItem(unsigned int uIdx); std::shared_ptr<HISTORYITEM> const& GetHistoryItem(unsigned int uIdx);
@ -43,7 +43,6 @@ namespace CalculationManager
private: private:
std::vector<std::shared_ptr<HISTORYITEM>> m_historyItems; std::vector<std::shared_ptr<HISTORYITEM>> m_historyItems;
CALCULATOR_MODE m_mode;
const size_t m_maxHistorySize; const size_t m_maxHistorySize;
}; };
} }

Просмотреть файл

@ -30,8 +30,8 @@ namespace CalculationManager
m_isExponentialFormat(false), m_isExponentialFormat(false),
m_persistedPrimaryValue(), m_persistedPrimaryValue(),
m_currentCalculatorEngine(nullptr), m_currentCalculatorEngine(nullptr),
m_pStdHistory(new CalculatorHistory(CM_STD, MAX_HISTORY_ITEMS)), m_pStdHistory(new CalculatorHistory(MAX_HISTORY_ITEMS)),
m_pSciHistory(new CalculatorHistory(CM_SCI, MAX_HISTORY_ITEMS)), m_pSciHistory(new CalculatorHistory(MAX_HISTORY_ITEMS)),
m_inHistoryItemLoadMode(false) m_inHistoryItemLoadMode(false)
{ {
CCalcEngine::InitialOneTimeOnlySetup(*m_resourceProvider); CCalcEngine::InitialOneTimeOnlySetup(*m_resourceProvider);

Просмотреть файл

@ -20,7 +20,7 @@ namespace CalculatorUnitTests
TEST_METHOD_INITIALIZE(CommonSetup) TEST_METHOD_INITIALIZE(CommonSetup)
{ {
m_resourceProvider = make_shared<EngineResourceProvider>(); m_resourceProvider = make_shared<EngineResourceProvider>();
m_history = make_shared<CalculatorHistory>(CM_STD, MAX_HISTORY_SIZE); m_history = make_shared<CalculatorHistory>(MAX_HISTORY_SIZE);
CCalcEngine::InitialOneTimeOnlySetup(*(m_resourceProvider.get())); CCalcEngine::InitialOneTimeOnlySetup(*(m_resourceProvider.get()));
m_calcEngine = make_unique<CCalcEngine>(false /* Respect Order of Operations */, false /* Set to Integer Mode */, m_resourceProvider.get(), nullptr, m_history); m_calcEngine = make_unique<CCalcEngine>(false /* Respect Order of Operations */, false /* Set to Integer Mode */, m_resourceProvider.get(), nullptr, m_history);
} }