Merge branch 'master' into dh_NugetConfigFix

.github/ISSUE_TEMPLATE/bug-report.md

@@ -0,0 +1,43 @@
+---
+name: Bug Report
+about: Create a report to help us improve
+title: "[Bug] "
+labels: bug
+assignees: ''
+
+---
+
+<!-- Bug report best practices: https://github.com/xamarin/Essentials/wiki -->
+
+### Description
+
+### Steps to Reproduce
+
+1. 
+2. 
+3. 
+
+### Expected Behavior
+
+### Actual Behavior
+
+### Basic Information
+
+- Version with issue:
+- Last known good version:
+- IDE:
+- Platform Target Frameworks: <!-- All that apply -->
+  - iOS:  <!-- The version of the iOS SDK you are compiling against, e.g. 11.1 -->
+  - Android: <!-- The version of the Android SDK you are compiling against, e.g. 7.1 --> 
+  - UWP:  <!-- The version of the UWP SDK you are compiling against, e.g. 16299 --> 
+- Android Support Library Version: <!-- if applicable -->
+- Nuget Packages:
+- Affected Devices:
+
+### Screenshots
+
+<!-- If the issue is a visual issue, please include screenshots showing the problem if possible -->
+
+### Reproduction Link
+
+<!-- Please upload or provide a link to a reproduction case -->

.github/ISSUE_TEMPLATE/feature-request.md

@@ -0,0 +1,27 @@
+---
+name: Feature request
+about: Suggest an idea for Essentials
+title: "[Enhancement] YOUR IDEA!"
+labels: feature-request 
+assignees: ''
+
+---
+
+## Summary
+Please provide a brief summary of your proposal. Two to three sentences is best here.
+
+## API Changes
+
+Include a list of all API changes, additions, subtractions as would be required by your proposal. These APIs should be considered placeholders, so the naming is not as important as getting the concepts correct. If possible you should include some "example" code of usage of your new API.  You should also provide details of the level of availability for the feature on each of the supported platforms.
+
+e.g.
+
+In order to facilitate the new Shiny Button api, a bool is added to the Button class. This is done as a bool because it is simpler to data bind and other reasons...
+
+    var button = new Button ();
+    button.MakeShiny = true; // new API
+
+The MakeShiny API works even if the button is already visible.
+
+## Intended Use Case
+Provide a detailed example of where your proposal would be used and for what purpose.

.github/ISSUE_TEMPLATE/new-api-spec.md

@@ -0,0 +1,39 @@
+---
+name: New API Spec
+about: An official specification for new APIS
+title: "[Spec]  "
+labels: "feature-request"
+assignees: ''
+
+---
+
+# [The feature] 
+
+Provide a concise description of the feature and the motivation for adding it to Xamarin.Essentials
+
+# API
+
+## [ class ]
+
+### Properties
+
+| API | Description |
+| ------------- | ------------- |
+| [name] | Gets or sets [description]. |
+
+### Events
+
+| API | Description |
+| ------------- | ------------- |
+| [name] | [API documentation/description] |
+ 
+# Scenarios
+
+# Platform Compatibility
+- Target Frameworks: <!-- All that apply -->
+  - iOS:  <!-- Support on iOS for the API -->
+  - Android: <!-- Support on Android for the API -->
+  - UWP: <!-- Support on UWP for the API -->
+# Backward Compatibility
+
+# Difficulty : [low/medium/high]

Samples/Samples/View/LauncherPage.xaml

@@ -23,7 +23,8 @@
                     <ColumnDefinition Width="*" />
                 </Grid.ColumnDefinitions>
                 <Entry Grid.Row="0" Grid.ColumnSpan="2" Text="{Binding LaunchUri}" />
-                <Button Grid.Row="1" Grid.ColumnSpan="2"  Text="Check Launch" Command="{Binding CanLaunchCommand}"/>
+                <Button Grid.Row="1" Text="Check Launch" Command="{Binding CanLaunchCommand}"/>
+                <Button Grid.Row="1" Grid.Column="1"  Text=" Launch" Command="{Binding LaunchCommand}"/>
                 <Button Grid.Row="2" Grid.Column="0" Text="Launch Browser" Command="{Binding LaunchBrowserCommand}"/>
                 <Button Grid.Row="2" Grid.Column="1" Text="Launch Mail" Command="{Binding LaunchMailCommand}"/>
                 
@@ -41,4 +42,4 @@
             </Grid>
         </ScrollView>
     </StackLayout>
-</views:BasePage>
+</views:BasePage>

Xamarin.Essentials/Launcher/Launcher.shared.cs

@@ -40,7 +40,7 @@ namespace Xamarin.Essentials
 
         public static Task OpenAsync(OpenFileRequest request)
         {
-            ExperimentalFeatures.VerifyEnabled(ExperimentalFeatures.ShareFileRequest);
+            ExperimentalFeatures.VerifyEnabled(ExperimentalFeatures.OpenFileRequest);
 
             return PlatformOpenAsync(request);
         }

Xamarin.Essentials/Share/Share.ios.cs

@@ -57,8 +57,8 @@ namespace Xamarin.Essentials
 
     class ShareActivityItemSource : UIActivityItemSource
     {
-        NSObject item;
-        string subject;
+        readonly NSObject item;
+        readonly string subject;
 
         internal ShareActivityItemSource(NSObject item, string subject)
         {

Xamarin.Essentials/Sms/Sms.ios.cs

@@ -26,7 +26,7 @@ namespace Xamarin.Essentials
             messageController.Finished += (sender, e) =>
             {
                 messageController.DismissViewController(true, null);
-                tcs.SetResult(e.Result == MessageComposeResult.Sent);
+                tcs?.TrySetResult(e.Result == MessageComposeResult.Sent);
             };
             controller.PresentViewController(messageController, true, null);
 

nugetreadme.txt

@@ -1,14 +1,14 @@
 ## Xamarin.Essentials
 
 Thank you for installing Xamarin.Essentials, be sure to read through our full documentation at:
-http://aka.ms/xamarinessentials
+https://aka.ms/xamarinessentials
 
 ## Setup
 
 Ensure that you install Xamarin.Essentials into all of your projects.
 
 For Android projects there is a small amount of setup needed to handle permissions. Please follow our short guide at:
-http://aka.ms/essentials-getstarted
+https://aka.ms/essentials-getstarted
 
 ## Release Notes
 
@@ -16,4 +16,4 @@ If you are upgrading from an earlier preview the stable version contains several
 
 We have documented a full transition guide when migrating from older versions. 
 
-See our full release notes for more information: http://aka.ms/essentials-releasenotes
+See our full release notes for more information: https://aka.ms/essentials-releasenotes