From c1c62fe508282d30c2fded533e37c412d138a971 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Laban?= Date: Tue, 23 Apr 2024 14:45:35 -0400 Subject: [PATCH] fix: Remove svg package from wasm head --- build/test-scripts/run-netcore-mobile-template-tests.ps1 | 9 ++++++++- .../Uno.Implicit.Packages.ProjectSystem.Uno.targets | 4 ++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/build/test-scripts/run-netcore-mobile-template-tests.ps1 b/build/test-scripts/run-netcore-mobile-template-tests.ps1 index 9d65c39c17..f1c9feabbe 100644 --- a/build/test-scripts/run-netcore-mobile-template-tests.ps1 +++ b/build/test-scripts/run-netcore-mobile-template-tests.ps1 @@ -194,6 +194,8 @@ Get-ChildItem -Recurse -Filter global.json | ForEach-Object { $globalJson | ConvertTo-Json -Depth 100 | Set-Content $globalJsonfilePath } +$sdkFeatures = $(If ($IsWindows) {"-p:UnoFeatures=Material%3BExtensions%3BToolkit%3BCSharpMarkup%3BSvg%3BMVUX"} Else { "-p:UnoFeatures=Material%3BToolkit" })); + $projects = @( # @@ -223,12 +225,17 @@ $projects = # 5.2 Blank # @("5.2/uno52blank/uno52blank/uno52blank.csproj", @("-f", "net8.0"), $true, $true), + @("5.2/uno52blank/uno52blank/uno52blank.csproj", @("-f", "net8.0", $sdkFeatures, $true, $true), @("5.2/uno52blank/uno52blank/uno52blank.csproj", @("-f", "net8.0-browserwasm"), $true, $true), + @("5.2/uno52blank/uno52blank/uno52blank.csproj", @("-f", "net8.0-browserwasm", $sdkFeatures, $true, $true), @("5.2/uno52blank/uno52blank/uno52blank.csproj", @("-f", "net8.0-ios"), $true, $true), + @("5.2/uno52blank/uno52blank/uno52blank.csproj", @("-f", "net8.0-ios", $sdkFeatures, $true, $true), @("5.2/uno52blank/uno52blank/uno52blank.csproj", @("-f", "net8.0-android"), $true, $true), + @("5.2/uno52blank/uno52blank/uno52blank.csproj", @("-f", "net8.0-android", $sdkFeatures, $true, $true), @("5.2/uno52blank/uno52blank/uno52blank.csproj", @("-f", "net8.0-maccatalyst"), $true, $true), + @("5.2/uno52blank/uno52blank/uno52blank.csproj", @("-f", "net8.0-maccatalyst", $sdkFeatures, $true, $true), @("5.2/uno52blank/uno52blank/uno52blank.csproj", @("-f", "net8.0-desktop"), $true, $true), - @("5.2/uno52blank/uno52blank/uno52blank.csproj", @("-f", "net8.0-desktop", $(If ($IsWindows) {"-p:UnoFeatures=Material%3BExtensions%3BToolkit%3BCSharpMarkup%3BSvg%3BMVUX"} Else { "-p:UnoFeatures=Material%3BToolkit" })), $true, $true), + @("5.2/uno52blank/uno52blank/uno52blank.csproj", @("-f", "net8.0-desktop", $sdkFeatures, $true, $true), # Default mode for the template is WindowsAppSDKSelfContained=true, which requires specifying a target platform. @("5.2/uno52blank/uno52blank/uno52blank.csproj", @("-p:Platform=x86" , "-p:TargetFramework=net8.0-windows10.0.19041"), $false, $false), diff --git a/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.Uno.targets b/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.Uno.targets index 573922cda5..5c9fe2908b 100644 --- a/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.Uno.targets +++ b/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.Uno.targets @@ -12,8 +12,8 @@ <_UnoProjectSystemPackageReference Include="SkiaSharp.Views.Uno.WinUI" ProjectSystem="true"/> - - <_UnoProjectSystemPackageReference Include="Uno.WinUI.Svg" ProjectSystem="true" Condition="$(UnoFeatures.Contains(';Svg;')) AND $(IsUnoHead) == 'true'" /> + + <_UnoProjectSystemPackageReference Include="Uno.WinUI.Svg" ProjectSystem="true" />