From 0b74649bf318ae4067f98e736b1e08b12153ffa2 Mon Sep 17 00:00:00 2001 From: memu8 <66331238+memu8@users.noreply.github.com> Date: Thu, 3 Dec 2020 14:19:07 -0600 Subject: [PATCH] Added a Flow Direction Property to action sheets and alert dialogs (#11679) * added constructor actionsheet * added flow direction to action sheets on Android * added flow direction to alerts on Android * added Android alert dialog flow direction * UWP alert/actionsheet flow direction * add alert dialog flow direction * added flow direction to UWP alert and actionsheets * fixes #2448 * fixes #2448 * fixes #2448 * fixes #2448 * fixes #2448 * fixes #2448 * fixes #2448 * Fix rebase errors * - fix rebase Co-authored-by: E.Z. Hart Co-authored-by: Shane Neuville --- .../Issue2447.xaml.cs | 10 +- .../Issue2448.xaml | 48 ++++++++++ .../Issue2448.xaml.cs | 70 ++++++++++++++ ...rin.Forms.Controls.Issues.Shared.projitems | 18 +++- Xamarin.Forms.Core/ActionSheetArguments.cs | 3 + Xamarin.Forms.Core/AlertArguments.cs | 3 + Xamarin.Forms.Core/Page.cs | 21 +++- .../PopupManager.cs | 96 ++++++++++++++++++- .../FormsFlyout.xaml.cs | 34 ++++++- Xamarin.Forms.Platform.UAP/Platform.cs | 36 ++++++- 10 files changed, 325 insertions(+), 14 deletions(-) create mode 100644 Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2448.xaml create mode 100644 Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2448.xaml.cs diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2447.xaml.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2447.xaml.cs index 678e28d9b..0f2e75b45 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2447.xaml.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2447.xaml.cs @@ -10,18 +10,18 @@ using Xamarin.Forms.Internals; namespace Xamarin.Forms.Controls.Issues { -#if APP #if UITEST [NUnit.Framework.Category(Core.UITests.UITestCategories.Github5000)] #endif - [Preserve (AllMembers = true)] - [Issue (IssueTracker.Github, 2447, "Force label text direction", PlatformAffected.Android)] + [Preserve(AllMembers = true)] + [Issue(IssueTracker.Github, 2447, "Force label text direction", PlatformAffected.Android)] public partial class Issue2447 : ContentPage { - public Issue2447 () +#if APP + public Issue2447() { InitializeComponent(); } - } #endif + } } diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2448.xaml b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2448.xaml new file mode 100644 index 000000000..7c1eb4286 --- /dev/null +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2448.xaml @@ -0,0 +1,48 @@ + + + +