diff --git a/dotnet/targets/Xamarin.Shared.Sdk.targets b/dotnet/targets/Xamarin.Shared.Sdk.targets index 76fcb019a9..0e7482a112 100644 --- a/dotnet/targets/Xamarin.Shared.Sdk.targets +++ b/dotnet/targets/Xamarin.Shared.Sdk.targets @@ -1210,7 +1210,7 @@ true <_RequireProvisioningProfile Condition="'$(_RequireProvisioningProfile)' == '' And '$(_PlatformName)' == 'MacCatalyst' And '$(CodesignProvision)' != ''">true <_RequireProvisioningProfile Condition="'$(_RequireProvisioningProfile)' == ''">false + + + + + true diff --git a/msbuild/Xamarin.Shared/Xamarin.Shared.targets b/msbuild/Xamarin.Shared/Xamarin.Shared.targets index 53e606b7ff..ebf51ca417 100644 --- a/msbuild/Xamarin.Shared/Xamarin.Shared.targets +++ b/msbuild/Xamarin.Shared/Xamarin.Shared.targets @@ -460,7 +460,7 @@ Copyright (C) 2018 Microsoft. All rights reserved. ApplicationVersion="$(ApplicationVersion)" ApplicationDisplayVersion="$(ApplicationDisplayVersion)" AppBundleName="$(_AppBundleName)" - AppManifest="$(_AppManifest)" + AppManifest="$(AppBundleManifest)" AssemblyName="$(AssemblyName)" CompiledAppManifest="$(_TemporaryAppManifest)" Debug="$(_BundlerDebug)" @@ -527,18 +527,18 @@ Copyright (C) 2018 Microsoft. All rights reserved. - + @@ -1297,33 +1297,33 @@ Copyright (C) 2018 Microsoft. All rights reserved. Ref: https://bugzilla.xamarin.com/show_bug.cgi?id=34736 --> - - + - - + - - + - + - <_AppBundleManifest>$(_AppBundlePath)$(_AppBundleManifestRelativePath)Info.plist + <_AppBundleManifestPath>$(_AppBundlePath)$(_AppBundleManifestRelativePath)Info.plist <_CreateAppManifest>$(_CanOutputAppBundle) <_TemporaryAppManifest>$(DeviceSpecificIntermediateOutputPath)AppManifest.plist @@ -2282,7 +2282,7 @@ Copyright (C) 2018 Microsoft. All rights reserved. @@ -171,12 +171,12 @@ + Inputs="$(AppBundleManifest);$(HotRestartAppBundlePath)\Extracted" + Outputs="$(HotRestartSignedAppDir)$(AppBundleManifest);$(HotRestartSignedAppDir)Extracted"> @@ -288,7 +288,7 @@ - <_CodeSignHotRestartInputs Include="$(_AppManifest)" Outputs="$(HotRestartSignedAppDir)$(_AppManifest)" /> + <_CodeSignHotRestartInputs Include="$(AppBundleManifest)" Outputs="$(HotRestartSignedAppDir)$(AppBundleManifest)" /> <_CodeSignHotRestartInputs Include="$(CodesignEntitlements)" Outputs="$(HotRestartSignedAppDir)$(CodesignEntitlements)" /> <_CodeSignHotRestartInputs Include="$(_ProvisioningProfilePath)" Outputs="$(HotRestartSignedAppDir)embedded.mobileprovision" /> <_CodeSignHotRestartInputs Include="@(_HotRestartFrameworkFiles)" Outputs="$(HotRestartAppBundlePath)\Frameworks\%(_HotRestartFrameworkFiles.FrameworkDir)%(RecursiveDir)%(Filename)%(Extension)" /> diff --git a/tests/msbuild/Xamarin.MacDev.Tests/TargetTests/TargetTests.cs b/tests/msbuild/Xamarin.MacDev.Tests/TargetTests/TargetTests.cs index 317f791007..8cc3dcf211 100644 --- a/tests/msbuild/Xamarin.MacDev.Tests/TargetTests/TargetTests.cs +++ b/tests/msbuild/Xamarin.MacDev.Tests/TargetTests/TargetTests.cs @@ -565,7 +565,7 @@ namespace Xamarin.iOS.Tasks public void DetectAppManifest_ExecutableProject () { RunTarget (MonoTouchProject, TargetName.DetectAppManifest); - Assert.That (MonoTouchProjectInstance.GetPropertyValue ("_AppManifest"), Is.Not.Null.And.Not.Empty, "#1"); + Assert.That (MonoTouchProjectInstance.GetPropertyValue ("AppBundleManifest"), Is.Not.Null.And.Not.Empty, "#1"); } [Test] @@ -574,7 +574,7 @@ namespace Xamarin.iOS.Tasks MonoTouchProjectInstance.RemoveItems ("None"); RunTarget (MonoTouchProject, TargetName.DetectAppManifest, expectedErrorCount: 1); - Assert.That (MonoTouchProjectInstance.GetPropertyValue ("_AppManifest"), Is.Null.Or.Empty, "#1"); + Assert.That (MonoTouchProjectInstance.GetPropertyValue ("AppBundleManifest"), Is.Null.Or.Empty, "#1"); } [Test] @@ -586,7 +586,7 @@ namespace Xamarin.iOS.Tasks MonoTouchProjectInstance.AddItem ("None", "Info.plist"); RunTarget (MonoTouchProject, TargetName.DetectAppManifest); - Assert.AreEqual ("Info.plist", MonoTouchProjectInstance.GetPropertyValue ("_AppManifest"), "#1"); + Assert.AreEqual ("Info.plist", MonoTouchProjectInstance.GetPropertyValue ("AppBundleManifest"), "#1"); } [Test] @@ -599,7 +599,7 @@ namespace Xamarin.iOS.Tasks MonoTouchProjectInstance.AddItem ("None", linkedPlist, new Dictionary { { "Link", "Info.plist" } }); RunTarget (MonoTouchProject, TargetName.DetectAppManifest); - Assert.AreEqual (linkedPlist, MonoTouchProjectInstance.GetPropertyValue ("_AppManifest"), "#1"); + Assert.AreEqual (linkedPlist, MonoTouchProjectInstance.GetPropertyValue ("AppBundleManifest"), "#1"); } [Test] @@ -612,14 +612,14 @@ namespace Xamarin.iOS.Tasks MonoTouchProjectInstance.AddItem ("None", logicalPlist, new Dictionary { { "LogicalName", "Info.plist" } }); RunTarget (MonoTouchProject, TargetName.DetectAppManifest); - Assert.AreEqual (logicalPlist, MonoTouchProjectInstance.GetPropertyValue ("_AppManifest"), "#1"); + Assert.AreEqual (logicalPlist, MonoTouchProjectInstance.GetPropertyValue ("AppBundleManifest"), "#1"); } [Test] public void DetectAppManifest_LibraryProject () { RunTarget (LibraryProject, TargetName.DetectAppManifest); - Assert.That (LibraryProjectInstance.GetPropertyValue ("_AppManifest"), Is.Null.Or.Empty, "#1"); + Assert.That (LibraryProjectInstance.GetPropertyValue ("AppBundleManifest"), Is.Null.Or.Empty, "#1"); } } }