[mtouch/mmp] Add better diagnostics if xcrun returns invalid data. (#8166)

tools/common/Driver.cs

@@ -1034,6 +1034,10 @@ namespace Xamarin.Bundler {
 
 			if (ret == 0) {
 				path = stdout.ToString ().Trim ();
+				if (!File.Exists (path)) {
+					ErrorHelper.Warning (5315, Errors.MX5315 /* The tool xcrun failed to return a valid result (the file {0} does not exist). Check build log for details. */, tool, path);
+					return false;
+				}
 			} else {
 				Log (1, "Failed to locate the developer tool '{0}', 'xcrun {1}' returned with the exit code {2}:\n{3}", tool, string.Join (" ", args), ret, both.ToString ());
 			}

tools/mtouch/errors.Designer.cs

@@ -2327,6 +2327,12 @@ namespace Xamarin.Bundler {
             }
         }
         
+        internal static string MX5315 {
+            get {
+                return ResourceManager.GetString("MX5315", resourceCulture);
+            }
+        }
+        
         internal static string MT8018 {
             get {
                 return ResourceManager.GetString("MT8018", resourceCulture);

tools/mtouch/errors.resx

@@ -2680,6 +2680,11 @@
 		</comment>
 	</data>
 
+	<data name="MX5315" xml:space="preserve">
+		<value>The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</value>
+	</data>
+
 	<data name="MT8018" xml:space="preserve">
 		<value>Internal consistency error. Please file a bug report at https://github.com/xamarin/xamarin-macios/issues/new.
 		</value>

tools/mtouch/xlf/Errors.cs.xlf

@@ -3042,6 +3042,13 @@
         <note>
 		</note>
       </trans-unit>
+      <trans-unit id="MX5315">
+        <source>The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</source>
+        <target state="new">The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</target>
+        <note></note>
+      </trans-unit>
       <trans-unit id="default">
         <source>The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</source>
         <target state="new">The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</target>

tools/mtouch/xlf/Errors.de.xlf

@@ -3042,6 +3042,13 @@
         <note>
 		</note>
       </trans-unit>
+      <trans-unit id="MX5315">
+        <source>The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</source>
+        <target state="new">The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</target>
+        <note></note>
+      </trans-unit>
       <trans-unit id="default">
         <source>The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</source>
         <target state="new">The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</target>

tools/mtouch/xlf/Errors.es.xlf

@@ -3042,6 +3042,13 @@
         <note>
 		</note>
       </trans-unit>
+      <trans-unit id="MX5315">
+        <source>The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</source>
+        <target state="new">The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</target>
+        <note></note>
+      </trans-unit>
       <trans-unit id="default">
         <source>The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</source>
         <target state="new">The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</target>

tools/mtouch/xlf/Errors.fr.xlf

@@ -3042,6 +3042,13 @@
         <note>
 		</note>
       </trans-unit>
+      <trans-unit id="MX5315">
+        <source>The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</source>
+        <target state="new">The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</target>
+        <note></note>
+      </trans-unit>
       <trans-unit id="default">
         <source>The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</source>
         <target state="new">The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</target>

tools/mtouch/xlf/Errors.it.xlf

@@ -3042,6 +3042,13 @@
         <note>
 		</note>
       </trans-unit>
+      <trans-unit id="MX5315">
+        <source>The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</source>
+        <target state="new">The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</target>
+        <note></note>
+      </trans-unit>
       <trans-unit id="default">
         <source>The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</source>
         <target state="new">The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</target>

tools/mtouch/xlf/Errors.ja.xlf

@@ -3042,6 +3042,13 @@
         <note>
 		</note>
       </trans-unit>
+      <trans-unit id="MX5315">
+        <source>The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</source>
+        <target state="new">The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</target>
+        <note></note>
+      </trans-unit>
       <trans-unit id="default">
         <source>The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</source>
         <target state="new">The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</target>

tools/mtouch/xlf/Errors.ko.xlf

@@ -3042,6 +3042,13 @@
         <note>
 		</note>
       </trans-unit>
+      <trans-unit id="MX5315">
+        <source>The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</source>
+        <target state="new">The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</target>
+        <note></note>
+      </trans-unit>
       <trans-unit id="default">
         <source>The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</source>
         <target state="new">The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</target>

tools/mtouch/xlf/Errors.pl.xlf

@@ -3042,6 +3042,13 @@
         <note>
 		</note>
       </trans-unit>
+      <trans-unit id="MX5315">
+        <source>The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</source>
+        <target state="new">The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</target>
+        <note></note>
+      </trans-unit>
       <trans-unit id="default">
         <source>The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</source>
         <target state="new">The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</target>

tools/mtouch/xlf/Errors.pt-BR.xlf

@@ -3042,6 +3042,13 @@
         <note>
 		</note>
       </trans-unit>
+      <trans-unit id="MX5315">
+        <source>The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</source>
+        <target state="new">The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</target>
+        <note></note>
+      </trans-unit>
       <trans-unit id="default">
         <source>The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</source>
         <target state="new">The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</target>

tools/mtouch/xlf/Errors.ru.xlf

@@ -3042,6 +3042,13 @@
         <note>
 		</note>
       </trans-unit>
+      <trans-unit id="MX5315">
+        <source>The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</source>
+        <target state="new">The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</target>
+        <note></note>
+      </trans-unit>
       <trans-unit id="default">
         <source>The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</source>
         <target state="new">The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</target>

tools/mtouch/xlf/Errors.tr.xlf

@@ -3042,6 +3042,13 @@
         <note>
 		</note>
       </trans-unit>
+      <trans-unit id="MX5315">
+        <source>The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</source>
+        <target state="new">The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</target>
+        <note></note>
+      </trans-unit>
       <trans-unit id="default">
         <source>The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</source>
         <target state="new">The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</target>

tools/mtouch/xlf/Errors.zh-Hans.xlf

@@ -3042,6 +3042,13 @@
         <note>
 		</note>
       </trans-unit>
+      <trans-unit id="MX5315">
+        <source>The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</source>
+        <target state="new">The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</target>
+        <note></note>
+      </trans-unit>
       <trans-unit id="default">
         <source>The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</source>
         <target state="new">The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</target>

tools/mtouch/xlf/Errors.zh-Hant.xlf

@@ -3042,6 +3042,13 @@
         <note>
 		</note>
       </trans-unit>
+      <trans-unit id="MX5315">
+        <source>The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</source>
+        <target state="new">The tool xcrun failed to find result when looking for the tool '{0}' (the file '{1}' does not exist). Check build log for details.
+		</target>
+        <note></note>
+      </trans-unit>
       <trans-unit id="default">
         <source>The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</source>
         <target state="new">The error message for code {0} could not be found. Please report this missing message on GitHub at https://github.com/xamarin/xamarin-macios/issues/new</target>