Merge remote-tracking branch 'origin/main' into darc-main-fc6e47e2-7b69-4464-b65f-8f67ca26b4e8

tools/devops/automation/scripts/GitHub.psm1

@@ -223,7 +223,6 @@ function New-GitHubComment {
         [String]
         $Header,
         
-        [Parameter(Mandatory)]
         [String]
         $Description,
 
@@ -257,7 +256,9 @@ function New-GitHubComment {
     $msg = [System.Text.StringBuilder]::new()
     $msg.AppendLine("### $Emoji $Header $Emoji")
     $msg.AppendLine()
-    $msg.AppendLine($Description)
+    if ($Description) { # only if description is not null or empty
+        $msg.AppendLine($Description)
+    }
     if ($Message) { # only if message is not null or empty
         $msg.AppendLine()
         $msg.AppendLine($Message)

tools/devops/automation/templates/mac/build.yml

@@ -223,9 +223,10 @@ steps:
       }
       $request = New-GitHubComment -Header "Tests failed on macOS $Env:CONTEXT" -Description "Tests failed on $Env:CONTEXT." -Message $msg.ToString() -Emoji ":x:"
     } else {
-      Set-GitHubStatus -Status "success" -Description "Tests passed Xamarin.Mac tests on macOS $Env:CONTEXT passed." -Context "$Env:CONTEXT"
-      $request = New-GitHubComment -Header "Tests passed on macOS $Env:CONTEXT" -Description "Tests passed" -Message "**All** tests on macOS X $Env:CONTEXT passed." -Emoji ":white_check_mark:"
+      Set-GitHubStatus -Status "success" -Description "Tests passed on macOS $Env:CONTEXT passed." -Context "$Env:CONTEXT"
+      $request = New-GitHubComment -Header "Tests passed on macOS $Env:CONTEXT" -Description "Tests passed" -Message "**All** tests on macOS $Env:CONTEXT passed." -Emoji ":white_check_mark:"
     }
+    touch $testsPath/test-run-completed
     # we set the result to 0, the reason is that release pipelines do not like failing tests,
     # yet we do have some  flacky ones, this will allow the release to run. The comment will let use know that we failed
     exit 0  
@@ -238,3 +239,20 @@ steps:
     SYSTEM_ACCESSTOKEN: $(System.AccessToken)
     MONO_DEBUG: no-gdb-backtrace
   continueOnError: true
+
+- pwsh: |
+    Import-Module $Env:SYSTEM_DEFAULTWORKINGDIRECTORY\xamarin-macios\tools\devops\automation\scripts\GitHub.psm1
+    $testsPath = "$(Build.SourcesDirectory)/artifacts/mac-test-package/tests"
+    if (-not ([IO.File]::Exists("$testsPath/test-run-completed"))) {
+      Set-GitHubStatus -Status "error" -Description "Tests timed out on macOS $Env:CONTEXT." -Context "$Env:CONTEXT"
+      $request = New-GitHubComment -Header "Tests timed out on macOS $Env:CONTEXT" -Description "" -Message "" -Emoji ":x:"
+    }
+  displayName: 'Report test timeout'
+  timeoutInMinutes: 5
+  condition: succeededOrFailed() # in particular we care if something failed
+  continueOnError: true
+  env:
+    CONTEXT: ${{ parameters.statusContext }}
+    BUILD_REVISION: $(Build.SourceVersion)
+    GITHUB_TOKEN: $(GitHub.Token)
+    SYSTEM_ACCESSTOKEN: $(System.AccessToken)