From 59179c4bb73ea67a3c422f4a47129e235dff7ff2 Mon Sep 17 00:00:00 2001 From: Rolf Bjarne Kvinge Date: Mon, 14 Oct 2024 16:34:08 +0200 Subject: [PATCH] [dotnet-linker] Improve error reporting by not forgetting about original exceptions. This way we report the stack trace of the original exception in build logs. --- tools/dotnet-linker/Steps/ConfigurationAwareStep.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/dotnet-linker/Steps/ConfigurationAwareStep.cs b/tools/dotnet-linker/Steps/ConfigurationAwareStep.cs index 1fb21c07ec..fd8c498dcd 100644 --- a/tools/dotnet-linker/Steps/ConfigurationAwareStep.cs +++ b/tools/dotnet-linker/Steps/ConfigurationAwareStep.cs @@ -106,17 +106,17 @@ namespace Xamarin.Linker { protected virtual Exception [] Fail (AssemblyDefinition assembly, Exception e) { - return CollectExceptions (e, () => ErrorHelper.CreateError (ErrorCode, Errors.MX_ConfigurationAwareStepWithAssembly, Name, assembly?.FullName, e.Message)); + return CollectExceptions (e, () => ErrorHelper.CreateError (ErrorCode, e, Errors.MX_ConfigurationAwareStepWithAssembly, Name, assembly?.FullName, e.Message)); } protected virtual Exception [] Fail (Exception e) { - return CollectExceptions (e, () => ErrorHelper.CreateError (ErrorCode | 1, Errors.MX_ConfigurationAwareStep, Name, e.Message)); + return CollectExceptions (e, () => ErrorHelper.CreateError (ErrorCode | 1, e, Errors.MX_ConfigurationAwareStep, Name, e.Message)); } protected virtual Exception [] FailEnd (Exception e) { - return CollectExceptions (e, () => ErrorHelper.CreateError (ErrorCode | 2, Errors.MX_ConfigurationAwareStep, Name, e.Message)); + return CollectExceptions (e, () => ErrorHelper.CreateError (ErrorCode | 2, e, Errors.MX_ConfigurationAwareStep, Name, e.Message)); } Exception [] CollectExceptions (Exception e, Func createException)