[main][msbuild] Changes GetMinimumOSVersionTaskBase to use ITaskItem for inputs (#9135)

* [msbuild] Changes GetMinimumOSVersionTaskBase to use ITaskItem for inputs

From Visual Studio we need the input files to be  instead of plain strings to identify the files that need to be copied to the Mac

* Adds null check for AppManifest in GetMinimumOSVersionTaskBase

Co-authored-by: emaf <ema@xamarin.com>
This commit is contained in:
monojenkins 2020-07-21 02:31:28 -04:00 коммит произвёл GitHub
Родитель 858e44aa4d
Коммит 6bbcfd4c78
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 4AEE18F83AFDEB23
1 изменённых файлов: 3 добавлений и 3 удалений

Просмотреть файл

@ -6,7 +6,7 @@ using Xamarin.Localization.MSBuild;
namespace Xamarin.MacDev.Tasks { namespace Xamarin.MacDev.Tasks {
public abstract class GetMinimumOSVersionTaskBase : XamarinTask { public abstract class GetMinimumOSVersionTaskBase : XamarinTask {
public string AppManifest { get; set; } public ITaskItem AppManifest { get; set; }
[Required] [Required]
public string SdkVersion { get; set; } public string SdkVersion { get; set; }
@ -18,9 +18,9 @@ namespace Xamarin.MacDev.Tasks {
{ {
PDictionary plist = null; PDictionary plist = null;
if (!string.IsNullOrEmpty (AppManifest)) { if (!string.IsNullOrEmpty (AppManifest?.ItemSpec)) {
try { try {
plist = PDictionary.FromFile (AppManifest); plist = PDictionary.FromFile (AppManifest.ItemSpec);
} catch (Exception ex) { } catch (Exception ex) {
Log.LogError (null, null, null, AppManifest, 0, 0, 0, 0, MSBStrings.E0010, AppManifest, ex.Message); Log.LogError (null, null, null, AppManifest, 0, 0, 0, 0, MSBStrings.E0010, AppManifest, ex.Message);
return false; return false;