Remove notice from generated iOS Apps (#8857)

- The notice points to an out of date page, currently dead (will be redirected soon)
- https://github.com/xamarin/xamarin-macios/issues/8849 is the new home
This commit is contained in:
Chris Hamons 2020-06-15 15:52:08 -05:00 коммит произвёл GitHub
Родитель 0187a45359
Коммит 78dcb51fe3
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 4AEE18F83AFDEB23
17 изменённых файлов: 17 добавлений и 306 удалений

Просмотреть файл

@ -1100,10 +1100,14 @@ This indicates a bug in Xamarin.iOS. Please file a new issue on [github](https:/
Remove the directory `NOTICE` from the project.
Earlier versions of our tools generated a NOTICE file.
<a name="MT1017" />
### MT1017: Failed to create the NOTICE file: *.
Earlier versions of our tools generated a NOTICE file.
<a name="MT1018" />
### MT1018: Your application failed code-signing checks and could not be installed on the device '*'. Check your certificates, provisioning profiles, and bundle ids. Probably your device is not part of the selected provisioning profile (error: 0xe8008015).

Просмотреть файл

@ -190,7 +190,6 @@ public class B : A {}
var expectedFiles = new string []
{
"NOTICE",
"testApp",
"testApp.aotdata.armv7",
"testApp.aotdata.arm64",
@ -319,7 +318,6 @@ public class B : A {}
mtouch.GccFlags = "-v";
mtouch.AssertExecute (MTouchAction.BuildDev, "fourth build");
Console.WriteLine ("fourth build done");
mtouch.AssertAllModified (dt, name + " - fourth build", "NOTICE");
}
}
@ -2859,47 +2857,6 @@ public class TestApp {
}
}
[Test]
public void MT1016 ()
{
AssertDeviceAvailable ();
// #20607
using (var tool = new MTouchTool ()) {
tool.CreateTemporaryCacheDirectory ();
tool.CreateTemporaryApp ();
// Create a NOTICE directory
var notice = Path.Combine (tool.AppPath, "NOTICE");
Directory.CreateDirectory (notice);
tool.AssertExecuteFailure (MTouchAction.BuildDev);
tool.AssertError (1016, "Failed to create the NOTICE file because a directory already exists with the same name.");
}
}
[Test]
public void MT1017 ()
{
AssertDeviceAvailable ();
// #20607
using (var tool = new MTouchTool ()) {
tool.CreateTemporaryCacheDirectory ();
tool.CreateTemporaryApp ();
// Create a readonly NOTICE file
var notice = Path.Combine (tool.AppPath, "NOTICE");
File.WriteAllText (notice, "contents");
new FileInfo (notice).IsReadOnly = true;
tool.AssertExecute (MTouchAction.BuildDev);
Assert.AreNotEqual ("contents", File.ReadAllText (notice), "NOTICE file written successfully");
}
}
[Test]
public void MT1202 ()
{

Просмотреть файл

@ -662,7 +662,6 @@ namespace Xamarin.Bundler {
StripNativeCode ();
BundleAssemblies ();
WriteNotice ();
GenerateRuntimeOptions ();
if (Cache.IsCacheTemporary) {
@ -1283,35 +1282,6 @@ namespace Xamarin.Bundler {
}
}
void WriteNotice ()
{
if (!IsDeviceBuild || IsExtension)
return;
if (Embeddinator)
return;
WriteNotice (AppDirectory);
}
void WriteNotice (string directory)
{
var path = Path.Combine (directory, "NOTICE");
if (Directory.Exists (path))
throw new ProductException (1016, true, Errors.MT1016);
try {
// write license information inside the .app
StringBuilder sb = new StringBuilder ();
sb.Append ("Xamarin built applications contain open source software. ");
sb.Append ("For detailed attribution and licensing notices, please visit...");
sb.AppendLine ().AppendLine ().Append ("http://xamarin.com/mobile-licensing").AppendLine ();
Driver.WriteIfDifferent (path, sb.ToString ());
} catch (Exception ex) {
throw new ProductException (1017, true, ex, Errors.MT1017, ex.Message);
}
}
public static void CopyMSymData (string src, string dest)
{
if (string.IsNullOrEmpty (src) || string.IsNullOrEmpty (dest))
@ -2024,8 +1994,6 @@ namespace Xamarin.Bundler {
{
if (!Embeddinator)
return;
WriteNotice (output_path);
}
public void CreateFrameworkInfoPList (string output_path, string framework_name, string bundle_identifier, string bundle_name)

Просмотреть файл

@ -927,16 +927,6 @@
</value>
</data>
<data name="MT1016" xml:space="preserve">
<value>Failed to create the NOTICE file because a directory already exists with the same name.
</value>
</data>
<data name="MT1017" xml:space="preserve">
<value>Failed to create the NOTICE file: {0}
</value>
</data>
<data name="MT1022" xml:space="preserve">
<value>Could not copy the directory '{0}' to '{1}': {2}
</value>

Просмотреть файл

@ -1433,22 +1433,6 @@
<note>
</note>
</trans-unit>
<trans-unit id="MT1016">
<source>Failed to create the NOTICE file because a directory already exists with the same name.
</source>
<target state="new">Failed to create the NOTICE file because a directory already exists with the same name.
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1017">
<source>Failed to create the NOTICE file: {0}
</source>
<target state="new">Failed to create the NOTICE file: {0}
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1022">
<source>Could not copy the directory '{0}' to '{1}': {2}
</source>
@ -3143,4 +3127,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>

Просмотреть файл

@ -1433,22 +1433,6 @@
<note>
</note>
</trans-unit>
<trans-unit id="MT1016">
<source>Failed to create the NOTICE file because a directory already exists with the same name.
</source>
<target state="new">Failed to create the NOTICE file because a directory already exists with the same name.
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1017">
<source>Failed to create the NOTICE file: {0}
</source>
<target state="new">Failed to create the NOTICE file: {0}
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1022">
<source>Could not copy the directory '{0}' to '{1}': {2}
</source>
@ -3143,4 +3127,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>

Просмотреть файл

@ -1433,22 +1433,6 @@
<note>
</note>
</trans-unit>
<trans-unit id="MT1016">
<source>Failed to create the NOTICE file because a directory already exists with the same name.
</source>
<target state="new">Failed to create the NOTICE file because a directory already exists with the same name.
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1017">
<source>Failed to create the NOTICE file: {0}
</source>
<target state="new">Failed to create the NOTICE file: {0}
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1022">
<source>Could not copy the directory '{0}' to '{1}': {2}
</source>
@ -3143,4 +3127,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>

Просмотреть файл

@ -1433,22 +1433,6 @@
<note>
</note>
</trans-unit>
<trans-unit id="MT1016">
<source>Failed to create the NOTICE file because a directory already exists with the same name.
</source>
<target state="new">Failed to create the NOTICE file because a directory already exists with the same name.
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1017">
<source>Failed to create the NOTICE file: {0}
</source>
<target state="new">Failed to create the NOTICE file: {0}
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1022">
<source>Could not copy the directory '{0}' to '{1}': {2}
</source>
@ -3143,4 +3127,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>

Просмотреть файл

@ -1433,22 +1433,6 @@
<note>
</note>
</trans-unit>
<trans-unit id="MT1016">
<source>Failed to create the NOTICE file because a directory already exists with the same name.
</source>
<target state="new">Failed to create the NOTICE file because a directory already exists with the same name.
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1017">
<source>Failed to create the NOTICE file: {0}
</source>
<target state="new">Failed to create the NOTICE file: {0}
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1022">
<source>Could not copy the directory '{0}' to '{1}': {2}
</source>
@ -3143,4 +3127,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>

Просмотреть файл

@ -1433,22 +1433,6 @@
<note>
</note>
</trans-unit>
<trans-unit id="MT1016">
<source>Failed to create the NOTICE file because a directory already exists with the same name.
</source>
<target state="new">Failed to create the NOTICE file because a directory already exists with the same name.
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1017">
<source>Failed to create the NOTICE file: {0}
</source>
<target state="new">Failed to create the NOTICE file: {0}
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1022">
<source>Could not copy the directory '{0}' to '{1}': {2}
</source>
@ -3143,4 +3127,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>

Просмотреть файл

@ -1433,22 +1433,6 @@
<note>
</note>
</trans-unit>
<trans-unit id="MT1016">
<source>Failed to create the NOTICE file because a directory already exists with the same name.
</source>
<target state="new">Failed to create the NOTICE file because a directory already exists with the same name.
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1017">
<source>Failed to create the NOTICE file: {0}
</source>
<target state="new">Failed to create the NOTICE file: {0}
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1022">
<source>Could not copy the directory '{0}' to '{1}': {2}
</source>
@ -3143,4 +3127,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>

Просмотреть файл

@ -1433,22 +1433,6 @@
<note>
</note>
</trans-unit>
<trans-unit id="MT1016">
<source>Failed to create the NOTICE file because a directory already exists with the same name.
</source>
<target state="new">Failed to create the NOTICE file because a directory already exists with the same name.
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1017">
<source>Failed to create the NOTICE file: {0}
</source>
<target state="new">Failed to create the NOTICE file: {0}
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1022">
<source>Could not copy the directory '{0}' to '{1}': {2}
</source>
@ -3143,4 +3127,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>

Просмотреть файл

@ -1433,22 +1433,6 @@
<note>
</note>
</trans-unit>
<trans-unit id="MT1016">
<source>Failed to create the NOTICE file because a directory already exists with the same name.
</source>
<target state="new">Failed to create the NOTICE file because a directory already exists with the same name.
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1017">
<source>Failed to create the NOTICE file: {0}
</source>
<target state="new">Failed to create the NOTICE file: {0}
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1022">
<source>Could not copy the directory '{0}' to '{1}': {2}
</source>
@ -3143,4 +3127,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>

Просмотреть файл

@ -1433,22 +1433,6 @@
<note>
</note>
</trans-unit>
<trans-unit id="MT1016">
<source>Failed to create the NOTICE file because a directory already exists with the same name.
</source>
<target state="new">Failed to create the NOTICE file because a directory already exists with the same name.
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1017">
<source>Failed to create the NOTICE file: {0}
</source>
<target state="new">Failed to create the NOTICE file: {0}
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1022">
<source>Could not copy the directory '{0}' to '{1}': {2}
</source>
@ -3143,4 +3127,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>

Просмотреть файл

@ -1433,22 +1433,6 @@
<note>
</note>
</trans-unit>
<trans-unit id="MT1016">
<source>Failed to create the NOTICE file because a directory already exists with the same name.
</source>
<target state="new">Failed to create the NOTICE file because a directory already exists with the same name.
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1017">
<source>Failed to create the NOTICE file: {0}
</source>
<target state="new">Failed to create the NOTICE file: {0}
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1022">
<source>Could not copy the directory '{0}' to '{1}': {2}
</source>
@ -3143,4 +3127,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>

Просмотреть файл

@ -1433,22 +1433,6 @@
<note>
</note>
</trans-unit>
<trans-unit id="MT1016">
<source>Failed to create the NOTICE file because a directory already exists with the same name.
</source>
<target state="new">Failed to create the NOTICE file because a directory already exists with the same name.
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1017">
<source>Failed to create the NOTICE file: {0}
</source>
<target state="new">Failed to create the NOTICE file: {0}
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1022">
<source>Could not copy the directory '{0}' to '{1}': {2}
</source>
@ -3143,4 +3127,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>

Просмотреть файл

@ -1433,22 +1433,6 @@
<note>
</note>
</trans-unit>
<trans-unit id="MT1016">
<source>Failed to create the NOTICE file because a directory already exists with the same name.
</source>
<target state="new">Failed to create the NOTICE file because a directory already exists with the same name.
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1017">
<source>Failed to create the NOTICE file: {0}
</source>
<target state="new">Failed to create the NOTICE file: {0}
</target>
<note>
</note>
</trans-unit>
<trans-unit id="MT1022">
<source>Could not copy the directory '{0}' to '{1}': {2}
</source>
@ -3143,4 +3127,4 @@
</trans-unit>
</body>
</file>
</xliff>
</xliff>