From a64506dd4a9d692b1a156df846f485088709a119 Mon Sep 17 00:00:00 2001 From: dustin-wojciechowski Date: Fri, 6 Oct 2023 13:10:28 -0700 Subject: [PATCH] Revert "[MacCatalyst] Added Default Entitlements for MacCatalyst projects" (#19125) Reverts xamarin/xamarin-macios#18669 per discussion in MAUI about sdk defaults. --- .../Xamarin.Shared.Sdk.DefaultItems.targets | 13 ---------- tests/dotnet/UnitTests/ProjectTest.cs | 26 ------------------- 2 files changed, 39 deletions(-) diff --git a/dotnet/targets/Xamarin.Shared.Sdk.DefaultItems.targets b/dotnet/targets/Xamarin.Shared.Sdk.DefaultItems.targets index 3862d66833..d100091037 100644 --- a/dotnet/targets/Xamarin.Shared.Sdk.DefaultItems.targets +++ b/dotnet/targets/Xamarin.Shared.Sdk.DefaultItems.targets @@ -23,19 +23,6 @@ - - True - True - - - - - - - - - - diff --git a/tests/dotnet/UnitTests/ProjectTest.cs b/tests/dotnet/UnitTests/ProjectTest.cs index be22ae9191..efdc34fdc1 100644 --- a/tests/dotnet/UnitTests/ProjectTest.cs +++ b/tests/dotnet/UnitTests/ProjectTest.cs @@ -1309,32 +1309,6 @@ namespace Xamarin.Tests { } } - [TestCase (ApplePlatform.MacCatalyst, "maccatalyst-x64", "Release")] - [TestCase (ApplePlatform.MacCatalyst, "maccatalyst-x64", "Debug")] - public void CheckForMacCatalystDefaultEntitlements (ApplePlatform platform, string runtimeIdentifiers, string configuration) - { - var project = "Entitlements"; - Configuration.IgnoreIfIgnoredPlatform (platform); - Configuration.AssertRuntimeIdentifiersAvailable (platform, runtimeIdentifiers); - - var project_path = GetProjectPath (project, runtimeIdentifiers: runtimeIdentifiers, platform: platform, out var appPath, configuration: configuration); - Clean (project_path); - - var properties = GetDefaultProperties (runtimeIdentifiers); - properties ["Configuration"] = configuration; - DotNet.AssertBuild (project_path, properties); - - var executable = GetNativeExecutable (platform, appPath); - var foundEntitlements = TryGetEntitlements (executable, out var entitlements); - Assert.IsTrue (foundEntitlements, "Issues found with Entitlements."); - if (configuration == "Release") { - Assert.IsTrue (entitlements!.Get ("com.apple.security.app-sandbox")?.Value, "com.apple.security.app-sandbox enlistment was not found in Release configuration."); - Assert.IsNull (entitlements.Get ("com.apple.security.get-task-allow")?.Value, "com.apple.security.get-task-allow enlistment was found in Release configuration."); - } else if (configuration == "Debug") { - Assert.IsTrue (entitlements!.Get ("com.apple.security.get-task-allow")?.Value, "com.apple.security.get-task-allow enlistment was not found in Debug configuration."); - } - } - // [TestCase (ApplePlatform.MacCatalyst, null, "Release")] [TestCase (ApplePlatform.MacOSX, null, "Release")] public void NoWarnCodesign (ApplePlatform platform, string runtimeIdentifiers, string configuration)