From a8e5fc541349b23e42cdc927fa04546c66de14dd Mon Sep 17 00:00:00 2001 From: Alex Soto Date: Mon, 19 Feb 2018 11:55:42 -0600 Subject: [PATCH] [Intents] Fix xtro output (#3512) (#3520) --- src/intents.cs | 18 +++++++++++++++--- tests/xtro-sharpie/macOS-Intents.ignore | 9 +++++++++ tests/xtro-sharpie/macOS-Intents.todo | 6 ------ 3 files changed, 24 insertions(+), 9 deletions(-) diff --git a/src/intents.cs b/src/intents.cs index d0f1fec0ea..c22b594876 100644 --- a/src/intents.cs +++ b/src/intents.cs @@ -282,8 +282,12 @@ namespace Intents { FailurePreviousRideNeedsFeedback, } - [iOS (10, 0)] +#if XAMCORE_4_0 // TODO: Double check this if XAMCORE_4_0 happens, its been 2 years (2018) and still not usable in macOS + [NoMac] +#else [Mac (10, 12, 0, PlatformArchitecture.Arch64)] +#endif + [iOS (10, 0)] [Watch (3, 2)] [Native] public enum INMessageAttribute : long { @@ -2143,8 +2147,12 @@ namespace Intents { INDateComponentsRangeResolutionResult Unsupported { get; } } - [iOS (10, 0)] +#if XAMCORE_4_0 // TODO: Double check this if XAMCORE_4_0 happens, its been 2 years (2018) and still not usable in macOS + [NoMac] +#else [Mac (10, 12, 0, PlatformArchitecture.Arch64)] +#endif + [iOS (10, 0)] [Watch (3, 2)] [Protocol] interface INCallsDomainHandling : INStartAudioCallIntentHandling, INSearchCallHistoryIntentHandling @@ -3077,8 +3085,12 @@ namespace Intents { INMessageAttributeOptionsResolutionResult Unsupported { get; } } - [iOS (10, 0)] +#if XAMCORE_4_0 // TODO: Double check this if XAMCORE_4_0 happens, its been 2 years (2018) and still not usable in macOS + [NoMac] +#else [Mac (10, 12, 0, PlatformArchitecture.Arch64)] +#endif + [iOS (10, 0)] [Watch (3, 2)] [BaseType (typeof (INIntentResolutionResult))] [DisableDefaultCtor] diff --git a/tests/xtro-sharpie/macOS-Intents.ignore b/tests/xtro-sharpie/macOS-Intents.ignore index 08c767f8c2..2ff05edd0f 100644 --- a/tests/xtro-sharpie/macOS-Intents.ignore +++ b/tests/xtro-sharpie/macOS-Intents.ignore @@ -4,3 +4,12 @@ ## unsorted !unknown-native-enum! INSetMessageAttributeIntentResponseCode bound + +## Fixed in XAMCORE_4_0 but with a conditional TODO check in code +## API_AVAILABLE(macosx(10.12), ios(10.0)); This is supposed to be there according to availability (Last Review: Feb 2018) +!unknown-protocol! INCallsDomainHandling bound + +## No availability set on headers, it is possible to be fixed later since makes sense to have in macOS. +## unfortunately it is not at the moment (Last Review: Feb 2018) +!unknown-native-enum! INMessageAttribute bound +!unknown-type! INMessageAttributeResolutionResult bound diff --git a/tests/xtro-sharpie/macOS-Intents.todo b/tests/xtro-sharpie/macOS-Intents.todo index d9c95c2886..e69de29bb2 100644 --- a/tests/xtro-sharpie/macOS-Intents.todo +++ b/tests/xtro-sharpie/macOS-Intents.todo @@ -1,6 +0,0 @@ -## API_AVAILABLE(macosx(10.12), ios(10.0)); This is supposed to be there according to availability (Last Review: Beta 3) -!unknown-protocol! INCallsDomainHandling bound - -## No availability set on headers, it is possible to be fixed later since makes sense to have in macOS -!unknown-native-enum! INMessageAttribute bound -!unknown-type! INMessageAttributeResolutionResult bound