From ba7e73b5dde8f472df8175b945a8c219d24f558f Mon Sep 17 00:00:00 2001 From: Rolf Bjarne Kvinge Date: Mon, 20 Jul 2020 10:27:07 +0200 Subject: [PATCH] [xharness] Don't replace existing files, instead add new files, when providing human-readable logs. (#9123) This makes understanding what's going on much easier. --- .../Microsoft.DotNet.XHarness.iOS.Shared/TestReporter.cs | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/TestReporter.cs b/tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/TestReporter.cs index 7ae0fb8ef5..6d1df92559 100644 --- a/tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/TestReporter.cs +++ b/tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/TestReporter.cs @@ -320,12 +320,9 @@ namespace Microsoft.DotNet.XHarness.iOS.Shared { } path = newFilename; - // write the human readable results in a tmp file, which we later use to step on the logs - var tmpFile = Path.Combine (Path.GetTempPath (), Guid.NewGuid ().ToString ()); - (parseResult.resultLine, parseResult.failed) = resultParser.GenerateHumanReadableResults (path, tmpFile, xmlType); - File.Copy (tmpFile, test_log_path, true); - File.Delete (tmpFile); - + var humanReadableLog = logs.CreateFile (Path.GetFileNameWithoutExtension (test_log_path) + ".log", LogType.NUnitResult.ToString ()); + (parseResult.resultLine, parseResult.failed) = resultParser.GenerateHumanReadableResults (path, humanReadableLog, xmlType); + // we do not longer need the tmp file logs.AddFile (path, LogType.XmlLog.ToString ()); return parseResult;