From f62de4722b30ce20b67e0a0005ecba29751c1c8b Mon Sep 17 00:00:00 2001 From: Sebastien Pouliot Date: Thu, 29 Mar 2018 17:58:55 -0400 Subject: [PATCH] Bump Xcode 9.3 to the final/released version (#3833) * [tests] Tweak tests as NKIssue/NKAssetDownload now respond to NS[Secure]Coding without any mention in header files --- Make.config | 4 ++-- tests/introspection/iOS/iOSApiProtocolTest.cs | 4 ++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Make.config b/Make.config index 2a1d379c5c..542fbfa505 100644 --- a/Make.config +++ b/Make.config @@ -56,8 +56,8 @@ IOS_PACKAGE_VERSION_BUILD=$(IOS_COMMIT_DISTANCE) IOS_PACKAGE_UPDATE_ID=$(shell printf "2%02d%02d%02d%03d" $(IOS_PACKAGE_VERSION_MAJOR) $(IOS_PACKAGE_VERSION_MINOR) $(IOS_PACKAGE_VERSION_REV) $(IOS_PACKAGE_VERSION_BUILD)) XCODE_VERSION=9.3 -XCODE_URL=http://xamarin-storage/bot-provisioning/xcodes/Xcode_9.3_beta_4.xip -XCODE_DEVELOPER_ROOT=/Applications/Xcode93-beta4.app/Contents/Developer +XCODE_URL=http://xamarin-storage/bot-provisioning/xcodes/Xcode_9.3.xip +XCODE_DEVELOPER_ROOT=/Applications/Xcode93.app/Contents/Developer # Minimum Mono version MIN_MONO_VERSION=5.8.0.0 diff --git a/tests/introspection/iOS/iOSApiProtocolTest.cs b/tests/introspection/iOS/iOSApiProtocolTest.cs index 565798732b..80b7baeed6 100644 --- a/tests/introspection/iOS/iOSApiProtocolTest.cs +++ b/tests/introspection/iOS/iOSApiProtocolTest.cs @@ -218,6 +218,8 @@ namespace Introspection { case "PKSuicaPassProperties": // Conformance not in headers case "PKTransitPassProperties": // Conformance not in headers case "ARReferenceImage": // Conformance removed from headers in Xcode 9.3 Beta 4 + case "NKAssetDownload": + case "NKIssue": return true; // Header shows implementing NSSecureCoding, but supportsSecureCoding returns false. Radar #34800025 case "HKSeriesBuilder": @@ -372,6 +374,8 @@ namespace Introspection { case "PKSuicaPassProperties": // Conformance not in headers case "PKTransitPassProperties": // Conformance not in headers case "ARReferenceImage": // Conformance removed from headers in Xcode 9.3 Beta 4 + case "NKAssetDownload": + case "NKIssue": return true; // Header shows implementing NSSecureCoding, but supportsSecureCoding returns false. Radar #34800025 case "HKSeriesBuilder":