xamarin-macios

Граф коммитов

Автор	SHA1	Сообщение	Дата
Rolf Bjarne Kvinge	691721a9dc	[msbuild] Default to verbose logs for mmp/mtouch if creating a binary log. (#10147 ) This way we get the full output from mtouch/mmp when the user creates a binary log.	2020-11-25 15:09:21 +01:00
Sebastien Pouliot	229edf7f85	[msbuild] Add verbosity options on separate lines for mtouch parsing (#7649 ) This is more strict than the response-file spec [0] (and filed as a separate issue [1]) but `mtouch` currently requires one option-per-line (for filtering some options) for the cache to work properly (i.e. so it can ignore the `-v` and the `-q` and re-use the existing, cached, binaries). E.g. from: ``` ... -v -v -v -v ``` to ``` ... -v -v -v -v ``` This is an optimization fix (since cached output helps build times) and it's also part of a bug fix [2] (part of another commit [3], that was reverted [4] due to other issues, like this one). This needs another fix [5] to work properly (like `mtouch` requires) but both can be applied separately (so different PR for different changes). [0] https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-options/response-file-compiler-option [1] https://github.com/xamarin/xamarin-macios/issues/7644 [2] https://github.com/xamarin/xamarin-macios/issues/7514 [3] https://github.com/xamarin/xamarin-macios/pull/7544 [4] https://github.com/xamarin/xamarin-macios/pull/7589 [5] https://github.com/xamarin/xamarin-macios/pull/7647	2020-01-02 15:02:28 -05:00
Sebastien Pouliot	9fd03625b4	[msbuild] Ensure the output of `mtouch` (and friends) are included in binary logs. Fix #7035 (#7288 ) and by friends I mean `mmp` and `btouch` What does this do ? 1. Assume that output of `mtouch` (and other similar tools) is always of high importance. Why ? - If not then it's not saved in the binary log (even if visible on the console/text logs). - The logging of `mtouch` (and friends) is dynamic, based on a supplied verbosity level. - If a verbosity level _anywhere_ then it's a clear sign that the developer wants that extra output (and that includes binary logs). 2. Assume the _global_ verbosity of `msbuild` from the console is just as valid/useful than the one from VSfM. - CI/bots produce logs and they should be useful to diagnose build issues. - Setting verbosity in several places is error-prone, which delay investigations and results. - Running the same project, with the same `msbuild` verbosity, should be identical between IDE and console. What does that mean ? Using `msbuild /v:diag /bl:out.binlog` you get a small(er) binary log that has everything[1] you need to diagnose a Xamarin.iOS (or Mac) build. It's also identical to the output what VSfM produce (for the same `msbuild` verbosity level). [1] we might need to review what we log if we're missing interesting stuff References: https://github.com/xamarin/xamarin-macios/issues/7035	2019-10-25 17:44:35 -04:00

Автор

SHA1

Сообщение

Дата

Rolf Bjarne Kvinge

691721a9dc

[msbuild] Default to verbose logs for mmp/mtouch if creating a binary log. (#10147 )

This way we get the full output from mtouch/mmp when the user creates a binary log.

2020-11-25 15:09:21 +01:00

Sebastien Pouliot

229edf7f85

[msbuild] Add verbosity options on separate lines for mtouch parsing (#7649 )

This is more strict than the response-file spec [0] (and filed as a
separate issue [1]) but `mtouch` currently requires one option-per-line
(for filtering some options) for the cache to work properly (i.e. so it
can ignore the `-v` and the `-q` and re-use the existing, cached,
binaries). E.g. from:

```
...
-v -v -v -v
```

to

```
...
-v
-v
-v
-v
```

This is an optimization fix (since cached output helps build times) and
it's also part of a bug fix [2] (part of another commit [3], that was
reverted [4] due to other issues, like this one).

This needs another fix [5] to work properly (like `mtouch` requires)
but both can be applied separately (so different PR for different
changes).

[0] https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-options/response-file-compiler-option
[1] https://github.com/xamarin/xamarin-macios/issues/7644
[2] https://github.com/xamarin/xamarin-macios/issues/7514
[3] https://github.com/xamarin/xamarin-macios/pull/7544
[4] https://github.com/xamarin/xamarin-macios/pull/7589
[5] https://github.com/xamarin/xamarin-macios/pull/7647

2020-01-02 15:02:28 -05:00

Sebastien Pouliot

9fd03625b4

[msbuild] Ensure the output of `mtouch` (and friends) are included in binary logs. Fix #7035 (#7288 )

and by friends I mean `mmp` and `btouch`

What does this do ?

1. Assume that output of `mtouch` (and other similar tools) is **always** of high importance. Why ?

- If not then it's not saved in the binary log (even if visible on the console/text logs).
- The logging of `mtouch` (and friends) is dynamic, based on a supplied verbosity level.
- If a verbosity level _anywhere_ then it's a clear sign that the developer wants that extra output (and that includes binary logs).

2. Assume the _global_ verbosity of `msbuild` from the console is just as valid/useful than the one from VSfM.

- CI/bots produce logs and they should be useful to diagnose build issues.
- Setting verbosity in several places is error-prone, which delay investigations and results.
- Running the same project, with the same `msbuild` verbosity, should be identical between IDE and console.

What does that mean ?

Using `msbuild /v:diag /bl:out.binlog` you get a small(er) binary log that has everything[1] you need to diagnose a Xamarin.iOS (or Mac) build. It's also identical to the output what VSfM produce (for the same `msbuild` verbosity level).

[1] we might need to review what we log if we're missing interesting stuff

References:
https://github.com/xamarin/xamarin-macios/issues/7035

2019-10-25 17:44:35 -04:00

3 Коммитов