We have been leaving statueses as pending, the main reason is that when
we ran the tests, we set the wrong status. This was complicated because
we wrote comments AND set the statuses mixing two operations. We now
have the status and the comment separated for easy debugging and more
flexibility.
To avoid issues when setting automerging we add a status for the API
diff. If human intervention is needed to check the changes the status
will be set to error, this way the automerging wont happen. We set the
status to error even when we only have a warning, better safe than
sorry.
Since we have several builds per PR and several comments per build, the
comments sections are getting very noise. To fix that, we use GitHub
GraphQL to query all the comments for a PR (includes PR comments and
commit comments), filter them by user and title and minimize them
accordingly.
The behaviour from apple is wrong, PUT and POST are differnet in that PUT is idempotent.
Calling PUT several times successively has the same effect (that is no side effect),
where successive identical POST may have additional effects
We should not let the native code cache the calls.
* Add the resx file for localization and move error and warning strings
* Change NStrings.resx -> Errors.resx
* using the new namespace
Co-authored-by: TJ Lambert <tjlambert@microsoft.com>
It includes a change revert because of threading freeze issues.
An issue has been detected in Xamarin.Messaging 1.5.26 and 1.6.1 that makes the code unstable and sensitive to thread freeze issues, so we are reverting back the changes until we can stabilize it.
This delays the fix of a bug in MSBuild command line builds for iOS remote builds.
Add a few classes that will be later used to create the comments for the
tests.
- GitHubStatus/es: Allows to represent a github status, we are addign a
class per concern.
- TestResults: Contains the information and logic of a test result.
Implements the same interface as the other comment objects so that we
resuse the comment code.
Tests have been added and modified the github action to run on pull
requests too.
* enable nullability
* use is null
* use an empty array
Co-authored-by: TJ Lambert <tjlambert@microsoft.com>
Co-authored-by: Manuel de la Pena <mandel@microsoft.com>
* [NET Attribute Conversion] Chip Framework
* [NET Attribute Conversion] Rerun with many fixes
* Fix generator crash when compiling attributes with no introduced version
* Test changes for availability re-run. One new test
Microsoft.Dotnet.Sdk.Internal
From Version 6.0.300-preview.22204.3 -> To Version 6.0.300-preview.22205.8
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.NETCore.App.Ref
From Version 6.0.4 -> To Version 6.0.5
Dependency coherency updates
Microsoft.NET.Workload.Emscripten.Manifest-6.0.100
From Version 6.0.4 -> To Version 6.0.4 (parent: Microsoft.NETCore.App.Ref
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Ask ditto to thin native libraries and frameworks when copying them to the app
bundle to remove slices for architectures we're not building for.
Also add tests.
Fixes https://github.com/xamarin/xamarin-macios/issues/13081.
Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>
VS MobileTools Engineering Service 2
Peter Collins
Manuel de la Pena
Přemek Vysoký
github-actions[bot]
TJ Lambert
Mauro Agnoletti
Rolf Bjarne Kvinge
Steve Hawley
Alex Soto
Chris Hamons
dotnet-maestro[bot]