14559e35bd
* [msbuild] Use task assembly path via a property Xamarin.Mac.Common.ImplicitFacade.msbuild.targets: $(_NETBuildExtensionsTaskAssembly) * [msbuild] Fix path to NET.Build.Extensions task assembly .. which is no longer available for `net46`. Instead use the latest `net472` path. The incorrect path effectively disabled the `GetDependsOnNETStandard` task, causing the issue. Partially fixes https://github.com/xamarin/xamarin-macios/issues/6552 . * [msbuild] Fix XM builds which use netstandard libraries. `Xamarin.Mac.Common.ImplicitFacade.msbuild.targets`: `ImplicitlyExpandDesignTimeFacades` adds a reference to `netstandard.dll` by expanding the facades, if any of the references depend on it. Usually, this gets handled by msbuild SDKs but in case of XM, this doesn't happen in all cases. So, we need to scan the references for a `netstandard` dependency. The `ResolveAssemblyReference` task does this for us and populates `$(_DependsOnNETStandard)` property. If it does not, then we use `GetDependsOnNETStandard` task to get the same information. Issue: - the target incorrectly uses `$(DependsOnNETStandard)` instead of `($_DependsOnNETStandard)`. - Fixing that means that condition `$(_DependsOnNETStandard) == ''` fails whenever `ResolveAssemblyReference` task runs (setting the property to `true` or `false`), causing `$(XM_DependsOnNETStandard)` to be unset. - thus failing the following logic to expand the facades when `$(_DependsOnNETStandard) == true` So, we use the `$(_DependsOnNETStandard)` as the default value for `$(XM_DependsOnNETStandard)`, so that it is correctly set to `true`, irrespective of how we got that information, allowing us to correctly expand facades when required. Partially fixes https://github.com/xamarin/xamarin-macios/issues/6552 . * [msbuild] Fix XI builds which use netstandard libraries. `Xamarin.iOS.Common.targets`: Issue: - the target incorrectly uses `$(DependsOnNETStandard)` instead of `($_DependsOnNETStandard)`. - Fixing that means that condition `$(_DependsOnNETStandard) == ''` fails whenever `ResolveAssemblyReference` task runs (setting the property to `true` or `false`), causing `$(XI_DependsOnNETStandard)` to be unset. - thus failing the following logic to expand the facades when `$(_DependsOnNETStandard) == true` So, we use the `$(_DependsOnNETStandard)` as the default value for `$(XI_DependsOnNETStandard)`, so that it is correctly set to `true`, irrespective of how we got that information, allowing us to correctly expand facades when required. Prompted by: https://github.com/xamarin/xamarin-macios/issues/6552 |
||
|---|---|---|
| builds | ||
| docs | ||
| external | ||
| fsharp | ||
| jenkins | ||
| mk | ||
| mono | ||
| msbuild | ||
| opentk | ||
| runtime | ||
| src | ||
| tests | ||
| tools | ||
| .gitignore | ||
| .gitmodules | ||
| CODEOWNERS | ||
| ISSUE_TEMPLATE.md | ||
| LICENSE | ||
| Make.config | ||
| Make.versions | ||
| Makefile | ||
| NuGet.config | ||
| README.md | ||
| Versions-ios.plist.in | ||
| Versions-mac.plist.in | ||
| Xamarin.Mac.sln | ||
| Xamarin.iOS.sln | ||
| banner.png | ||
| configure | ||
| mac-entitlements.plist | ||
| product.snk | ||
| system-dependencies.sh | ||
| versions-check.csharp | ||
README.md
Xamarin.iOS & Xamarin.Mac
Welcome!
This module is the main repository for both Xamarin.iOS and Xamarin.Mac.
These SDKs allow us to create native iOS, tvOS, watchOS and macOS applications using the same UI controls we would in Objective-C and Xcode, except with the flexibility and elegance of a modern language (C#), the power of the .NET Base Class Library (BCL), and two first-class IDEs—Visual Studio for Mac and Visual Studio—at our fingertips.
This repository is where we do development for the Xamarin.iOS and Xamarin.Mac SDKs. There are a few ways that you can contribute, for example:
- Submit bugs and feature requests
- Review source code changes
- Submit pull requests to resolve issues and fix bugs
Contributing
If you are interested in fixing issues and contributing directly to the code base, please see the document How to Contribute, which covers the following:
- How to build and run from source
- The development workflow, including debugging and running tests
- Coding Guidelines
- Submitting pull requests
Feedback
- Ask a question on Stack Overflow or the Xamarin Forums
- Request a new feature on GitHub
- Vote on existing feature requests
- Submit bugs to GitHub Issues
- Discuss development and design on Gitter
License
Copyright (c) .NET Foundation Contributors. All rights reserved. Licensed under the MIT License.