xamarin-macios/msbuild/Xamarin.iOS.Tasks/Contracts
Emanuel Fernandez Dell'Oca ecccb8954e
[dotnet] Revert changes that separate Messaging from Xamarin.iOS.Tasks to fix dotnet build (#10738)
This reverts commit 9a27951a99.

The purpose of the original commit was to take out 4 tasks that were only executed from Windows to the Windows specific pack (and enabling more tasks that need to be executed remotely on that pack).

To execute tasks remotely the build will initially run `SayHello` which connects to the Mac and shares the connection with all the tasks through IBuildEngine4[1]. When that connection object is retrieved on the tasks we need to cast it as a Messaging connection type, and this works from Visual Studio and msbuild because there's just one messaging assembly loaded.

But it doesn't work on dotnet/msbuild, because there's a feature called ALC (AssemblyLoadContext) which will load each assembly task into it's own context[2], loading all its dependencies in that context. In this scenario sharing custom objects between tasks won't work because the original object type could be from a different context than the one retrieving it. This is described here: https://github.com/dotnet/msbuild/issues/5084.

[1] https://docs.microsoft.com/en-us/dotnet/api/microsoft.build.framework.ibuildengine4?view=msbuild-16-netcore
[2] https://github.com/dotnet/msbuild/blob/master/documentation/specs/task-isolation-and-dependencies.md
2021-03-01 08:05:01 +01:00
..
GetUniversalTypeIdentifierMessage.cs [dotnet] Revert changes that separate Messaging from Xamarin.iOS.Tasks to fix dotnet build (#10738) 2021-03-01 08:05:01 +01:00
GetUniversalTypeIdentifierResult.cs [dotnet] Revert changes that separate Messaging from Xamarin.iOS.Tasks to fix dotnet build (#10738) 2021-03-01 08:05:01 +01:00
VerifyXcodeVersionMessage.cs [dotnet] Revert changes that separate Messaging from Xamarin.iOS.Tasks to fix dotnet build (#10738) 2021-03-01 08:05:01 +01:00
VerifyXcodeVersionResult.cs [dotnet] Revert changes that separate Messaging from Xamarin.iOS.Tasks to fix dotnet build (#10738) 2021-03-01 08:05:01 +01:00