cb998a3589
.NET/MSBuild don't handle symlinks properly [1], which means that we can't ask .NET to copy frameworks to the app bundle, since frameworks may contain symlinks. In our case, the symptom was that instead of copying symlinks, the file the symlink pointed to was copied instead, and then codesign complained about invalid bundle format when we tried to sign the framework. We fix this by having our own target (_CopyFrameworksToBundle) to copy frameworks to the app bundle (instead of adding all the files in the frameworks to the ResolvedFileToPublish item group), and then using 'ditto' to copy the frameworks. In order to create a test case for this, I also made the macOS and Mac Catalyst versions of the XTest framework use symlinks: * Create a proper XTest framework bundle hierarchy for macOS and Mac Catalyst by using the typical symlink structure (actual files in the Versions/A subdirectory, and then symlinks pointing into that directory). * Create a separate Info.plist for each platform for XTest.framework, since using an otherwise correct framework makes tooling (such as codesign) complain if the Info.plist isn't correct too. This made our existing tests show the bug. Finally I had to fix signing frameworks where the executable is a symlink. We were first resolving symlinks for the input - say we had an Example.framework/Example symlink to Example.framework/Versions/A/Example - and then checking the parent directory if it's a framework. The parent directory of 'Example.framework/Versions/A/Example' is 'A', which did not meet our framewrok condition (if it ends with '.framework'). The fix is to adjust the logic to resolve symlinks after checking if the input is a framework or not. [1]: https://github.com/dotnet/msbuild/issues/6821 Fixes https://github.com/xamarin/xamarin-macios/issues/12369. |
||
|---|---|---|
| .. | ||
| Steps | ||
| .gitignore | ||
| ApplyPreserveAttributeBase.cs | ||
| BackingFieldDelayHandler.cs | ||
| Compat.cs | ||
| DotNetResolver.cs | ||
| Extensions.cs | ||
| LinkerConfiguration.cs | ||
| Makefile | ||
| README.md | ||
| SetupStep.cs | ||
| dotnet-linker.csproj | ||
| dotnet-linker.sln | ||
README.md
Linker
This directory contains the custom linker steps for the managed linker when building Xamarin.iOS/tvOS/watchOS/macOS apps using .NET 5.
This is work in progress, and is not in a releasable state yet.