xamarin-macios/msbuild/Xamarin.MacDev.Tasks.Core
Rolf Bjarne Kvinge 43f87ec4c1
[msbuild] Only conditionally copy the entire input directory from Windows in the Ditto task. (#14495)
Sometimes we want to copy the entire input directory from Windows to the Mac
when executing the Ditto task remotely, and sometimes we don't.

In particular we do not want to copy the input directory when the directory on
Windows is an incomplete mirror of what's on the Mac - one scenario being when
copying the app bundle to prepare for IPA creation. The .app directory on
Windows is not complete - all the files are there (maybe? not quite sure, but
that's beside the point here), but some may be empty, because when we only
care about the timestamp for a file, we'll create an empty file on Windows to
mirror the actual file on Mac. Copying this incomplete directory to the Mac,
overwriting the correct files there, will break things badly.

However, sometimes we're not mirroring a directory on Windows, but instead we
have directories as actual build input (for instances frameworks from NuGets),
and in that case we want to copy everything to the Mac.

So this PR adds a parameter to the Ditto task to optionally copy the directory
from Windows for remote builds, and we enable this behavior when we want it -
specifically when copying frameworks.

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1506009 while not
regressing https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1492635.

Ref: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1506009
Ref: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1492635
Ref: https://github.com/xamarin/xamarin-macios/pull/14375
2022-03-25 14:08:05 +01:00
..
Extensions [msbuild] Save/restore all the NativeReference metadata. 2022-03-22 16:14:07 +01:00
MsBuildTasks Fix some whitespace issues in various files. (#12399) 2021-08-11 10:06:46 +02:00
Properties [msbuild] Sign Xamarin.iOS.Tasks.dll and Xamarin.Mac.Tasks.dll. Fixes #9835. (#12831) 2021-09-28 17:31:35 +02:00
Tasks [msbuild] Only conditionally copy the entire input directory from Windows in the Ditto task. (#14495) 2022-03-25 14:08:05 +01:00
AssetPackUtils.cs Fix some whitespace issues in various files. (#12399) 2021-08-11 10:06:46 +02:00
BundleResource.cs Fix some whitespace issues in various files. (#12399) 2021-08-11 10:06:46 +02:00
CommandLineArgumentBuilder.cs [msbuild] Call the generator using a response file. (#12756) 2021-09-20 07:40:57 +02:00
DataConverter.cs Build MSBuild targets & assemblies. 2016-04-24 14:48:44 -04:00
ErrorHelper.msbuild.cs [msbuild] Use the same prefix in ErrorHelper as we do in other MSBuild code. 2021-06-24 11:40:07 +02:00
LinkTarget.cs Fix some whitespace issues in various files. (#12399) 2021-08-11 10:06:46 +02:00
LinkerOptions.cs [msbuild] Add support for computing linker arguments for native references that are dynamic libraries. 2021-12-22 10:17:34 +01:00
LoggingExtensions.cs [msbuild] Fix a few paths to have consistently macOS paths. (#14354) 2022-03-09 21:53:14 -05:00
NativeReferenceKind.cs Fix some whitespace issues in various files. (#12399) 2021-08-11 10:06:46 +02:00
PlatformFramework.cs [tests] Add tests for CompileAppManifest and ReadAppManifest. 2021-08-24 14:41:20 +02:00
PlatformUtils.cs Fix some whitespace issues in various files. (#12399) 2021-08-11 10:06:46 +02:00
Sdks.cs Fix some whitespace issues in various files. (#12399) 2021-08-11 10:06:46 +02:00
StringParserService.cs Fix some whitespace issues in various files. (#12399) 2021-08-11 10:06:46 +02:00
TargetArchitecture.cs [msbuild] Add a TargetArchitectures argument to the LinkNativeCode task. (#9945) 2020-10-23 09:12:34 +02:00
VerbosityUtils.cs Fix some whitespace issues in various files. (#12399) 2021-08-11 10:06:46 +02:00
Xamarin.MacDev.Tasks.Core.csproj [msbuild] Store the .NET version in the app's Info.plist when building an app using .NET. Fixes #14108. (#14215) 2022-02-24 20:44:42 +01:00