xamarin-macios/dotnet
Chris Hamons a6eb528197
[net6][msbuild] Set SelfContained for AppExtensions sooner to fix publishing (#12703)
This PR resolves a crash when running the linker on publishing iOS extensions.

The crash would occur here in failing to resolve corelib.

The reason this would fail was System.Private.CoreLib.dll was not in input_assemblies.

This was because we were passes the set of reference assemblies not the expected 'real' ones, and those do not include CoreLib.

After a bunch of digging, this was because _ComputeManagedRuntimePackAssembliesIfSelfContained target was not being set as a condition of _ComputeAssembliesToPostprocessOnPublish.

_ComputeManagedRuntimePackAssembliesIfSelfContained happened to be the place these were added, and wasn't being set since it has a condition of $(SelfContained) == 'true'

Now confusingly SelfContained WAS being set to true, but only in the targets file, which was too late, as it was checked in a 'global' property group outside of a target.

This means we'd fail to set SelfContained until after the condition, and not run.

This was verified by setting /p:SelfContained=true to true.

I also looked at removing the condition above, since https://github.com/dotnet/runtime/issues/54406 is fixed, however this caused project that didn't set RuntimeIdentifier to fail.
2021-09-20 09:40:41 -05:00
..
Microsoft.MacCatalyst.Sdk [dotnet] Update logic for default global namespaces and fix the templates. Fixes #12457. (#12471) 2021-08-19 07:47:03 +02:00
Microsoft.iOS.Sdk [dotnet] Update logic for default global namespaces and fix the templates. Fixes #12457. (#12471) 2021-08-19 07:47:03 +02:00
Microsoft.iOS.Windows.Sdk Import .NET 6 property page targets path in iOS sdk targets (#12556) 2021-08-27 12:17:06 +02:00
Microsoft.macOS.Sdk [dotnet] Update logic for default global namespaces and fix the templates. Fixes #12457. (#12471) 2021-08-19 07:47:03 +02:00
Microsoft.tvOS.Sdk [dotnet] Update logic for default global namespaces and fix the templates. Fixes #12457. (#12471) 2021-08-19 07:47:03 +02:00
Templates [dotnet] Support SupportedOSPlatformVersion. Fixes #12336. (#12638) 2021-09-08 09:20:05 +02:00
Workloads Generate msi files and VS setup authoring for all .NET 6 platforms (#12581) 2021-09-01 13:55:08 -04:00
package [dotnet] Remove watchOS code and from our .NET support. (#12764) 2021-09-20 07:40:03 +02:00
targets [net6][msbuild] Set SelfContained for AppExtensions sooner to fix publishing (#12703) 2021-09-20 09:40:41 -05:00
.gitignore [dotnet] use **FromWorkload** for targeting/runtime pack versions (#12449) 2021-08-19 09:03:11 +02:00
DefaultCompilationIncludes.md [dotnet] Remove watchOS code and from our .NET support. (#12764) 2021-09-20 07:40:03 +02:00
HIERARCHY.md [dotnet] Add support for 'dotnet publish'. Fixes #11807. (#12397) 2021-08-11 10:01:16 +02:00
Makefile Generate msi files and VS setup authoring for all .NET 6 platforms (#12581) 2021-09-01 13:55:08 -04:00
PackageInfo.plist Fix typos in comments. 2020-10-19 10:38:11 +02:00
SingleProject.md [dotnet] rename $(AppleShortVersion) to $(ApplicationDisplayVersion) (#12647) 2021-09-08 10:13:29 -04:00
VERSIONS.md Rename master to main. (#8851) 2020-06-16 15:51:44 +02:00
build-custom-runtime.sh [configure] Add option to use a locally built dotnet/runtime. (#11643) 2021-05-21 22:18:25 +02:00
generate-target-platforms.csharp Bump to .NET 5.0.100-rc.2.20459.1 (#9758) 2020-10-02 08:31:38 +02:00
generate-wix.csharp [dotnet] Package the workloads in a Windows installer (.msi) as well. (#9979) 2020-10-28 11:09:55 +01:00