The `machine` parameters were uninitialized (set to 0 as globals).  As a
result, the test failure messages were not emitted, making it harder to
understand what is failing.

Bug: angleproject:3408
Change-Id: Ib8351755af24e01736314d1832160edf10a8e767
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3920894
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
This commit is contained in:
Shahbaz Youssefi 2022-09-26 22:56:29 -04:00 коммит произвёл Angle LUCI CQ
Родитель 01285f16ab
Коммит dd0fc3356d
2 изменённых файлов: 12 добавлений и 2 удалений

Просмотреть файл

@ -761,6 +761,7 @@ if (build_angle_gles1_conform_tests) {
]
configs += [
":angle_gles1_conform_support",
"${angle_root}:libANGLE_config",
"${angle_root}:angle_backend_config",
]

Просмотреть файл

@ -109,6 +109,8 @@ void StateSetup(void);
#define CONFORMANCE_TEST_ERROR (-1)
#include "conform.h"
#ifdef __cplusplus
}
@ -120,8 +122,8 @@ class GLES1ConformanceTest : public ANGLETest<>
protected:
GLES1ConformanceTest()
{
setWindowWidth(48);
setWindowHeight(48);
setWindowWidth(WINDSIZEX);
setWindowHeight(WINDSIZEY);
setConfigRedBits(8);
setConfigGreenBits(8);
setConfigBlueBits(8);
@ -135,6 +137,13 @@ class GLES1ConformanceTest : public ANGLETest<>
BufferSetup();
EpsilonSetup();
StateSetup();
machine = {};
// Default parameters taken from shell.c. Verbosity is increased so test failures come with
// information.
machine.randSeed = 1;
machine.verboseLevel = 2;
machine.stateCheckFlag = GL_TRUE;
}
};