In preparation for a Chromium change that makes dchecks enabled
by default in Release builds, we'll keep ASSERT disabled in
Release by default. We add a new flag 'angle_assert_always_on'
for controlling ANGLE ASSERT behaviour.
Also slightly refactors the direct SPIR-V generation GN.
Chromium CL: https://crrev.com/c/2893204
Bug: chromium:1225701
Change-Id: I01a6def28d7c21e771e9800889a6b9c274972de2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3035447
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
ANGLE's VK backend induces a memory and binary size regression due to
global initializers in glslang/spirvtools. Disable it on Android Chrome
official builds.
Bug: chromium:1172451
Change-Id: I08d77cf11e20b393c0faf7c85d08c92061e5a09b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2969385
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
The GN arg angle_expose_non_conformant_extensions_and_versions is being
added to control exposeNonConformantExtensionsAndVersions, which enables
non-conformant features and extensions. In particular, this is being
done to enable EXT_texture_buffer on devices that don't support all of
the necessary formats since many Android games rely on this extension,
such as "Special Forces Group 2", "Fortnite", and "PUBG".
# Enables non-conformant extensions and features
angle_expose_non_conformant_extensions_and_versions = false
Users/vendors can now toggle the value with a GN arg, rather than a code
change, to make it easier to test the conformant version of ANGLE with
CTS, dEQP, etc. and/or app-compatibility.
Bug: angleproject:5592
Change-Id: Icbf18b48a2751c03e277ae964e1ec278a43324cf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2740643
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
The adb install command is being updated to include the following
options:
-r: replace existing application
-d: allow version code downgrade (debuggable packages only)
--force-queryable: mark the ANGLE APK as visible to all other packages
This will allow AngleLibraries.apk to install without errors and be
loadable for apps targeting SDK >= 30.
Bug: b/175800879
Change-Id: I61bb7218b407e54057adbfb5aa3098a96b903f5e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2602241
Reviewed-by: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
ANGLE cannot be enabled for all apps on Android unless the
device has root access.
Test: Inspect the resulting markdown doc
Bug: angleproject:4347
Bug: b/175324620
Change-Id: Idc37d6062a12240cf038ef13f7d53d769fa824a4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2585074
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Following up on feedback to minimize GN arg lists. The initial block
generates a Debug build with minimum variance from default args. The
additional blocks are for different scenarios, like getting maximum
performance, and verifying ANGLE runs cleanly with Vulkan in Release.
Bug: b/150368485
Bug: angleproject:4347
Change-Id: I4db6c389b9bdaf8124795a3aeeb79590245d1e70
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2216813
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
This CL creates a new page that is dedicated to building and using
ANGLE for Android.
With Android 10 released, now anyone can try out ANGLE as their GLES
driver for debuggable apps. It can also be loaded for any app if the
user has root access.
Also migrated existing Android build instructions with updates from
the team.
Bug: angleproject:4347
Change-Id: Iead6a456780aba033a1227605f197a456ad30eb3
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2063569
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Roman Lavrov
Jamie Madill
Ian Elliott
Matthias Lederhofer
Geoff Lang
Tim Van Patten
Peng Huang
Cody Northrop
Tobin Ehlis