Updates the configs to use the new protobuf properties. Adds
support for ARM/ARM64 Android builds.
Must be landed in conjunction with http://crrev.com/c/2841787 .
Bug: angleproject:2344
Bug: angleproject:5114
Change-Id: I49f4f46ceaa7ce9118c9f4b4ceb06353b00429b6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2842306
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
The current setup has problems producing tags in an ANGLE checkout.
Bug: angleproject:5114
Change-Id: I91864650ddb2a9df0ac533bf4c43259c476a99ef
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2822238
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
This is the first step in uploading histogram data instead of a gtest
special format. We importing several new libraries:
- tools/protoc_wrapper
- third_party/protobuf
- third_party/catapult (was already used for Android)
No functional change. Only affects compilation. Protobuf support is
disabled when not available.
Bug: angleproject:5161
Change-Id: I64be0977648993b1012ff0d9e0439c5876697e36
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2497221
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
This reverts commit 7a0263547c.
Reason for revert: Breaks roll of ANGLE into AOSP:
ERROR at //testing/test.gni:76:5: Assertion failed.
assert(_use_raw_android_executable || enable_java_templates)
^-----
See //third_party/catapult/tracing/tracing/BUILD.gn:35:1: whence it was called.
test("histogram_unittests") {
^----------------------------
See //src/tests/BUILD.gn:262:17: which caused the file to be included.
deps += [ "//third_party/catapult/tracing/tracing:histogram" ]
^-------------------------------------------------
Original change's description:
> Link C++ histogram support into angle_perftests.
>
> This is the first step in uploading histogram data instead of a gtest
> special format. We importing several new libraries:
>
> - tools/protoc_wrapper
> - third_party/protobuf
> - third_party/catapult (was already used for Android)
>
> No functional change. Only affects compilation. Protobuf support is
> disabled when not available.
>
> Bug: angleproject:5161
> Change-Id: Ie28d57d7e142c437ebd51463ce3e2cafd87468d1
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2482294
> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
TBR=ynovikov@chromium.org,bsheedy@chromium.org,jmadill@chromium.org
Change-Id: I62c4b926cbe82d10e460b28b5f864521e2b1f8ee
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: angleproject:5161
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2495549
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Tim Van Patten <timvp@google.com>
This is the first step in uploading histogram data instead of a gtest
special format. We importing several new libraries:
- tools/protoc_wrapper
- third_party/protobuf
- third_party/catapult (was already used for Android)
No functional change. Only affects compilation. Protobuf support is
disabled when not available.
Bug: angleproject:5161
Change-Id: Ie28d57d7e142c437ebd51463ce3e2cafd87468d1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2482294
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Update the .gn to remove forcing use_custom_libcxx = false. Instead, let
//build/config/c++/c++.gni determine the value, which should better
match Chromium.
In particular, this helps with Abseil integration by supporting Windows
component builds by better matching the contents of the .def files.
Bug: angleproject:4873
Test: CQ
Change-Id: If8c064f16459292bfb95113a4d78e14e8923f86f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2414739
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Tim Van Patten <timvp@google.com>
This fixes a few style warnings:
* auto should not deduce to raw pointer type
* inlined virtual methods are not allowed
* non-trivial constructors and destructors should be explicit
* inlined non-trivial constructors should not be in-class
* missing override keywords
Bug: angleproject:3069
Change-Id: I3b3e55683691da3ebf6da06a5d3c729c71b6ee53
Reviewed-on: https://chromium-review.googlesource.com/c/1407640
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Updates angle_util to see the loader includes even if the loader is not
enabled. This makes the GN check happy.
Bug: angleproject:3052
Change-Id: Ifd23070385beefede4358c7b4c1823dc87b5ded8
Reviewed-on: https://chromium-review.googlesource.com/c/1395809
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Remove the gyp build. The .gypi files were not renamed so that diff and
rebase would work on this change. They will be renamed in a separate
change.
BUG=angleproject:1569
Change-Id: If8a217027633293664b820104f91a4ca5889b24e
Reviewed-on: https://chromium-review.googlesource.com/1187380
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
For builds set "use_sysroot = true" by default
This is intended to fix a bot config that is hitting a build error with
latest Vulkan validation layer roll.
Bug: angleproject:2560
Change-Id: I06edfc7b74f367bbab23fea6f01b2778b12a470a
Reviewed-on: https://chromium-review.googlesource.com/1068031
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
This file will be imported into both ANGLE's and Chrome's .gn files so
we can share some of the same settings. This will mean we no longer
have to patch Chromium to make changes to the exec script whitelist.
Bug: angleproject:2339
Change-Id: I2d7dd4237488ffecf5376643447ad95a0c1dbf98
Reviewed-on: https://chromium-review.googlesource.com/902324
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
This should do the same things as the stand-alone gyp build, but with gn.
You should switch to gn as gyp support will go away.
You need a recent enough version of gn. If yours is too old try this one:
./buildtools/linux64/gn
If "gclient sync" or anything fails with an ImportError on gyp stuff,
try running it with the following PYTHONPATH in the environment:
PYTHONPATH=tools/gyp/pylib
BUG=angleproject:1569
Change-Id: I56d19bec2d8b649a7bd65062c656cbfc69ea3dd8
Reviewed-on: https://chromium-review.googlesource.com/642588
Reviewed-by: Frank Henigman <fjhenigman@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Frank Henigman <fjhenigman@chromium.org>
angle-autoroll
Jamie Madill
Tim Van Patten
Trevor David Black
Nico Weber
Geoff Lang
Frank Henigman
Tobin Ehlis