a33dc9ce8b
Roll third_party/vulkan-loader/src c731adec183b..0bd30e43c007 (1 commits)
...
c731adec18..0bd30e43c0shannon@lunarg.com build: Update known-good for 1.2.133 header
Created with:
gclient setdep -r third_party/vulkan-loader/src@0bd30e43c007
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-loader-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I3ba81af4748d41f690b79b229245909e9b13add5
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2061123
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-18 08:09:44 +00:00
7efa03ac94
Roll third_party/SwiftShader 481daed34f15..0bbf7ba9f909 (5 commits)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/481daed34f15..0bbf7ba9f909
git log 481daed34f15..0bbf7ba9f909 --date=short --first-parent --format='%ad %ae %s'
2020-02-17 amaiorano@google.com Cache callstack results to avoid expensive lookup
2020-02-17 amaiorano@google.com Subzero: add REACTOR_EMIT_PRINT_LOCATION support
2020-02-17 bclayton@google.com third_party: Add shell script that updates marl.
2020-02-17 amaiorano@google.com Implement rr::Print support for Subzero
2020-02-17 amaiorano@google.com Subzero: fix another load from constant data
Created with:
gclient setdep -r third_party/SwiftShader@0bbf7ba9f9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I52277a2305d73e84211ad9b48a12b8275aa221b0
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2061126
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-18 08:08:24 +00:00
9fcbd7e3cd
Roll third_party/glslang/src ae59435606fc..113d07a6ebda (1 commits)
...
ae59435606..113d07a6ebhttps://autoroll.skia.org/r/glslang-angle-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: cwallez@google.com
Change-Id: I62752cf29e88146c2df52f371ba7bb2e109ff235
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2061125
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-18 07:59:54 +00:00
2e0661d7dd
Vulkan: Update ES 3.1 test expectations
...
Split off shader compilation failure to a new bug.
Bug: angleproject:3596
Bug: angleproject:4402
Change-Id: Iac054e469440cfa2b84289e08c5b21e3fbdf5410
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2061448
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
2020-02-18 04:15:14 +00:00
c8676d4ba3
Unlimit texture size on relatively new linux
...
If limit texture size to a small number, application may
need to reshape texture, lead to more discontinuous
memory access and performance loss.
Bug: angleproject:4086
Change-Id: I502a90535c2e3d13738e23827f4712a77987585e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1934048
Reviewed-by: Xinghua Cao <xinghua.cao@intel.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Xinghua Cao <xinghua.cao@intel.com>
2020-02-18 03:45:55 +00:00
015cb80815
Revert "Use newer OSX SDK for iOS"
...
This reverts commit 192da9d76fhttp://crrev.com/c/2056465
>
> Bug: chromium:1052887
> Change-Id: I2f76067883ff528ca45becd90dd3a6f71a507494
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2059669
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
TBR=thakis@chromium.org ,ynovikov@chromium.org,jmadill@chromium.org
Change-Id: I8698ed56fc81a76900da2aaf6cd19d08b57c5525
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1052887
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2061228
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
2020-02-18 00:25:05 +00:00
192da9d76f
Use newer OSX SDK for iOS
...
Based on http://crrev.com/c/2056465
Bug: chromium:1052887
Change-Id: I2f76067883ff528ca45becd90dd3a6f71a507494
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2059669
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
2020-02-17 22:44:54 +00:00
ee89849b7c
Metal: Fixed memory leak due to the CAMetalLayer still attached to super layer
...
When destroying SurfaceMtl, the CAMetalLayer should detach from its
super layer, otherwise memory leak could happen.
This memory leak caused the end2end tests to ran out of memory.
Bug: angleproject:2634
Change-Id: I8ea91cccdb42cf0ae8ef807cf01f1e05043dc7c1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2060250
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
2020-02-17 22:27:33 +00:00
5f5292c86e
Only enable robust client memory if the context supports validation.
...
Bug: chromium:1028418
Change-Id: Id47ac64a3d56b58455e1f36d8a17dbdc9db7e509
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2056506
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
2020-02-17 20:27:43 +00:00
59126651bc
Revert "Provide default implementation of rx::DisplayEGL"
...
This reverts commit e82ab75a4chttps://chromium-review.googlesource.com/c/angle/angle/+/2031699
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Jamie Madill <jmadill@chromium.org>
TBR=geofflang@chromium.org ,syoussefi@chromium.org,jonahr@google.com,jmadill@chromium.org,julien.isorce@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: angleproject:4328
Change-Id: I62436cad1e6aae0c5e072acb1dab0bd10b2cf722
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2058952
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
2020-02-17 10:42:02 +00:00
6b43fba9fe
Roll third_party/spirv-tools/src 6c218ec60b5f..77fefe765c06 (1 commits)
...
6c218ec60b..77fefe765chttps://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: Ibf658094111733ca1a8fa50b865c30d903d51721
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2059856
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-17 08:11:37 +00:00
18bfdb7ffa
Roll third_party/vulkan-validation-layers/src 73d377fae66e..211ee9c4eec1 (3 commits)
...
73d377fae6..211ee9c4ees.fricke@samsung.com tests: Add test for vkCmdCopyImage VUID
2020-02-14 s.fricke@samsung.com layers: Add support for vkCmdCopyImage VUID
2020-02-14 mark@lunarg.com corechecks: Correct conditions for triggering VUID 1564
Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@211ee9c4eec1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: I730510f9bf8891032075e9ec964d4e04b918e6fd
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2059855
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-17 08:09:37 +00:00
674d0ec2e4
Roll third_party/vulkan-headers/src 726435870206..9bd3f561bcee (1 commits)
...
7264358702..9bd3f561bcoddhack@sonic.net Update for Vulkan-Docs 1.2.133
Created with:
gclient setdep -r third_party/vulkan-headers/src@9bd3f561bcee
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-headers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
TBR=courtneygo@google.com
Bug: None
Change-Id: I7676db5d51844e2633fa3aa6e660444edaca971a
Tbr: courtneygo@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2058775
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-17 08:06:37 +00:00
c7df822fa8
Roll third_party/SwiftShader f9f999f5a2eb..481daed34f15 (2 commits)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/f9f999f5a2eb..481daed34f15
git log f9f999f5a2eb..481daed34f15 --date=short --first-parent --format='%ad %ae %s'
2020-02-15 swiftshader.regress@gmail.com Regres: Update test lists @ 348f07b4
2020-02-14 amaiorano@google.com Fix unit test when ENABLE_RR_EMIT_PRINT_LOCATION is defined
Created with:
gclient setdep -r third_party/SwiftShader@481daed34f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: I7021723c43885bdfeccb96e63b8ad988a740407b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2059857
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-17 07:56:27 +00:00
2dd40d7fa7
Vulkan: Free pool allocation leak with graph disabled.
...
Our secondary command buffer pools were leaking memory every submit.
This change pops the secondary command buffer pool allocator scope
after commands are flushed during a submit.
Fixes the memory leak observable on any Vulkan application.
Bug: angleproject:4029
Bug: angleproject:4403
Change-Id: I3d0f8d53456336ef0b03c6d37425fb76c88d1551
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057349
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
2020-02-15 14:00:45 +00:00
798a837599
Vulkan: Add more debug labels handling with graph off.
...
Bug: angleproject:4029
Change-Id: Ia3c88af5f9fa1a7940d7f809ded599c064126be7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2055555
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
2020-02-15 02:27:49 +00:00
12a36dd9ea
Vulkan: Add debug utils functions to wrapper.
...
Also adds a more consistent way of checking if the debug utils
extension is enabled.
Enables adding support for the debug utils markers with the command
graph disabled.
Bug: angleproject:4029
Change-Id: I5f8762921b06f54e400c25764012ab70e10bfb8d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2055554
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
2020-02-15 00:37:29 +00:00
bb7534ee99
Use ASSERT() instead of assert() when possible.
...
Since ASSERT() works in Release builds.
Left assert() in a few places where calling a function may not be safe.
Bug: angleproject:4396
Change-Id: Ic75a3d41d846e327097f8c37fe2336dcd3be6cb8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057745
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
2020-02-14 22:58:19 +00:00
9f4ab98d12
Return angle::Result from more label functions.
...
This is necessary for the new Vulkan implementation.
Bug: angleproject:4029
Change-Id: I07ef54145252ff102c74179361436587bb330fc7
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2055553
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
2020-02-14 14:51:49 +00:00
3a3e7d4dd2
Don't skip functional.layout_binding.ubo.vertex_binding_max on NV/D3D11
...
This test no longer fails with any recent drivers.
Bug: angleproject:4276
Change-Id: I7a20ee66f1da82d0f378848ccc9faa327a4ed63a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2057065
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
2020-02-14 13:30:29 +00:00
eaff904e72
Roll third_party/vulkan-tools/src db0a1553991d..fb2272297f00 (2 commits)
...
db0a155399..fb2272297fcharles@lunarg.com vulkaninfo: support ASTC HDR formats
2020-02-13 charles@lunarg.com vulkaninfo: Update VkFormat ranges
Created with:
gclient setdep -r third_party/vulkan-tools/src@fb2272297f00
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: I01999deef8a186abbb83a717364235f766534568
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2056306
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-14 08:12:03 +00:00
2646163d89
Roll third_party/SwiftShader ac4e1d236088..f9f999f5a2eb (6 commits)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/ac4e1d236088..f9f999f5a2eb
git log ac4e1d236088..f9f999f5a2eb --date=short --first-parent --format='%ad %ae %s'
2020-02-13 jonahr@google.com Implement HostMappedForeignMemory DeviceMemory
2020-02-13 bclayton@google.com Update Marl to a047dd0bb
2020-02-13 bclayton@google.com third_party/marl: Add mips64 support to BUILD.gn
2020-02-13 swiftshader.regress@gmail.com Regres: Update test lists @ ac4e1d23
2020-02-13 amaiorano@google.com Kokoro: build and run rr::Print unit tests
2020-02-13 amaiorano@google.com Fix rr::Print and add unit tests
Created with:
gclient setdep -r third_party/SwiftShader@f9f999f5a2
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: Id1422ca8e34f6eaf013b47416a35bb7cefd67745
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2056308
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-14 08:03:33 +00:00
2e9b53763f
Roll third_party/vulkan-validation-layers/src 30794ac2f91b..73d377fae66e (2 commits)
...
30794ac2f9..73d377fae6tony@lunarg.com layers: Fix false errors if query condition is unknown
2020-02-13 mark@lunarg.com layers: Fix string validation returned results
Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@73d377fae66e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: Ic6f674dfe8c209ac38a69d76728741574d53de1b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2056307
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-14 07:59:13 +00:00
d5861a68d9
Fix ASAN errors in end2end tests.
...
2 minor issues of reading from uninitialized memory in tests.
Removes the suppressions from the fixed tests.
Bug: chromium:1029378
Change-Id: I466ce231cfed1ce53a60732706c05b778b096805
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2055649
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
2020-02-13 23:52:08 +00:00
4f9608ca6a
Vulkan: Update more bug numbers for ES 3.1
...
This reflects the most recent conformance run on Android with SwiftShader.
Bug: angleproject:4106
Bug: angleproject:4108
Bug: angleproject:4188
Bug: angleproject:4190
Bug: angleproject:4240
Bug: angleproject:4300
Bug: angleproject:4312
Change-Id: I0107262eecc963a8d5343a53806bb0483b5af3be
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2054068
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
2020-02-13 21:34:07 +00:00
ef599fb0f4
Vulkan: Fold glClear into draw call when command graph is disabled
...
This sets ContextVk::mRenderPassCommandBuffer properly when glClear get
called so that it wonr end up start anotyer render pass during setupDraw
call.
Bug: angleproject:4395
Change-Id: Id2110719ad4d70b4c410062466d32381fb5e1f88
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050966
Commit-Queue: Charlie Lao <cclao@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
2020-02-13 19:08:57 +00:00
94c191427a
Capture/Replay: Track and restore mapped buffer data
...
When a buffer is mapped writable by the host, we need to
track its final contents, and then restore them during replay.
This implementation just blindly captures the whole mapped
range if writable, and can be optimized in the future.
This change renders the moving billboards in Manhattan correctly.
Test: First 500 frames of Manhattan and TRex
Bug: angleproject:4091
Change-Id: I5f7775235f569efb264bde679fd3045d7012c622
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2053512
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
2020-02-13 18:46:27 +00:00
b79b57e047
Vulkan: expose ANGLE_compressed_texture_etc
...
Bug: angleproject:4399
Change-Id: I51cd304c8726c985c5f70b78bd98c8af19d2a80d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2053889
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
2020-02-13 17:50:57 +00:00
e82ab75a4c
Provide default implementation of rx::DisplayEGL
...
Will allow to use EGL instead of GLX on X11.
Meant to be used on modern EGL so it requires the extensions
EGL_KHR_no_config_context and EGL_KHR_surfaceless_context.
This keeps the default implementation simple (no pBuffer
fallback)
Also provide simple WorkerContextEGL.
Bug: angleproject:4328
Change-Id: I825c6998e4a3727a13e533ede3d9fb1820edc804
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2031699
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
2020-02-13 14:28:07 +00:00
77a5100d9a
Roll third_party/vulkan-tools/src 45b9d01815d9..db0a1553991d (1 commits)
...
45b9d01815..db0a155399charles@lunarg.com vulkaninfo: new vkconfig_output backdend
Created with:
gclient setdep -r third_party/vulkan-tools/src@db0a1553991d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: I0e52a00d48b755401d759170be99689d682e7c3d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2053853
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-13 08:19:25 +00:00
1f12c947ab
Roll third_party/vulkan-validation-layers/src d439b17da022..30794ac2f91b (12 commits)
...
d439b17da0..30794ac2f9mikes@lunarg.com scripts: Rename src argument for safe_* copy funcs
2020-02-12 mikes@lunarg.com scripts: Only use safe_* types when needed
2020-02-12 mikes@lunarg.com scripts: Handle arrays with const/non-member len
2020-02-12 shannon@lunarg.com scripts: Fix codegen infinite recursion
2020-02-12 s.fricke@samsung.com tests: Add test for 01004 and 02652
2020-02-12 s.fricke@samsung.com layers: Add support for 01004 and 02652
2020-02-12 mark@lunarg.com tests: Remove non-API range enums
2020-02-12 mark@lunarg.com layers: Remove non-API range enums
2020-02-12 mark@lunarg.com layers: Remove deprecated log_msg() function
2020-02-12 mark@lunarg.com layers: Removed last log_msg calls
2020-02-12 s.fricke@samsung.com tests: Added test for 00624 and 00625
2020-02-12 s.fricke@samsung.com stateless: Added support for 00624 and 00625
Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@30794ac2f91b
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: Ibe4ff7d019861e0e6db0aae06637b79dc04d8e49
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2053852
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-13 08:04:26 +00:00
d4be305efb
Roll third_party/SwiftShader 6cbb02e0dc93..ac4e1d236088 (2 commits)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/6cbb02e0dc93..ac4e1d236088
git log 6cbb02e0dc93..ac4e1d236088 --date=short --first-parent --format='%ad %ae %s'
2020-02-12 gmouse@google.com Add missed symbol __aeabi_idivmod for Android.
2020-02-12 swiftshader.regress@gmail.com Regres: Update test lists @ 6cbb02e0
Created with:
gclient setdep -r third_party/SwiftShader@ac4e1d2360
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: I3f0ef9910eafd7b340aa11c9a4cd0fd1a0849142
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2053854
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-13 08:00:06 +00:00
74ab0bffb5
Vulkan: Disable command graph by default.
...
Also removes the angle_end2end_tests feature override.
Bug: angleproject:4029
Change-Id: I0d0bd087fc2143360185592d9fa1238a9bafc55d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2046054
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
2020-02-12 23:31:18 +00:00
9e4cf7cab1
Fix vpython caching in trigger.py script.
...
Several necessary CPID packages were missing from the swarming params.
Add these based on the packages in mb.py:
2192df66cd/mb.py (586)https://chromium-review.googlesource.com/c/angle/angle/+/2050427
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
2020-02-12 22:43:08 +00:00
593706bcc0
Test Runner: Increase default timeouts.
...
In particular the Debug timeout was not generous enough. Increase the
test timeout to 20 seconds in Release and 60 seconds in Debug. Increase
the batch timeout to 240 seconds in Release and 600 seconds in Debug.
Bug: angleproject:3162
Change-Id: I0bd0ea18cb5cdab005143b8deed9500d9d2e8ea1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2047415
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
2020-02-12 21:01:48 +00:00
caf7becc1f
Move dither from blend state to rasterizer state
...
Dither is technically not a part of blend state so it was removed from there as a first step towards exposing OES_draw_buffers_indexed (that defines independent blend state for each draw buffer).
Rasterizer state seems to be the closest (although also not accurate) place for it to keep code changes to a minimum. ANGLE's D3D11, Vulkan, and Metal renderers ignore dithering altogether.
Bug: angleproject:4394
Change-Id: Ib138624b9218851d18cd63e2033e8e8ac8ca71d9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050464
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
2020-02-12 18:27:48 +00:00
92b00ca882
Roll deqp to get some test fixes
...
Bug: angleproject:4107
Change-Id: Icfb6b3fc075b9febf486386c26d90b4020ace9ee
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2047388
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Commit-Queue: Courtney Goeltzenleuchter <courtneygo@google.com>
2020-02-12 14:23:37 +00:00
bd2f257589
Update comment to reflect changes in ea0dcd4bda
...
Bug: angleproject:4087
Change-Id: I3c26fae4fde24308fa877256c190a5bb47fe1a82
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1954568
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
2020-02-12 14:00:57 +00:00
33b1e31e7e
Fix compressed formats validation with TEXTURE_3D
...
Bug: angleproject:4385
Change-Id: Ibc1b482ec851d8076aacad84ab67fe20a745c122
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2045512
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
2020-02-12 13:55:58 +00:00
cf03c7ae84
Roll third_party/spirv-tools/src fe10239f92f4..6c218ec60b5f (3 commits)
...
fe10239f92..6c218ec60bhttps://autoroll.skia.org/r/spirv-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: I181af12ac2a95d8619b581c8734f38ab63e09273
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050005
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-12 10:48:57 +00:00
7adc973624
Roll third_party/vulkan-validation-layers/src b60b35843e66..d439b17da022 (38 commits)
...
b60b35843e..d439b17da0s.fricke@samsung.com tests: Add test for 00360
2020-02-12 s.fricke@samsung.com layers: Add support for 00360
2020-02-12 s.fricke@samsung.com tests: Add tests for 01973 and 01069
2020-02-12 s.fricke@samsung.com layers: Add support for 01973 and 01069
2020-02-11 mark@lunarg.com layers: Update stateless validation doc
2020-02-11 mark@lunarg.com corechecks: Convert core val to use new logging funcs
2020-02-11 mark@lunarg.com corechecks: Converted buffer validation to new logging funcs
2020-02-11 mark@lunarg.com corechecks: Use new logging calls in shader validation
2020-02-11 mark@lunarg.com corechecks: Move helpers inside validation object
2020-02-11 mark@lunarg.com threading: Change log_msg calls to LogError calls
2020-02-11 mark@lunarg.com theading: Pass object pointer instead of report_data
2020-02-11 mark@lunarg.com corechecks: Move misplaced validation call into core validation
2020-02-11 mark@lunarg.com chassis: Changed log_msg calls to LogWarning calls
2020-02-11 mark@lunarg.com corechecks: Convert drawdispatch.cpp to new logging funcs
2020-02-11 mark@lunarg.com gpuval: Moved to new-style logging functions
2020-02-11 mark@lunarg.com corechecks: Converted descriptor_sets.cpp to new logging calls
2020-02-11 mark@lunarg.com practices: Convert WARNINGS to new logging calls
2020-02-11 mark@lunarg.com practices: Convert perf warnings to new logging funcs
2020-02-11 mark@lunarg.com practices: Change info message to warning
2020-02-11 mark@lunarg.com objlifetimes: Convert object tracker to new logging calls
2020-02-11 mark@lunarg.com stateless: Convert parameter validation to new logging calls
2020-02-11 mark@lunarg.com tests: Fix pipeline create state test
2020-02-11 s.fricke@samsung.com tests: Added test for 00701
2020-02-11 s.fricke@samsung.com layers: Added support for 00701
2020-02-11 s.fricke@samsung.com layers: Added condition to display 01427
2020-02-11 s.fricke@samsung.com layers: Added condition to display 01430
2020-02-11 s.fricke@samsung.com tests: Added test for 01988
2020-02-11 s.fricke@samsung.com layers: Added support for 01988
2020-02-11 s.fricke@samsung.com tests: Added test for 01143
2020-02-11 s.fricke@samsung.com layers: Added support for 01143
2020-02-11 s.fricke@samsung.com tests: Added test for 00317 and 00318
2020-02-11 s.fricke@samsung.com layers: Added support for 00317 and 00318
2020-02-11 raul.tambre@cleveron.com layers: Don't issue VU01564 for immutable samplers
2020-02-10 jeremy@lunarg.com tests: Test unaligned CmdPushDescriptorSet
2020-02-10 jeremy@lunarg.com layers: Validate unaligned CmdPushDescriptorSet
2020-02-10 jzulauf@lunarg.com tests: Add layout for middle subresource test
2020-02-10 jzulauf@lunarg.com layers: Fix range_vector excess erasure
2020-02-10 jeremy@lunarg.com layers: Fix unitialized variable.
Created with:
gclient setdep -r third_party/vulkan-validation-layers/src@d439b17da022
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-validation-layers-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: I8275b4fab12c0b5124af7583c0ce1e5c0a318594
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050004
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-12 08:45:47 +00:00
58e7790cc0
Roll third_party/SwiftShader b3b2a4fc756f..6cbb02e0dc93 (11 commits)
...
https://swiftshader.googlesource.com/SwiftShader.git/+log/b3b2a4fc756f..6cbb02e0dc93
git log b3b2a4fc756f..6cbb02e0dc93 --date=short --first-parent --format='%ad %ae %s'
2020-02-11 bclayton@google.com CMakeLists: Drop the explicit include path to marl
2020-02-11 bclayton@google.com Bulk clang format
2020-02-11 bclayton@google.com Change SpirvShaderInstructions.inc extension to .inl
2020-02-11 bclayton@google.com Merge changes Ide16cac3,Id5d767fc
2020-02-11 jiaxun.yang@flygoat.com Fix MIPS build cflags
2020-02-11 bclayton@google.com Don't use std::initializer_list for array views.
2020-02-11 sugoi@google.com Support for VK_KHR_separate_depth_stencil_layouts
2020-02-11 sugoi@google.com Support for VK_KHR_create_renderpass2
2020-02-11 bclayton@google.com Revert "Add missed symbol __aeabi_idivmod for Android."
2020-02-11 gmouse@google.com Add missed symbol __aeabi_idivmod for Android.
2020-02-10 bclayton@google.com Debug: Rename levels.
Created with:
gclient setdep -r third_party/SwiftShader@6cbb02e0dc
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: Ie73f8091b61e7a08e6fa11aac7801d3b7f50080c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2049960
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-12 08:44:47 +00:00
e1ccac7ff9
Don't print INFO level log messages in Release by default.
...
Even with dcheck_always_on.
INFO level log messages will still be printed in Debug
or when angle_enable_trace is enabled.
Bug: angleproject:3525
Change-Id: Ic3807f94307af2878aee78426c969ab846ae3881
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050890
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
2020-02-12 00:42:34 +00:00
3b82506abc
Vulkan: Command graph linearization (Step 5).
...
Implements ES 3.1 support.
Bug: angleproject:4029
Change-Id: I3c08602cf4ec64621bfdb40cd40d142b666e6edf
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2046052
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
2020-02-11 22:20:54 +00:00
72e9f4d73f
Vulkan: Update bug number in KHR ES 3.1 expectations
...
It was pointing to general ES 3.1 bug.
Bug: angleproject:4107
Change-Id: Ief726c57d5a853d633df705eb30e8cdad3f6c9ca
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050030
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Cody Northrop <cnorthrop@google.com>
2020-02-11 20:56:24 +00:00
8c0b488969
Roll third_party/vulkan-tools/src 428455ca6121..45b9d01815d9 (2 commits)
...
428455ca61..45b9d01815charles@lunarg.com vulkaninfo: Check for surface extensions
2020-02-10 petr_kraus@email.cz build: Fix android update not understanding headers version
Created with:
gclient setdep -r third_party/vulkan-tools/src@45b9d01815d9
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/vulkan-tools-angle-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Bug: None
Tbr: courtneygo@google.com
Change-Id: I709bbc83ddf30dd93235b8bc731859265c8a13f1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2049668
Reviewed-by: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: angle-autoroll <angle-autoroll@skia-public.iam.gserviceaccount.com>
2020-02-11 20:21:24 +00:00
1a8b7758e2
Fix assignment of CacheOpResult::EnumCount
...
The special enum value 'EnumCount' is used by EnumSize() to determine
how large to make the PackedEnumMap::mPrivateData array. However, that
enum entry was being assigned an incorrect value, leading to the array
being constructed too small and causing a crash in PackedEnumMap's
std::initializer_list constructor when it went beyond the size of the
array to assign each of the necessary values.
The fix is to remove the assignment of CacheOpResult::EnumCount and let
it indicate the real number of entries in the enum.
Bug: angleproject:4393
Test: end2end
Change-Id: If9635c61e72aadc6527d416f83be18add8b24572
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2050026
Reviewed-by: Courtney Goeltzenleuchter <courtneygo@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
2020-02-11 19:41:54 +00:00
b40d48a67c
Vulkan: Remove ensure init from updateActiveImages.
...
The ensure should already be triggered from the front-end.
Bug: angleproject:3539
Bug: angleproject:3887
Change-Id: Ic7ee10f9c767440e55befb929b414c0c894754c9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2046051
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
2020-02-10 23:02:58 +00:00
cd8167fb49
Vulkan: Fix EGLBlobCacheTest.
...
Several runs of the same test in a row would cause a failure if the
cache would get hit. Fix the flakiness by resetting the cache between
runs.
Also cleans up some of the variable naming and adds a stream output
for pretty test errors.
Fixed while working on the standalone test harness.
Bug: angleproject:3162
Change-Id: I64da8a37eedf562860e3e5409cbf6fb08e81dfa4
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2047417
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
2020-02-10 21:42:58 +00:00
3c066404f3
Vulkan: Command graph linearization (Step 4).
...
Implements GLES 3.0 functionality for the new command recording style.
Tested with angle_end2end_tests. dEQP/CTS testing will come later.
Bug: angleproject:4029
Change-Id: Ibdc4f1355a7b880946699ec227fd9807f4a27af9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2040197
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
2020-02-10 21:34:09 +00:00
angle-autoroll
Cody Northrop
Xinghua Cao
Jamie Madill
Le Hoang Quyen
Khushal
Corentin Wallez
Yuly Novikov
Anders Leino
Charlie Lao
Alexey Knyazev
Julien Isorce
Courtney Goeltzenleuchter
Antonio Maiorano
Tim Van Patten