dEQP fails compile on MSVC Due to build switching to C++17.
Temporarily stop building them while VK-GL-CTS is being fixed upstream.
Bug: angleproject:6737
Change-Id: I288aab95cb76104fde7635eafb37d56b4ed0a600
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3308820
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
This should prevent a common class of unexpected CQ breakage.
Bug: angleproject:6670
Change-Id: Ic5706caedcb2ca326ec87883d695574e5450083c
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3304555
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
In anticipation of GLES1 ubershader updates that result
in faster frame times, but more compiles.
The GLES1 conformance tests iterate through every state and
render one frame, which is slower when you link a new program
for each.
Bug: angleproject:6644
Change-Id: I70501ea38505428569ba518710ecb03ce198db18
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3292511
Commit-Queue: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Lingfeng Yang <lfy@google.com>
These tests are heavily flaking and causing CQ churn. Mark them
as retriable until we can root cause the flakiness.
Bug: angleproject:6570
Change-Id: I9886a655b88737acbe7ce728fa32573ac4d6145f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3289104
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
It defines who is allowed to call LUCI Config validation API to
validate this LUCI project's configs. This is usually done by
presubmit jobs, and thus configs.validator role is assigned to
try job task accounts.
Previously this ACL was defined in the global "config-validation"
group. It is deprecated and being replaced with per-project ACLs
defined in per-project configs (like in this CL).
There's still a global ACL to allow any googler to call
the validation API in any LUCI project they are allowed to see.
Thus the per-project binding applies only to service accounts
(they are not googlers).
Note that this CL was generated semi-automatically and reviewers are
picked automatically based on OWNERS file.
Bug: chromium:1068817
Change-Id: Iadd19a74e3b0bce330ee0d6fd29046ab03d5c2cb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276460
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
These are compile-only with this CL, and will start running tests
in later CLs.
Bug: angleproject:5795
Change-Id: I37b04df2bb4a97aa46545f50bf978dfde65983c1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3258002
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
These are all now replaced with 'main'.
Bug: angleproject:6685
Change-Id: I36cb17625c44d06689f7debf004abd3dd016265b
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3276517
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
ASAN is not supported in 32-bits on Windows.
Bug: angleproject:5795
Change-Id: Icabf31b8c9ad4d371217c9f4a288f909888eae61
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3265532
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
This will allow us to manually add ASAN tryjobs to test before
landing.
Bug: angleproject:5795
Change-Id: I1085b64f2dcf09e20f470aded0d57befbe4fb084
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3257025
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
The ASAN builders will start by running compile-only and only in CI.
A follow-up change will enable sharded tests and CQ jobs.
Bug: angleproject:5795
Change-Id: I2e761b7bdd2d7215db2210c4538b6cafc4d9069a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3254430
Reviewed-by: Jamie Madill <jmadill@chromium.org>
This will provide an easier-to-read summary for wranglers because
test failures will be grouped instead of spread out in between
compile builders.
Bug: angleproject:6496
Change-Id: I45e2f1a868d887de22133684aa0b4821ed4c8f84
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3233900
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
This can be landed after the change to switch the CQ to the new
configs.
Bug: angleproject:6496
Change-Id: I3b6ec4697a2fa7a279e5a761ea1717f652af84a1
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3231835
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
These configs are now included in win-tests and linux-tests.
Bug: angleproject:6496
Change-Id: I1ab3961e74bde6672617e4494027da1ff490b352
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226302
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
This leaves the old configs in place. We can't remove them
until the CQ bots switch over.
Bug: angleproject:6496
Change-Id: Id9ee70cfd65cd85a7525b42f08d78873f31a7cd8
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3226301
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Old names: use config pairs when they can vary, e.g.
android-arm-dbg
android-arm64-rel
linux-clang-dbg
win-clang-x64-rel
win-msvc-x86-dbg
win-trace-rel
New names: use config names when they differ from the the
default test config for a system, and suffix with -compile
and -test for compile-only and compile-and-test bots. For
Android configs, we keep the full target arch. e.g.
android-arm-dbg-compile
android-arm64-test
linux-dbg-compile
win-test
win-msvc-x86-dbg-compile
win-trace
The new naming scheme prioritizes having short names to
avoid redundant or implicitly understood information. This
should reduce the mental load when looking at a set of test
results.
This also adds SwiftShader win10-x64 configs so we can add
these to the CI easily. Also the plan is to turn off the GCC
configs for now. If we ever support GCC properly we can re-
enable them.
This CL adds the new configs to CI, then a following CL will
add them to CQ and remove the old configs at the same time.
Bug: angleproject:6496
Change-Id: I0ecdcd392c4d7067d6b180664f160ba7c048d16d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3219590
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
The SPIR-V gen path is now made default. Compilation through glslang is
still supported for debugging, and is enabled on the GLSL* end2end tests
for smoke testing. On release builds, glslang is not supported.
To test with glslang, add the following gn arg (only necessary if dcheck
is disabled):
angle_enable_spirv_gen_through_glslang = true
Then enable the generateSPIRVThroughGlslang feature. This can be done
by setting an environment variable:
ANGLE_FEATURE_OVERRIDES_ENABLED=generateSPIRVThroughGlslang ./angle_deqp_gles2_tests
Binary size saving:
- 1.3MB on Linux (SPIR-V gen itself: 240KB)
- 730KB on Android (SPIR-V gen itself: 140KB)
Perf tests:
- LinkProgramBenchmark.Run/vulkan_compile_single_thread
* Through glslang:
truncated mean: 1287033.36
* Direct SPIR-V Gen:
truncated mean: 244495.91 (~80% reduction)
- LinkProgramBenchmark.Run/vulkan_compile_multi_thread
* Through glslang:
truncated mean: 4565894.83
* Direct SPIR-V Gen:
truncated mean: 1158164.10 (~75% reduction)
Bug: angleproject:4889
Bug: angleproject:6210
Change-Id: I486342702977c8114e90073b97183aba115a8b2d
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3115140
Commit-Queue: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
The dEQP GLES / EGL tests on the Nexus 5x are not a configuration we
intend to ship. The 5x is over 5 years old and has been discontinued
without updates. Because it costs us resources and developer time to
maintain these configs, and we still have WebGL testing of this
device, remove the native dEQP tests from this config.
Also includes a fix to the lucicfg presubmit on Windows.
Bug: angleproject:6527
Change-Id: I70bbd3ebdafc63bfd7572b79abcedb711acb4441
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3212892
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
This is in preparation for removing these tests from the N5X.
Bug: angleproject:6527
Change-Id: Ib44f876db47845935efd68a1727964834a675cbb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3208746
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
These will be used to replace SwANGLE tests on the CQ.
Bug: angleproject:6496
Change-Id: Id8d021067ec05e226daac5c1d5992977ef295efb
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3199993
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
These will show up as glinfo.json in the "cas outputs" of the shard
that runs these tests.
We currently have information for Pixel 4, NVIDIA and Intel Win/Linux,
and SwiftShader Windows. GLES 1.x extensions are treated separately.
Some WebGL/Mac-only/D3D-only extensions show as unsupported anywhere.
In order to capture artifacts on Android, we use a render test output
parameter.
Bug: angleproject:6379
Change-Id: I560b219b5a586cdbb68d272090f38eedc76aba20
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3176780
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Ian Elliott <ianelliott@google.com>
Reviewed-by: Tim Van Patten <timvp@google.com>
Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
So it will be easier for users to distinguish tests run on different
GPUs.
R: jmadill,ynovikov
BUG: chromium:1249703
Change-Id: I393d305c963f5fc654c9c32fc86cda6c7f019086
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3195351
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
This reverts commit 90c981dafc.
Reason for revert: Causing timeouts on perf bots.
Original change's description:
> Perf Tests: Split samples into sub-tests on desktop.
>
> This adds an option to the perf test runner to split each sample of
> each test into a sub-test. The sub-tests then are split among the
> shards like ordinary tests, and distributed across machines. The
> intent is that running on different machines will reduce inter-build
> variance because of differences between test machines.
>
> This sampling change is only added to desktop (Linux/Win) because
> Android device variance seems to be lower.
>
> Bug: angleproject:6090
> Change-Id: I4046a012727baa8a0f2595de2349cc34257691f9
> Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3152752
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
> Reviewed-by: Cody Northrop <cnorthrop@google.com>
> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Bug: angleproject:6090
Change-Id: I92bffb98999f35274ec31a3b7567d87453feff94
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3174274
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
This adds an option to the perf test runner to split each sample of
each test into a sub-test. The sub-tests then are split among the
shards like ordinary tests, and distributed across machines. The
intent is that running on different machines will reduce inter-build
variance because of differences between test machines.
This sampling change is only added to desktop (Linux/Win) because
Android device variance seems to be lower.
Bug: angleproject:6090
Change-Id: I4046a012727baa8a0f2595de2349cc34257691f9
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3152752
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Cody Northrop <cnorthrop@google.com>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
For qualifying Mac OS 11 on Mac Retina AMD and Mac Mini 8,1
Bug: chromium:1241597, chromium:1128540
Change-Id: I753b504f5910541f5d3f244d117d369937a06d38
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3150752
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Leave them centralized in ANGLEWrangling.md, link to them from
BranchingAndRolling.md, and add the Chromium-into-ANGLE autoroller.
Bug: angleproject:6323
Change-Id: I913954b92dbe3545320e662de122daf26140d425
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3124341
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
These were killing the bots for some reason. Disable them until we
can find the root cause.
Bug: angleproject:6090
Bug: angleproject:6332
Change-Id: I48b633118f098570e371ea81d9e512e35ab04cd6
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3123169
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Use the name of the Android device or GPU manufacturer.
Bug: angleproject:6090
Change-Id: I2e26586578c51f9a714fed23586854bb14030242
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3111028
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Separating only by OS makes the perf dashboard uploads land in the
same bucket for NVIDIA and Intel results. The two are intermingled
on the dashboards. Split this by separating the GPU configs into
their own builders.
Must land before http://crrev.com/c/3110765
Bug: angleproject:6090
Change-Id: Icee3b19d3462977b4ec86bfe08d7c44431426d24
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3110745
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
The test shards right now are taking 20-30+ minutes. Sometimes they
time out on the test infra. Increase sharding because the overhead
from sharding is very small relative to the test time used by shards.
Bug: angleproject:6090
Change-Id: I45c7bf077da7242743559d68b45d45dbea18355e
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3100586
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Ian Elliott
Ben Pastene
Yuly Novikov
Jamie Madill
Jamie Madill
angle-autoroll
Cody Northrop
Vadim Shtayura
Weiwei Lin
Shahbaz Youssefi
Kenneth Russell