angle/infra
Jamie Madill 2b86e2d60f GN: Update dcheck/assert conditions.
In preparation for a Chromium change that makes dchecks enabled
by default in Release builds, we'll keep ASSERT disabled in
Release by default. We add a new flag 'angle_assert_always_on'
for controlling ANGLE ASSERT behaviour.

Also slightly refactors the direct SPIR-V generation GN.

Chromium CL: https://crrev.com/c/2893204

Bug: chromium:1225701
Change-Id: I01a6def28d7c21e771e9800889a6b9c274972de2
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/3035447
Reviewed-by: Shahbaz Youssefi <syoussefi@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
2021-07-19 19:05:44 +00:00
..
config infra/config: remove unused isolated property 2021-07-06 12:49:11 +00:00
specs GN: Update dcheck/assert conditions. 2021-07-19 19:05:44 +00:00
ANGLEWrangling.md
README.md

README.md

ANGLE Testing Infrastructure

ANGLE runs hundreds of thousands of tests on every change before it lands in the tree. We scale our pre-commit and post-commit testing to many machines using Chromium Swarming. Our testing setup heavily leverages existing work in Chromium. We also run compile-only Standalone Testing that does not depend on a Chromium checkout.

Also see the documentation on ANGLE Wrangling for more info.

Pre-Commit Testing

See the pre-commit try waterfall here:

https://ci.chromium.org/p/chromium/g/tryserver.chromium.angle/builders

We currently run pre-commit tests on:

  • Windows 32-bit AMD and Windows 64-bit Intel and NVIDIA GPUs
  • Linux 64-bit NVIDIA and Intel GPUs
  • Mac NVIDIA, Intel and AMD GPUs
  • Pixel 2 and Nexus 5X
  • Fuchsia testing in a VM

Looking at an example build shows how tests are split up between machines. See for example:

https://ci.chromium.org/ui/p/chromium/builders/try/mac-angle-try/454/overview

This build ran 81 test steps across 3 GPU families. In some cases (e.g. angle_deqp_gles3_metal_tests) the test is split up between multiple machines to run faster (in this case 4 different machines at once). This build took 15 minutes to complete 1 hour of real automated testing.

For more details on running and working with our test sets see the docs in Contributing Code.

ANGLE Standalone Testing

In addition to the ANGLE try bots using Chrome, and the GPU.FYI bots, ANGLE has standalone testing on the Chrome infrastructure. Currently these tests are compile-only. This page is for maintaining the configurations that don't use Chromium. Also see the main instructions for ANGLE Wrangling.

It's the ANGLE team's responsibility for maintaining this testing infrastructure. The bot configurations live in four different repos and six branches.

Info Consoles

Continuous builders for every ANGLE revision are found on the CI console:

https://ci.chromium.org/p/angle/g/ci/console

Try jobs from pre-commit builds are found on the builders console:

https://ci.chromium.org/p/angle/g/try/builders

How to add a new build configuration

  1. bugs.chromium.org/p/chromium/issues/entry?template=Build+Infrastructure:

    • If adding a Mac bot, request new slaves by filing an infra issue.
  2. chrome-internal.googlesource.com/infradata/config:

    • Update configs/chromium-swarm/starlark/bots/angle.star with either Mac slaves requested in the previous step or increase the amount of Windows or Linux GCEs.
  3. chromium.googlesource.com/chromium/tools/build:

    • Update scripts/slave/recipes/angle.py with new the config.
    • The recipe code requires 100% code coverage through mock bots, so add mock bot config to GenTests.
    • Maybe run ./scripts/slave/recipes.py test train to update checked-in golden files. This might no longer be necessary.
  4. chromium.googlesource.com/angle/angle:

    • Update infra/config/global/cr-buildbucket.cfg to add the new builder (to ci and try), and set the new config option.
    • Update infra/config/global/luci-milo.cfg to make the builders show up on the ci and try waterfalls.
    • Update infra/config/global/luci-scheduler.cfg to make the builders trigger on new commits or try jobs respectively.
    • Update infra/config/global/commit-queue.cfg to add the builder to the default CQ jobs (if desired).

Other Configuration

There are other places where configuration for ANGLE infra lives. These are files that we shouldn't need to modify very often:

  1. chrome-internal.googlesource.com/infradata/config:

    • configs/luci-token-server/service_accounts.cfg (service account names)
    • configs/chromium-swarm/pools.cfg (swarming pools)
  2. chromium.googlesource.com/chromium/tools/depot_tools:

    • recipes/recipe_modules/gclient/config.py (gclient config)