* Add missing Identity fields to API converters
* Properly convert PlatformWorkloadIdentityProfile from internal -> admin
* Do not clobber existing read-only fields on admin PUT/PATCH
* Fix silly mistakes...
* Fix unit test case
* Do not clobber existing PlatformWorkloadIdentity readonly fields (clientid/objectid) on patch
* Ensure CSP-specific update steps only run for CSP clusters
* Ensure ClientId/ObjectIds are populated for all platform workload identities
* Ensure required federated identity credentials during cluster update
Note that additional work is still required to ensure this works as expected,
which will be handled in follow-up efforts.
* Add step to directly deploy platform workload identity credential secrets on-cluster during Update
* Refactor: extract mock platformWorkloadIdentityRolesByVersion setup to shared function
* Do not clobber existing ManagedServiceIdentity fields (IssuerURI) on patch
* Apply upgradeable-to annotation to cloudcredential resource via Patch
This avoids issues with e.g. having the wrong version of the resource struct
definition vendored into the RP.
* Fix az aro update request body handling
- Only pass in new/updated identities (RP will add these to the existing identity map during a patch operation)
- Only set the upgradeableTo property if it is explicitly set
This adds a step to static validation that checks to see if operator
identities use the same resource ID as any other operator identities and
causes the cluster installation to fail if so. Each operator should have
its own identity.
* api changes
fix tag package-2023-11
this was wrong in the readme
remove UserAssignedIdentities
top level fields must not have additionalproperties
update the default tag to latest
define a new IdentityType with x-ms-enum
modelAsString on identityType x-ms-enum should be false
rename IdentityType to ResourceIdentityType to match v3/types.json
make client
add descriptions to all new API fields
make client
fix unit test that was failing as a result of removing the UserAssignedIdentity type from the API
Adjust a doc comment according to feedback
make client
* add platformworkloadidentityroleset to API definition and examples
Update client generation to account for swagger subfolder
make client
fix pwip and validatestatic unit tests
fix relative path to common-types
migrate from common-types/v3 to common-types/v6
it was requested that we use the latest version of
common types. This involves some changes to our examples
to match the UUID expected.
move from Identity to ManagedServiceIdentity type
defined in common-types/v6
use modelerfour.lenient-model-deduplication=true
avoids python client generation issues
convert PlatformWorkloadIdentity to map
ARO-4382 fix unit test cases
make generate swagger
fix unit tests
revert naming openShiftCluster.ManagedServiceIdentity to Identity
fix prod code and unit tests post-rebase, reference common-types
directly for the identity property
* more swagger CI fixes
* fix examples to contain identity and type
* remove PlatformWorkloadIdentityRoleSetUpdate
oct 16th changes
oct 17th changes
fix issues post-rebase
* update readme to contain suppression for avoidAdditionalProperties
* fix ModelValidation error by converting example IDs to resourceIDs
* Update python/go clients
* Update az aro extension to enumerate platform_workload_identities as a dict instead of a list
* Fix python linter issues
* configure suppression for PatchBodyParametersSchema
appease the linter, fix subscriptionID type in util/azureclient
appease the linter again
correct log statement, use better naming
* regenerate examples
* changes operatorName and roleDefinitionName in PWIRS_List.json
---------
Co-authored-by: Tanmay Satam <tsatam@redhat.com>
kimorris27
Taylor Fahlman
Ayato Tokubi
Kipp Morris
Sanjana Lawande
Tanmay Satam
Ben Vesel
Maitiú Ó Ciaráin
Hilliary Lipsig
Amber Brown
Goutham Muguluvalli Niranjan
Alex Chvatal
Alex Chvatal
Caden Marchese
Rajdeep Chauhan