Граф коммитов

529 Коммитов

Автор SHA1 Сообщение Дата
Ayato Tokubi 9458ae478e
Fix if brackets (#3952) 2024-11-12 14:38:03 +01:00
bennerv 7be7c5c24c remove master key authorizer in favor of local auth 2024-11-05 21:03:00 -05:00
Alex Chvatal cb44560633
specify json output for a couple az commands that were missing it (#3937) 2024-11-01 13:53:23 -07:00
Caden Marchese faf377c984
Incorporate CI and ARM feedback from azure-rest-api-specs to v2024-08-12-preview API (#3727)
* api changes

fix tag package-2023-11
this was wrong in the readme

remove UserAssignedIdentities
top level fields must not have additionalproperties

update the default tag to latest

define a new IdentityType with x-ms-enum

modelAsString on identityType x-ms-enum should be false

rename IdentityType to ResourceIdentityType to match v3/types.json

make client

add descriptions to all new API fields

make client

fix unit test that was failing as a result of removing the UserAssignedIdentity type from the API

Adjust a doc comment according to feedback

make client

* add platformworkloadidentityroleset to API definition and examples

Update client generation to account for swagger subfolder

make client

fix pwip and validatestatic unit tests

fix relative path to common-types

migrate from common-types/v3 to common-types/v6
it was requested that we use the latest version of
common types. This involves some changes to our examples
to match the UUID expected.

move from Identity to ManagedServiceIdentity type
defined in common-types/v6

use modelerfour.lenient-model-deduplication=true
avoids python client generation issues

convert PlatformWorkloadIdentity to map

ARO-4382 fix unit test cases

make generate swagger

fix unit tests

revert naming openShiftCluster.ManagedServiceIdentity to Identity

fix prod code and unit tests post-rebase, reference common-types
directly for the identity property

* more swagger CI fixes
* fix examples to contain identity and type
* remove PlatformWorkloadIdentityRoleSetUpdate

oct 16th changes

oct 17th changes

fix issues post-rebase

* update readme to contain suppression for avoidAdditionalProperties

* fix ModelValidation error by converting example IDs to resourceIDs

* Update python/go clients

* Update az aro extension to enumerate platform_workload_identities as a dict instead of a list

* Fix python linter issues

* configure suppression for PatchBodyParametersSchema

appease the linter, fix subscriptionID type in util/azureclient

appease the linter again

correct log statement, use better naming

* regenerate examples
* changes operatorName and roleDefinitionName in PWIRS_List.json

---------

Co-authored-by: Tanmay Satam <tsatam@redhat.com>
2024-10-29 14:08:36 -07:00
cadenmarchese 37a98acb64 remove whitespace 2024-10-28 17:27:48 -04:00
cadenmarchese 9b4190aa29 Local dev scripts fixups
* Don't exit the terminal when there's an error from a subcommand
* PlatformWorkloadIdentityRoleSets should be single-quoted
2024-10-28 17:20:41 -04:00
Ayato Tokubi d89a378897
Check Role Definition for MIWI (#3876)
* bump cluster-credentials-operator

* add Get to roledefinitions client

* check script

* pipeline

* use parameters

* change target-version help message

* vendor

* fix role.go

* use candidate channel

* use operator names in RP-Config

* modify the output format

* changed to use quay.io API

* add some comments

* remove pipeline resource

* change role definition names
2024-10-24 12:35:57 -04:00
bennerv b1a018a12a Update role definition names and keys used 2024-10-23 09:08:38 -04:00
Tanmay Satam fe6b3efa75
Rename RESOURCEGROUP envvar to CLUSTER_RESOURCEGROUP in MIWI dev steps to avoid conflicts with RP resourcegroup (#3912) 2024-10-22 08:39:25 -04:00
Caden Marchese d2a21c63c8
Create the cluster identity in hack/devtools/local_dev_env.sh (#3910) 2024-10-18 15:05:04 -07:00
Goutham Muguluvalli Niranjan 98e5056c35
Generate Federated Identity Credentials for MIWI Cluster (#3847)
* Generate federated MIWI credentials

bring in more changes from master

typos

add len check for federated Identity naming

don't return cluster ID when OIDC issuer is nil

skip RBAC on CSP for WI cluster

check for invalid object ID before RBAC template creation

single qoute when passing resource Name

check for nil clusterMsiFederatedIdentityCredentials

remove unused controller

ensure the case folding of cluster MSI resourceID

Fed Cred name logic

update calls to fetch fed cred name

No RBAC for Cluster MSI

update getPlatformWorkloadIdentityFederatedCredName

fix WI RG RBAC

define constants to imporve readability

correct the call to resourceGroupRoleAssignmentWithDetails

Move fed cred deletion to be before cluster MSI cert deletion and add a log statement for fed cred deletion

Rename function for clarity and to match name of unit test function

Nitpick test case names for clarity and test data for correctness

* don't continue resource clean up on fed cred deletion fails

* remove duplicate of clusterServicePrincipalRBAC()

* nit

---------

Co-authored-by: gniranjan <gniranjan@microsoft.com>
2024-10-16 16:37:03 -04:00
Tanmay Satam d52d69d901
Update localdev platformworkloadidentityrolesets (#3901)
- Add secretLocation for all identities (required to put down CCO secrets in-cluster)
- Update MachineAPI to use correct service account (machine-api-controllers)
- Prefix all service account identifiers with 'system:serviceaccount:'
2024-10-11 11:44:58 -04:00
Rajdeep Chauhan 16834d8ddd
Fix Managed Identity Cluster creation dynamic validation flow (#3891)
* Fix Dynamic Validation Flow for Workload Identity

* fix the mock msi object id export

* Remove unwanted code

* update OIDC_STORAGE_ACCOUNT_NAME local env setup

* ARO-11049 resolve comments
2024-10-10 14:12:06 -04:00
Steven Fairchild 0362cb5565
Remove erroneous -n causing the log message to be read as a variable (#3896)
hack/util.sh: line 14: would: unbound variable occurs in it's current state.
2024-10-09 15:13:31 -07:00
Steven Fairchild f7404a1877
Hive version bump to resolve RHSA-2024:5535 (CVE-2023-6597) (#3893)
* Updated hive apis module to 986c5efa21

* Update hive cmd/mirror to use hive image tag 986c5efa21
2024-10-09 14:56:49 -04:00
Jory Horeman 68bc93250c
Scaffolding for CI environment setup in Azure (#3838)
* adding CI dev template files and scripts
2024-09-19 09:42:39 -06:00
Tony Schneider 9584d669b6
generalize secret storage deployment and update shared rp documentation (#3828)
* generalize secret storage account deployment template
* update secret storage deployment step
2024-09-13 18:14:38 +10:00
Or Raz abf4167f01
Refactor Hive Directory (#3765)
* Move Hive hack files under one directory
Group the Hive files under hack directory to hack/hive

* Refactor Hive installation and hack files location
Group the Hive files under hack directory to hack/hive, and refactor Hive installation using main function and utils.sh

* Print troubleshooting for Hive deployment rollout
Trust in the operator installation and print two options to monitor Hive deployment rollout

* Small fixes for hive installation script
Use double quote to prevent word splitting, break long line into multiple, use '-n' over '! -z', simpler if check, use consistent function declaration syntax, trap outside main and after cleanup is declared
2024-09-11 14:31:35 +02:00
Amber Brown 590e82881c
Clean up the remainder of `go run` uses of external tools (#3823)
* fix make aro build in onebranch
* just install jq for clean subscription
* move fipsdetect and gojq out of go run/manual go build territory
* install tools for validate-fips and e2e
* add to bin
* copy gojq here too
* go mod tidy
* go mod vendor
2024-09-10 18:28:06 +10:00
Amber Brown c554e98391
Drop some unneccessary dependencies by moving to `bingo` for tooling (#3719)
* Move to using bingo for tools
* go mod vendor
2024-09-05 15:29:19 +10:00
Petr Kotas 751cfe3b6b
Move ARM swagger to subfolder (#3805)
To add new HCP RP, the ARO RP is moved into the subfolder openshiftclusters.

There are no additional changes, no impact on the SDK and clients.
2024-08-30 18:18:40 +02:00
Shubhadapaithankar b1caf181ee
This is the new CI-RP stage for the pipline (#3768)
* This is the new CI-RP stage for the pipline (#3753)

* Ensure Podman Service is Started and PODMAN_REMOTE_ARGS is Configured Automatically

Ensure Podman Service is Started and PODMAN_REMOTE_ARGS is Configured Automatically

Ensure Podman Service is Started and PODMAN_REMOTE_ARGS is Configured Automatically

removed the tag

Add Podman service start and remote args setup for seamless operation

Add sudo to start Podman service for elevated permissions and fix permission errors

Add sudo to start Podman service for elevated permissions and fix permission errors

Refactor Makefile: Update Podman service handling with sudo and remove default PODMAN_REMOTE_ARGS to improve flexibility and ensure proper permissions.

Add sudo to start Podman service for elevated permissions and fix permission errors

* Added Podman service target and set PODMAN_REMOTE_ARGS for seamless builds.

* fix the makefile

* added the port to fix the Makefile
2024-08-29 09:09:59 -04:00
Maitiú Ó Ciaráin 5dfba0547e
Merge pull request #3780 from Azure/copy-fluentbit
Copy Fluenbit Image
2024-08-28 11:43:22 +02:00
Tanmay Satam e079d1700c
Only fail NPM audit on high/critical vulnerabilities (#3790)
* npm audit fix

* Do not fail npm audit on info/low/moderate vulnerabilities
2024-08-22 13:35:26 -06:00
Nicolas Ontiveros fd8d3cf7f1
Add scripts to create platform identities for dev (#3734)
---------

Co-authored-by: Nicolas Ontiveros <nicolas.ontiveros@microsoft.com>
2024-08-21 09:25:17 -04:00
oraz 0ae1ef4c9a
Copy fluentbit image from arointsvc ACR to your ACR
It is needed since it is compared against a default image (and digest) from const file
2024-08-19 17:20:32 +03:00
Shubhadapaithankar a387947960
Make runlocal-rp with Container Image (#3593)
Runlocal-RP is Containerized

- Modified Makefile to execute a local `podman run` for the RP on 127.0.0.1
- Local RPs now by default interact with Hive due to MacOS limitations
- Updated RP dev config to serve on all IPs due to MacOS limitations
- Doc updates
2024-08-16 11:41:58 -06:00
Steven Fairchild d874268829
Update hive image to tag bdf9d08a06 (#3770)
hive:bdf9d08a06 uses github.com/openshift/hive git commit bdf9d08a060abf558ca60e014123bf9278f58b4b.
2024-08-14 08:21:03 -04:00
Or Raz cedba924d8
Optionally Use USER Environment Variable for Azure Resources (#3681)
* Fetch USER env var once
Fetch the USER env var once instead of multiple times for faster DevConfig func execution time

* Set Azure unique prefix and USER as optional
Use an Azure unique prefix for the Azure resources that ARO-RP is using instead of always fetching the USER. When AZURE_UNIQUE_PREFIX env var is not set, then use the USER env var

* Modify more USER references
Rename AZURE_UNIQUE_PREFIX to AZURE_PREFIX, and export the usage of this env var for Azure prefix name resources when it is set. When it is missing use the default USER env var, as before
2024-08-07 14:57:33 +02:00
Maitiú Ó Ciaráin eefe6e8965
Merge pull request #3691 from Azure/zonalallocationfailed
CIF - ServerError: ZonalAllocationFailed
2024-07-24 16:27:30 +02:00
Maitiú Ó Ciaráin 44fce6fc32
Merge pull request #3713 from Azure/niontive/ARO-8986
Add scripts for creating and persisting mock cluster MSI
2024-07-24 09:56:01 +02:00
Maitiú Ó Ciaráin bfb554c620
Merge pull request #3696 from Azure/kimorris27/ARO-9005-shared-dev-kv-for-msi
Deploy shared dev key vault for mock MSI certificates
2024-07-23 18:50:45 +02:00
Nicolas Ontiveros 5cf1e3302e Add msi.sh 2024-07-22 17:08:31 -07:00
Nicolas Ontiveros b364f27ae1 Update local_dev_env.sh 2024-07-22 17:04:00 -07:00
Maitiú Ó Ciaráin b264f5c875
Merge pull request #3685 from Azure/mociarain/create-sp-for-each-e2e-run
Create sp for each e2e run
2024-07-22 09:05:27 +02:00
Or Raz 49eff97aff
Initial start of RP int automation (#3670)
* Initial start of RP int automation
Creating new pipeline with new templates for some of the steps

* Rename files and fetch image tags for ACR images
Remove the int/integration phrase from file names and directories, add bash script for fetching the image tag from pkg/util/version/const.go, and remove the clenup subscription template

* Get default image, tag and import it to ACR
Add new functions and scripts to get the images tag and set it nicely for importing and copying images by digest (e.g., for the fluenbit image).

* Add validation commands for downloading secrets and rp-dev-config creation
Check created directory and three config files after downloading the secrets from the shared RP config, and validate that a new rp-dev-config file has been created

* Use Azure unique prefix
Use an Azure unique prefix for the Azure resource names that ARO-RP is creating

* Update env vars
No cahce is needed for running the pipeline, az aro source can be discarded, and remove the e2e suite var

* Simplify two bash scripts and use newer base image
Use UBI8 toolbox image v8.10 with a better name, and shorter env declartion or env validation over multiple lines

* Logically group steps for rp-full-dev-setup
Simplify 'main' pipeline by grouping them by their purpose and use -e flag for the bash scripts

* Typo fix + git commit
s/delpoy/deploy
2024-07-19 19:27:07 +02:00
kimorris27 c7af7fc7c8 Update docs and hack script to reflect consolidated MIWI dev infra ARM template 2024-07-18 12:40:59 -05:00
kimorris27 0e5b43e257 Update hack script with functions for deploying the key vault 2024-07-18 12:21:04 -05:00
kimorris27 8612abec71 Fix indentation 2024-07-18 12:21:03 -05:00
kimorris27 3b0147e3f6 Add new KV with RBAC and then `make generate` 2024-07-18 12:21:03 -05:00
Maitiú Ó Ciaráin 1c9f3f66f7 Update logging 2024-07-18 18:11:47 +02:00
Maitiú Ó Ciaráin 2aca66076c Drop get_sp function 2024-07-18 18:11:47 +02:00
Maitiú Ó Ciaráin 830068abe6 Tidy up 2024-07-18 18:11:47 +02:00
Maitiú Ó Ciaráin 6431df8019 Revert DeleteApp 2024-07-18 18:11:47 +02:00
Maitiú Ó Ciaráin 1f857e1ed1 Revert createApp 2024-07-18 18:11:47 +02:00
Amit 49af5c640a CIF - ServerError: ZonalAllocationFailed 2024-07-16 11:19:33 +05:30
Amber Brown e711e610a0
Move to maintained yaml lib (#3454)
* move to maintained yaml lib

* update validate-imports

* go mod
2024-07-10 09:57:42 +10:00
Steven Fairchild a69a16029e Bump Hive Image to commit b1ac27b248159f179abf8c7e03e6ada5f17e86c0 - ARO-5063
Update default hive commit for config script
2024-07-08 13:11:43 -07:00
Steven Fairchild e20e96f964 Fix up hive-generate-config.sh to accept a user provided hive commit
This allows for easier testing of hive deployments as a pre hive release check.
Script has been reworked for improved readability, function, and ability to debug.
2024-07-03 16:46:03 -04:00
Rajdeep Singh Chauhan 42daa82815 ARO-4373 resolve comments and parameter fixes 2024-06-30 20:38:28 -04:00