Daniel J. Holmes (jaitaiwan)
ba6af03163
chore: Move to azuresdk folder
2024-11-18 15:09:30 +10:00
Daniel J. Holmes (jaitaiwan)
c3aac1d8ea
chore: vendor in containerruntime
2024-11-18 15:09:30 +10:00
Daniel J. Holmes (jaitaiwan)
f9ba066cd3
fix: Remove generate as we no longer need mock
2024-11-18 15:09:30 +10:00
Daniel J. Holmes (jaitaiwan)
b67e845302
feat: switch to containerservice v6
2024-11-18 15:09:30 +10:00
Rajdeep Chauhan
7708100181
ARO-12034 Fix CheckAccessV2 usage for MIWI dynamic validation ( #3946 )
...
* ARO-12034 Fix CheckAccessV2 usage for MIWI dynamic validation
* ARO-12034 resolve comments and update unit tests
* ARO-12034 updated comment for validateActionsByOID
* Initialize cluster MSI clients before dynamic validation in cluster update
---------
Co-authored-by: Tanmay Satam <tsatam@redhat.com>
2024-11-15 14:43:40 -05:00
Alex Chvatal
6a37ae10da
add reminder that dev clusters don't show up in ARM ( #3958 )
...
add reminder that dev clusters don't show up in ARM
2024-11-15 13:22:51 -05:00
Taylor Fahlman
283043eaa0
Merge pull request #3954 from Azure/tsatam/heartbeat-emit-version-dimension
...
Emit version as a dimension on heartbeat metrics
2024-11-14 11:10:23 -08:00
Taylor Fahlman
6b51a35156
Merge pull request #3949 from Azure/s-fairchild/ARO-10816-resulttype-metric
...
Pass backendErr to emitMetrics
2024-11-14 11:09:55 -08:00
Tanmay Satam
0384e08a95
Emit version as a dimension on heartbeat metrics
2024-11-13 17:36:04 -05:00
Taylor Fahlman
6c56ef7d15
Merge pull request #3953 from Azure/ARO-12070-part-1
...
Realign CredentialsRequest to match current ARO operator role definition
2024-11-12 10:50:44 -08:00
Ayato Tokubi
9458ae478e
Fix if brackets ( #3952 )
2024-11-12 14:38:03 +01:00
Kipp Morris
59f60b004e
MIWI API converter fixes ( #3950 )
...
* Add missing Identity fields to API converters
* Properly convert PlatformWorkloadIdentityProfile from internal -> admin
* Do not clobber existing read-only fields on admin PUT/PATCH
* Fix silly mistakes...
* Fix unit test case
2024-11-11 13:02:51 -08:00
Taylor Fahlman
bd1632b80d
Realign CredentialsRequest to match current ARO operator role definition
2024-11-08 11:04:44 -08:00
Steven Fairchild
879258e4ae
Pass backendErr to emitMetrics
...
nil was mistakenly being passed to emitMetrics, causing resultType to always fail collection due to the nil backendError provided.
2024-11-08 14:01:30 -05:00
Sanjana Lawande
a73f54136e
confirm UsesWorkloadIdentity shared utility function is used everywhere in ARO-RP ( #3932 )
...
* confirm shared utility function is used everywhere in ARO-RP
2024-11-08 12:19:35 -05:00
Tanmay Satam
d33d81b9c1
Support Update requirements for Workload Identity clusters ( #3935 )
...
* Do not clobber existing PlatformWorkloadIdentity readonly fields (clientid/objectid) on patch
* Ensure CSP-specific update steps only run for CSP clusters
* Ensure ClientId/ObjectIds are populated for all platform workload identities
* Ensure required federated identity credentials during cluster update
Note that additional work is still required to ensure this works as expected,
which will be handled in follow-up efforts.
* Add step to directly deploy platform workload identity credential secrets on-cluster during Update
* Refactor: extract mock platformWorkloadIdentityRolesByVersion setup to shared function
* Do not clobber existing ManagedServiceIdentity fields (IssuerURI) on patch
* Apply upgradeable-to annotation to cloudcredential resource via Patch
This avoids issues with e.g. having the wrong version of the resource struct
definition vendored into the RP.
* Fix az aro update request body handling
- Only pass in new/updated identities (RP will add these to the existing identity map during a patch operation)
- Only set the upgradeableTo property if it is explicitly set
2024-11-08 07:31:52 -08:00
Kipp Morris
a60d631f4f
MIWI Cosmos DB key uniqueness fix ( #3944 )
...
* Fix Cosmos DB unique key issue for MIWI clusters and update existing unit tests to continue to pass
* Add test case that validates changes
2024-11-07 09:19:34 -08:00
Ben Vesel
19061696b9
Merge pull request #3940 from Azure/bvesel/remove-master-key-authorizer
...
remove master key authorizer in favor of local auth
2024-11-07 12:04:55 -05:00
Kipp Morris
cc8f29c30b
Fix flaky unit test cases ( #3945 )
...
Tests now account for the fact that the actual code iterates over a map,
so the order can differ between test executions
2024-11-07 10:45:22 -05:00
Kipp Morris
825dbf95ac
Add missing env var to RP startup command ( #3943 )
2024-11-06 13:43:09 -08:00
Maitiú Ó Ciaráin
580dd96422
Make PreconfiguredNSG mutable ( #3941 )
...
Co-authored-by: Maitiu O Ciarain <mciarain@mciarain-thinkpadp16vgen1.barcelna.csb>
2024-11-06 11:59:20 -05:00
bennerv
7be7c5c24c
remove master key authorizer in favor of local auth
2024-11-05 21:03:00 -05:00
Ben Vesel
fcbebae2a6
Merge pull request #3561 from Azure/ankusing/ARO-5514-cosmosdb-disable-local-auth
...
Disable cosmosdb local auth
2024-11-05 20:56:53 -05:00
Hilliary Lipsig
fcd3e1d7e6
Merge pull request #3804 from Azure/rhamitarora/ARO-0000-document-broken-links
...
Updated Useful Links section
2024-11-04 09:46:17 -08:00
Hilliary Lipsig
6bfac73772
Merge pull request #3819 from Azure/sudobrendan/hotfix-add-run-rp-docs
...
Add run-rp docs
2024-11-04 09:35:42 -08:00
Hilliary Lipsig
52447fd112
Merge pull request #3920 from Azure/gniranjan/checkaccess
...
Fix CheckAccess group expansion bug
2024-11-04 09:19:31 -08:00
Taylor Fahlman
f0fbbbe7f7
Merge pull request #3938 from Azure/hawkowl/fix-validatestatic-multiple-operator-identities
...
Fix test flake in preview API for MIWI
2024-11-04 07:57:14 -08:00
Amber Brown
7d92fd396a
fix test which can be flaky depending on ordering on map key ordering
2024-11-04 14:29:51 +11:00
Goutham Muguluvalli Niranjan
1de29ca69c
use dv.env instead of dv.azEnv
2024-11-01 16:34:08 -05:00
Alex Chvatal
cb44560633
specify json output for a couple az commands that were missing it ( #3937 )
2024-11-01 13:53:23 -07:00
Alex Chvatal
517da1163f
disallow duplicate operator identity resource IDs
...
This adds a step to static validation that checks to see if operator
identities use the same resource ID as any other operator identities and
causes the cluster installation to fail if so. Each operator should have
its own identity.
2024-11-01 14:46:42 -04:00
Kipp Morris
25eef93d02
Deploy fix - GET devops MSI using properly scoped Azure client ( #3936 )
...
* GET the devops MSI using a separate identities client scoped to the
correct Azure subscription
* Fix silly mistake
2024-11-01 10:07:28 -07:00
Tanmay Satam
98580734e5
Fix AdminAPI representation of PreconfiguredNSG status ( #3933 )
...
* Fix spelling of preconfiguredNSG JSON tag
* Copy PreconfiguredNSG property during internal->admin conversion
* Fix nil pointer dereference when converting workload identity cluster doc to adminapi representation
* Update admin openshiftcluster_putorpatch tests to expect property for PreconfiguredNSG
2024-11-01 09:00:00 -04:00
Taylor Fahlman
8a2f3dd489
Merge pull request #3929 from Azure/bvesel/refactor-clean-up
...
Use constant / function names everywhere possible
2024-10-30 19:57:41 -07:00
Caden Marchese
27c26e14e9
Update cosmosdb auth used by update_role_sets.go ( #3931 )
2024-10-30 14:15:50 -07:00
Ben Vesel
b18cd2ccf0
Support rotation of kubeconfigs on Update for cx self-service ( #3927 )
2024-10-30 14:38:35 -04:00
Rajdeep Chauhan
89120b543c
ARO-9716 during miwi cluster install remove azure file csi storage class ( #3928 )
2024-10-30 14:36:10 -04:00
bennerv
122ac0f539
Use constant / function names everywhere possible
2024-10-30 13:51:00 -04:00
Goutham Muguluvalli Niranjan
9241717f3c
rebase
2024-10-30 11:29:22 -05:00
Goutham Muguluvalli Niranjan
6e5e9a38fe
pass token to SDK and update UT
2024-10-30 11:15:40 -05:00
Goutham Muguluvalli Niranjan
2a26c1d9be
update checkaccess mocks
2024-10-30 11:15:39 -05:00
Goutham Muguluvalli Niranjan
cb74242f14
use the latest changes from checkaccess SDK
2024-10-30 11:15:39 -05:00
Goutham Muguluvalli Niranjan
354f0f4f95
go mod tidy
2024-10-30 11:15:38 -05:00
Goutham Muguluvalli Niranjan
a1be39a3b5
go mod tidy
2024-10-30 11:15:38 -05:00
Goutham Muguluvalli Niranjan
9cc5c13293
delete old remotepdp references
2024-10-30 11:15:37 -05:00
Goutham Muguluvalli Niranjan
4a147fb90d
update unit tests
2024-10-30 11:15:37 -05:00
Goutham Muguluvalli Niranjan
593c6498bb
use checkaccess SDK for go
2024-10-30 11:12:55 -05:00
Goutham Muguluvalli Niranjan
79d1254c0d
update the references of GetObjecId() to ExtractClaims()
2024-10-30 11:12:55 -05:00
Goutham Muguluvalli Niranjan
69ca2118f6
generate checkaccess mocks
2024-10-30 11:12:54 -05:00
Goutham Muguluvalli Niranjan
a0f9cbca8c
add test util to create fake token
2024-10-30 11:12:54 -05:00