8adccf7ef9
Refactor/simplify gateway controllers ( #37 )
...
* moved Links classes to separate files
* url encoding query tokens
* events sent to signalR subscribers from handler instead of controller
2018-04-20 16:07:38 -07:00
1af7202242
Added helpers to ensure consistent format that comply with pragma ( #36 )
2018-04-18 12:00:02 -07:00
4ea7ae5b91
Fixing failing test
...
Removed explicit string null check from discussion: https://github.com/Azure/Sia-Root/pull/33#discussion_r180197830
2018-04-12 16:03:35 -07:00
6fd0bce056
Review feedback
2018-04-12 16:03:35 -07:00
e8ecd449bb
Rename Sia.Shared -> Sia.Core
2018-04-12 16:03:35 -07:00
67188770f7
CA1724: Type names conflict with namespace names
2018-04-12 16:03:35 -07:00
c0a4d36b75
CA1823: Avoid unused private fields ( https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1823-avoid-unused-private-fields )
...
(Scrubbing again. Intellisense was removing some warnings from the error list)
2018-04-12 16:03:35 -07:00
672db4c8cc
CA1822: Mark members as static ( https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1822-mark-members-as-static )
...
(Scrubbing again. Intellisense was removing some warnings from the error list)
2018-04-12 16:03:35 -07:00
de0afddad4
CS1998: Async method lacks 'await' and will run synchronously
2018-04-12 16:03:35 -07:00
ec8dc7a977
CS0659: Override Object.GetHashCode()
...
In this particular instance we'll never call GetHashCode(), so just suppress the warning.
2018-04-12 16:03:35 -07:00
77770a85a3
CA2007: Use ConfigureAwait
2018-04-12 16:03:35 -07:00
660148a410
CA1716: Identifiers should not match keywords ( https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1716-identifiers-should-not-match-keywords )
2018-04-12 16:03:35 -07:00
8d5e883813
CA1707: Identifiers should not contain underscores ( https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1707-identifiers-should-not-contain-underscores )
2018-04-12 16:03:35 -07:00
752d3ced6a
CA1304: Specify CultureInfo ( https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1304-specify-cultureinfo )
2018-04-12 16:03:35 -07:00
ff98d00688
CA1067: Override Object.Equals(object) when implementing IEquatable (
...
https://github.com/dotnet/roslyn-analyzers/blob/master/src/Microsoft.CodeQuality.Analyzers/Microsoft.CodeQuality.Analyzers.md#ca1067-override-objectequalsobject-when-implementing-iequatable )
2018-04-12 16:03:35 -07:00
48c947204e
Add tests project to solution
2018-04-12 16:03:35 -07:00
aaf5494b3d
CS0252: Possible unintended reference comparison
...
Line 35 does not cast the object as a string implicitly, so it's possible for a procedure to generate a string whose value is "null" but the memory address of that value is different than that of the constant value "null" in the string intern table.
2018-04-12 16:03:35 -07:00
1eb7e576ed
CS0168: Unused variables
...
This warning is generated by the compiler, not the code analysis tool. In each case of this commit the unused variable was an exception captured by the logic and then swallowed. Instead of swallowing these errors we should log and possibly re-throw the errors. That change is outside the scope of this effort.
2018-04-12 16:03:35 -07:00
3ddb2b9f1c
CA2227: Collection properties should be read only ( https://docs.microsoft.com/en-us/visualstudio/code-quality/ca2227-collection-properties-should-be-read-only )
2018-04-12 16:03:35 -07:00
79da986a5c
CA2007: Do not directly await a task without calling ConfigureAwait
...
The link to this rule is not present in the docs: https://docs.microsoft.com/en-us/visualstudio/code-quality/code-analysis-warnings-for-managed-code-by-checkid
2018-04-12 16:03:35 -07:00
cc5e47b483
CA1822: Mark members as static ( https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1822-mark-members-as-static )
...
Changes to LinksHeader should not cause any problems because there are no overrides for the protected methods at this time
2018-04-12 16:03:35 -07:00
bdc9e7c5f2
CA1720: Identifiers should not contain type names ( https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1720-identifiers-should-not-contain-type-names )
2018-04-12 16:03:35 -07:00
d0526e26b7
CA1716: Identifiers should not match keywords ( https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1716-identifiers-should-not-match-keywords )
...
Changing the namespace or the event would propogate considerable changes through the codebase. We should be deliberate about how we do this, so it's out of the scope of this issue.
2018-04-12 16:03:35 -07:00
7d196c116c
CA1710: Identifiers should have correct suffix ( https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1710-identifiers-should-have-correct-suffix )
2018-04-12 16:03:35 -07:00
ba16d62228
Add disposal for `_cert` which also implements IDisposable at a deeper level.
2018-04-12 16:03:35 -07:00
21561cf9d7
CA1707: Identifiers should not contain underscores ( https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1707-identifiers-should-not-contain-underscores )
...
It should be noted that this warning only appeard on property identifiers, not field or variable identifiers. This appears to be a bug with the FxCop implementation given that the documentation says it checks members and a field is a member. We should do a deeper clean here. This commit eliminates the warning message as the smallest possible change.
2018-04-12 16:03:35 -07:00
817a09f7b9
CA1305: Specify IFormatProvider ( https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1305-specify-iformatprovider )
...
Used `CultureInfo.InvariantCulture` in all formatting cases to generate a consistent outcome across all instances of the Gateway. If we need to do localization formatting then we shuld probably be doing that with the front end application.
2018-04-12 16:03:35 -07:00
b6904a91b6
CA1056: URI properties should not be strings ( https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1056-uri-properties-should-not-be-strings )
2018-04-12 16:03:35 -07:00
19ee7f06d7
CA1055: URI return values should not be strings ( https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1055-uri-return-values-should-not-be-strings )
2018-04-12 16:03:35 -07:00
6b23a34d10
Review feedback: Make Response constructors internal; we're using the factories to create the response objects.
2018-04-12 16:03:35 -07:00
8bcad978ce
Review fix: Suppress CS1032: There's not a clear need for dead code
2018-04-12 16:03:35 -07:00
01f12c13e6
Revert "CA1032: Implement standard exception constructors ( https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1032-implement-standard-exception-constructors )"
...
This reverts commit 03a062aa154c4225d550e2d511e69350a6ca16c9.
2018-04-12 16:03:35 -07:00
f93d342bb9
CA1054: URI parameters should not be strings ( https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1054-uri-parameters-should-not-be-strings )
...
In this case we are deliberately ignoring the advice because the breaking changes it may cause and the potential to require additional work around serialization/deserialization would significantly expand the scope of this effort.
2018-04-12 16:03:35 -07:00
c04579c1cf
CA1051: Do not declare visible instance fields ( https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1051-do-not-declare-visible-instance-fields )
2018-04-12 16:03:35 -07:00
372780cfb2
CA1032: Implement standard exception constructors ( https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1032-implement-standard-exception-constructors )
2018-04-12 16:03:35 -07:00
8c704ee0d9
CA1018: Mark attributes with AttributeUsageAttribute ( https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1018-mark-attributes-with-attributeusageattribute )
2018-04-12 16:03:35 -07:00
376a3a40ce
CA1001: Types that own disposable fields should be disposable ( https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1001-types-that-own-disposable-fields-should-be-disposable )
2018-04-12 16:03:35 -07:00
11347f1418
CA1000: Static members on generic types ( https://docs.microsoft.com/en-us/visualstudio/code-quality/ca1000-do-not-declare-static-members-on-generic-types )
2018-04-12 16:03:35 -07:00
737fc14ca8
Enable static code analysis. 117 Warnings
2018-04-12 16:03:35 -07:00
3f7b19aa85
Ux/event icons ( #34 )
...
Added Icon to eventType model with a brief summary of usage
2018-04-11 12:47:13 -07:00
739dc16029
Merge pull request #35 from Azure/maintenance/TravisRunsTests
...
Added test project to solution and added travis config for running tests
2018-04-11 12:46:04 -07:00
0671576171
Added test project to solution and added travis config for running tests
2018-04-11 10:51:10 -07:00
e4d0d11647
Merge pull request #32 from Azure/run_docker_containers_locally
...
added docker-compose.yml so all sia components can be easily run in d…
2018-03-26 09:57:30 -07:00
fe15c856f5
fixed a typo
2018-03-26 09:52:45 -07:00
7e086ad2c9
added docker-compose.yml so all sia components can be easily run in dev host as containers
2018-03-23 16:12:18 -07:00
b902bbfc6e
added docker-compose.yml so all sia components can be easily run in dev host as containers
2018-03-23 15:30:11 -07:00
bc177fa0e3
Travis integration ( #31 )
2018-03-19 11:45:49 -07:00
897b8ad32d
Merge pull request #30 from Azure/image_tag_fixup
...
passed image_repo into UpdateImageTag.sh
2018-03-19 10:23:50 -07:00
17fb1c6a3f
passed image_repo into UpdateImageTag.sh
2018-03-16 17:27:36 -07:00
0af98812e5
Merge pull request #28 from pdimitratos/features/filterSignalR
...
Altering filters to allow for bidirectional matching (single event ma…
2018-03-15 16:00:22 -07:00
pdimitratos
Daniel Jurek
Daniel Jurek
Philip Dimitratos
zhz2017
Zhuan Zou
Alberto Rodríguez