A recent package update broke the tool so we are adding a lock file to
ensure we have a reliable execution.
For details the newer version of
https://www.npmjs.com/package/shiki?activeTab=versions version 1.23.0
introduced a new dependency in https://github.com/shikijs/shiki/pull/832
which no longer compiles.
```
node_modules/oniguruma-to-es/types/parse.d.ts(61,49): error TS2339: Property 'orphan' does not exist on type '{}'.
node_modules/oniguruma-to-es/types/parse.d.ts(96,31): error TS2339: Property 'atomic' does not exist on type '{}'.
node_modules/oniguruma-to-es/types/parse.d.ts(96,39): error TS2339: Property 'flags' does not exist on type '{}'.
```
Until we figure out what the best way to fix those issues we are pinning
to the older version using a lock file.
This pullrequest adds a definition for an expanding and contracting
build that will be used to replace all `js - <service> - ci` build
definitions in the `public` devops project. This is an overall package
selection change, where we find the targeted packages using
`Save-Package-Properties.ps1` primarily. Analyze checks have also been
updated to honor this new selection methodology, rather than the hardcoded
artifactslist.
Only `js - pullrequest` will actually honor the expand and contract for
the packages that were changed in the PR. Meanwhile the `internal`
versions of the `service`-specific definitions will still exist, still
select packages for the service directory, and still be used to release
as normal.
`js - pullrequest` will run _alongside_ the existing builds for a short
period while we identify any outstanding bugs or collection adjustments.
After we're happy, we'll disable all public js builds in favor of the
single `js - pullrequest` build.
---------
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
The smoke-tests pipeline has been disabled but I still cleaned up to
smoke tests to remove usages of sub-config-azure-cloud-test-resources
and try to use a service connection. When we decide to re-enable the
smoke tests pipeline we will want to update the deployment to use
federated auth as well.
@xirzec you disabled this pipeline 1/10/2023. Do you have any plans to
try and re-enable it? If not perhaps we just delete this instead.
Successful run:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4083622&view=results
This PR introduces a new Azure DevOps pipeline that automatically lints
all Bicep files in the repository and generates a report of any linting
warnings. These reports are stored as artifacts and uploaded to Azure
Blob Storage for tracking over time.
### Benefits
- Automated Linting: Ensures that all Bicep files are consistently
checked for best practices and potential issues.
- Historical Tracking: By appending the date to the lint warnings file,
we can monitor progress and improvements over time.
### Next Steps
- Monitor the lint warnings reports over time to identify and address
recurring issues.
- Use the stored reports to guide refactoring efforts and improve Bicep
code quality across the repository.
### Current warnings:
```
WARNING: /home/codespace/window3/sdk/textanalytics/test-resources.bicep(32,34) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/textanalytics/test-resources.bicep(33,38) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/formrecognizer/test-resources.bicep(60,41) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/formrecognizer/test-resources.bicep(61,157) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/formrecognizer/test-resources.bicep(62,155) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/formrecognizer/test-resources.bicep(63,184) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/translation/test-resources.bicep(67,42) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/storage/test-resources.bicep(294,29) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(295,33) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(296,115) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(299,33) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(300,37) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(301,127) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(304,45) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(305,49) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(308,34) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(309,38) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(310,124) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(313,41) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(314,45) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(315,131) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(318,42) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(319,46) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(320,139) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/mixedreality/test-resources.bicep(25,42) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/communication/test-resources/test-resources.bicep(28,49) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/communication/test-resources/test-resources.bicep(29,66) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/communication/test-resources/test-resources.bicep(31,50) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/communication/communication-email/test-resources.bicep(52,49) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/communication/communication-email/test-resources.bicep(53,66) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/communication/communication-email/test-resources.bicep(55,55) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/template/test-resources.bicep(29,45) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/remoterendering/test-resources.bicep(111,49) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/remoterendering/test-resources.bicep(112,57) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/remoterendering/test-resources.bicep(117,47) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/tables/test-resources.bicep(62,29) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/tables/test-resources.bicep(63,31) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/tables/test-resources.bicep(64,133) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/tables/test-resources.bicep(65,115) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/eventgrid/test-resources.bicep(139,47) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/cognitivelanguage/test-resources.bicep(153,34) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/cognitivelanguage/test-resources.bicep(154,38) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/eventhub/event-hubs/perf-resources.bicep(5,9) : Warning BCP334: The provided value can have a length as small as 3 and may be too short to assign to a target with a configured minimum length of 6.
/home/codespace/window3/sdk/eventhub/event-hubs/perf-resources.bicep(13,12) : Warning BCP035: The specified "resource" declaration is missing the following required properties: "location". If this is an inaccuracy in the documentation, please report it to the Bicep Team. [https://aka.ms/bicep-type-issues]
/home/codespace/window3/sdk/eventhub/event-hubs/perf-resources.bicep(23,44) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listkeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(11,39) : Warning no-hardcoded-env-urls: Environment URLs should not be hardcoded. Use the environment() function to ensure compatibility across clouds. Found this disallowed host: "core.windows.net" [https://aka.ms/bicep/linter/no-hardcoded-env-urls]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(16,5) : Warning decompiler-cleanup: The name of variable 'eventHubsNamespace_var' appears to have originated from a naming conflict during a decompilation from JSON. Consider renaming it and removing the suffix (using the editor's rename functionality). [https://aka.ms/bicep/linter/decompiler-cleanup]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(19,5) : Warning decompiler-cleanup: The name of variable 'storageAccount_var' appears to have originated from a naming conflict during a decompilation from JSON. Consider renaming it and removing the suffix (using the editor's rename functionality). [https://aka.ms/bicep/linter/decompiler-cleanup]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(22,5) : Warning no-unused-vars: Variable "eventHubsAuthRuleResourceId" is declared but never used. [https://aka.ms/bicep/linter/no-unused-vars]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(26,9) : Warning BCP334: The provided value can have a length as small as 3 and may be too short to assign to a target with a configured minimum length of 6.
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(36,9) : Warning use-parent-property: Resource "eventHubsNamespace_eventHubName" has its name formatted as a child of resource "eventHubsNamespace". The syntax can be simplified by using the parent property. [https://aka.ms/bicep/linter/use-parent-property]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(37,3) : Warning BCP187: The property "location" does not exist in the resource or type definition, although it might still be valid. If this is an inaccuracy in the documentation, please report it to the Bicep Team. [https://aka.ms/bicep-type-issues]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(48,9) : Warning use-parent-property: Resource "eventHubsNamespace_eventHubName_eventHubAuthRuleName" has its name formatted as a child of resource "eventHubsNamespace_eventHubName". The syntax can be simplified by using the parent property. [https://aka.ms/bicep/linter/use-parent-property]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(66,5) : Warning BCP073: The property "tier" is read-only. Expressions cannot be assigned to read-only properties. If this is an inaccuracy in the documentation, please report it to the Bicep Team. [https://aka.ms/bicep-type-issues]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(81,71) : Warning BCP081: Resource type "Microsoft.Authorization/roleAssignments@2019-04-01-preview" does not have types available. Bicep is unable to validate resource properties prior to deployment, but this will not block the resource from being deployed.
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(90,64) : Warning BCP081: Resource type "Microsoft.Authorization/roleAssignments@2019-04-01-preview" does not have types available. Bicep is unable to validate resource properties prior to deployment, but this will not block the resource from being deployed.
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(101,45) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listkeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(104,35) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listkeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(105,129) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(105,156) : Warning BCP241: The "providers" function is deprecated and will be removed in a future release of Bicep. Please add a comment to https://github.com/Azure/bicep/issues/2017 if you believe this will impact your workflow.
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(107,42) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(107,69) : Warning BCP241: The "providers" function is deprecated and will be removed in a future release of Bicep. Please add a comment to https://github.com/Azure/bicep/issues/2017 if you believe this will impact your workflow.
WARNING: /home/codespace/window3/sdk/servicebus/test-resources.bicep(123,46) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/servicebus/test-resources.bicep(124,54) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/servicebus/test-resources.bicep(131,36) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/servicebus/service-bus/perf-resources.bicep(9,5) : Warning decompiler-cleanup: The name of variable 'authorizationRuleName_var' appears to have originated from a naming conflict during a decompilation from JSON. Consider renaming it and removing the suffix (using the editor's rename functionality). [https://aka.ms/bicep/linter/decompiler-cleanup]
/home/codespace/window3/sdk/servicebus/service-bus/perf-resources.bicep(38,46) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/servicebus/service-bus/test/stress/stress-test-resources.bicep(9,5) : Warning decompiler-cleanup: The name of variable 'authorizationRuleName_var' appears to have originated from a naming conflict during a decompilation from JSON. Consider renaming it and removing the suffix (using the editor's rename functionality). [https://aka.ms/bicep/linter/decompiler-cleanup]
/home/codespace/window3/sdk/servicebus/service-bus/test/stress/stress-test-resources.bicep(38,46) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/web-pubsub/test-resources.bicep(57,39) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/web-pubsub/test-resources.bicep(58,29) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/web-pubsub/test-resources.bicep(59,42) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/web-pubsub/test-resources.bicep(60,56) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/search/test-resources.bicep(19,38) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAdminKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/search/test-resources.bicep(20,42) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAdminKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/maps/test-resources.bicep(43,39) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/documentintelligence/test-resources.bicep(64,47) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/documentintelligence/test-resources.bicep(65,168) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/documentintelligence/test-resources.bicep(66,161) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/documentintelligence/test-resources.bicep(67,187) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/documentintelligence/test-resources.bicep(68,189) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/documentintelligence/test-resources.bicep(69,179) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/documentintelligence/test-resources.bicep(70,186) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/healthdataaiservices/azure-health-deidentification/test-resources.bicep(21,7) : Warning no-unused-params: Parameter "deploymentTime" is declared but never used. [https://aka.ms/bicep/linter/no-unused-params]
/home/codespace/window3/sdk/healthdataaiservices/azure-health-deidentification/test-resources.bicep(32,9) : Warning BCP334: The provided value can have a length as small as 0 and may be too short to assign to a target with a configured minimum length of 3.
/home/codespace/window3/sdk/healthdataaiservices/azure-health-deidentification/test-resources.bicep(168,26) : Warning BCP081: Resource type "microsoft.healthdataaiservices/deidservices@2024-02-28-preview" does not have types available. Bicep is unable to validate resource properties prior to deployment, but this will not block the resource from being deployed.
```
---------
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
### Packages impacted by this PR
@azure/identity
### Issues associated with this PR
N/A - test fixes
### Describe the problem that is addressed by this PR
Identity client libraries need some extensive setup to test various
credentials in different workloads. Some of the commands
require the az cli, and this enables us to login using az cli.
Eventually, my hope is to use this to provide federated credentials for
keyvault managed HSMs resource creation where our credential expires by
the time the HSM is deployed
### Packages impacted by this PR
### Issues associated with this PR
### Describe the problem that is addressed by this PR
Enable system access token env var in the relay credential
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
Recently linting was enabled for `monitor-opentelemetry-exporter`. Its
eslint
config enables typed linting which requires its dependencies to be build
in
order to have proper types.
This PR passes `-t @azure/monitor-opentelemetry-exporter` to `rush
build`
before linting so that its dependencies are built.
While at it, also change the `run-for-all-packages` pipeline to use
`install-run-rush.js` for consistency.
This PR
- removes `-f html -o telemetry-exporter-lintReport.html || exit 0` from
`lint` NPM script
- updates eslint config to report warn for some rules
- applies result of `lint:fix`
- fixes/suppresses linting errors
- in analyze pipeline, changes to build packages before linting so that
linting with types works
### Packages impacted by this PR
monitor-opentelemetry-exporter
### Issues associated with this PR
https://github.com/Azure/azure-sdk-for-js/issues/17942
### Packages impacted by this PR
### Issues associated with this PR
More details about the issue [here]
### Describe the problem that is addressed by this PR
Cosmos ci pipeline is failing after turning on Federated Auth by default
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
### Issues associated with this PR
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Jeremy Meng <jeremy.ymeng@gmail.com>
### Describe the problem that is addressed by this PR
When we enable Federated Auth, `ServiceConnection` is a required
parameter in `AzurePowerShell@5` task. Without this variable, the Deploy
Test Resources tasks will fail. This PR aims to set this variable by
default for the `Preview` cloud.
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
to lint and build all packages. This can be used to valid changes that
touches
large number of files, and are skipping CIs.
---------
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
All the other languages have disabled codeql and we are now hitting
blocking issues when running codeql on macos
(https://dev.azure.com/twcdot/Data/_workitems/edit/138580) and even on
the other OS's the configuration causes the builds to run for a long
time.
### Describe the problem that is addressed by this PR
Our samples currently use `DefaultAzureCredential` to authenticate the
client. This causes a problem running samples live in the pipeline
because Managed Identity does not work in the live pipeline. This is a
short term work around: we create a fake authority host so that Managed
Identity can fail fast and it will succeed with the Powershell credential.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
We do not want to change the samples to use a different credentials
because we want our customers to use DAC. We are discussing a long-term
solution by potentially adding exclude managed identity property similar
to Python/ .NET
Scott Beddall
Wes Haggard
Albert Cheng
Jeremy Meng
Azure SDK Bot
Deyaaeldeen Almahallawi
Ben Broderick Phillips
Maor Leger
Minh-Anh Phan
James Suplizio
EmmaZhu-MSFT
Daniel Jurek