We have a check for when asking for any session, i.e., not providing a
session id), but not receiving a link having a session id. However, the
check is `if (!this._providedSessionId && !receivedSessionId)` which
also evaluates to `true` for session id of empty string, which is valid
session id.
This PR changes it to check for `undefined` so that session id of empty
string doesn't lead to error being thrown.
Behind the scene, TSHY rewrites tsconfig.json to build the source code
of the library but it ignores tests and samples. This PR breaks the
monolith tsconfig.json into three ones, one for building the source, one
for the tests, and one for the samples. It utilizes [Project
References](https://www.typescriptlang.org/docs/handbook/project-references.html)
to create a TS project each. This setup makes sure type errors are
adequately caught in each of those projects.
Additionally, the PR disables rolling up d.ts files and fixes a type
error in tests.
### Packages impacted by this PR
- @azure/web-pubsub
### Issues associated with this PR
- https://github.com/Azure/azure-sdk-for-js/issues/31338
### Describe the problem that is addressed by this PR
Using the migration tool, moves @azure/web-pubsub to ESM/vitest.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Harsha Nalluru <sanallur@microsoft.com>
### Packages impacted by this PR
### Issues associated with this PR
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
- Add a test util to parse JWT token payload to validate audience
- Add more tests for AAD
- Fix mismatched DTO field when calling generateClientToken
---------
Co-authored-by: tomnguyen <chuongnguyen@microsoft.com>
### Packages impacted by this PR
- @azure/template-dpg
### Issues associated with this PR
- https://github.com/Azure/azure-sdk-for-js/issues/31338
### Describe the problem that is addressed by this PR
Upgrades @azure/template-dpg to ESM/vitest
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Jeremy Meng <jeremy.ymeng@gmail.com>
### Packages impacted by this PR
- @azure/identity
### Issues associated with this PR
### Describe the problem that is addressed by this PR
Bumps the `hookTimeout` and `testTimeout` for @azure/identity tests.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
- @azure/communication-rooms
### Issues associated with this PR
- https://github.com/Azure/azure-sdk-for-js/issues/31338
### Describe the problem that is addressed by this PR
Migrates @azure/communication-rooms using our migration tool to
ESM/vitest
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/cosmos
### Describe the problem that is addressed by this PR
In this PR we are adding three optional parameters in the Indexing
Policy in the vector Index to support partitioned DiskANN. The three
optional parameters are:
quantizationByteSize : The number of bytes used in product quantization
of the vectors.This is an optional parameter and applies to index types
DiskANN and quantizedFlat. The allowed range for this parameter is
between 1 and 200.
vectorIndexShardKey : The list of string containing the shard keys used
for partitioning the vector indexes. This is an optional parameter and
applies to index types DiskANN and quantizedFlat.
indexingSearchListSize : The size of the candidate list of approximate
neighbors stored while building the diskANN index as part of the
optimization processes.This is an optional parameter and applies to
index type DiskANN only. The allowed range is between 25 and 500.
The changes have been tested using a Test account, since as of now the
backend changes aren't live yet.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
Yes
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Ujjwal Soni <soniujjwal@microsoft.com>
Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
### Packages impacted by this PR
- @azure/opentelemetry-instrumentation-azure-sdk
- @azure/monitor-opentelemetry
- @azure/monitor-opentelemetry-exporter
- @azure/monitor-query
### Issues associated with this PR
- #31807
- #31808
- #31809
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Jackson Weber <jacksonweber@microsoft.com>
### Packages impacted by this PR
@azure/cosmos
### Issues associated with this PR
### Describe the problem that is addressed by this PR
Update changeLog for release.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
N/A
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
- @azure/communication-call-automation
### Issues associated with this PR
- https://github.com/Azure/azure-sdk-for-js/issues/31338
### Describe the problem that is addressed by this PR
Migrates package to ESM/vitest. Note that ServiceBus has issues with
Browser loads that we can fix in a later revision as Buffer is not
defined when you try to import any files. But then including Buffer then
also causes issues with the unit tests.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
* change our verifyChangelogs over to utilizing the artifact details. if we don't have an artifact details at all, don't verify changelog. if we do, but skipverifychangelog is present, don't verify changelog. if we have artifact details, but no disable, verify the changelog
---------
Co-authored-by: Scott Beddall <scbedd@microsoft.com>
### Packages impacted by this PR
`@azure/data-tables`
### Describe the problem that is addressed by this PR
Nothing is actually changing here except the release automation now
complains if the commit used isn't referencing main. The input file is
the same.
### Packages impacted by this PR
`@azure/data-tables`
### Describe the problem that is addressed by this PR
Preparing release for Cosmos Entra ID support. This functionality has
been validated by a partner team against the most recent nightly build.
### Packages impacted by this PR
### Issues associated with this PR
This PR updates code owners for cosmos.api.md file.
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
### Packages impacted by this PR
@azure/cosmos
### Issues associated with this PR
### Describe the problem that is addressed by this PR
This PR adds supports for Full text policy and Indexing.
This PR also adds support for Full text and hybrid search
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
Yes
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
Co-authored-by: Ujjwal Soni <soniujjwal@microsoft.com>
### Packages impacted by this PR
- @azure/communication-chat
### Issues associated with this PR
- https://github.com/Azure/azure-sdk-for-js/issues/31338
### Describe the problem that is addressed by this PR
Moves @azure/communication-chat to ESM/vitest.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure-rest/health-insights-radiologyinsights
### Issues associated with this PR
documentation not published
### Describe the problem that is addressed by this PR
a typo (missing -rest) to publish the types folder
### Packages impacted by this PR
@azure/create-microsoft-playwright-testing
### Issues associated with this PR
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Siddharth Singha Roy <ssingharoy@microsoft.com>
### Packages impacted by this PR
@azure/microsoft-playwright-testing
@azure/create-microsoft-playwright-testing
### Issues associated with this PR
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
Co-authored-by: guptakashish <guptakashish@microsoft.com>
### Packages impacted by this PR
### Issues associated with this PR
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
Co-authored-by: guptakashish <guptakashish@microsoft.com>
### Packages impacted by this PR
### Issues associated with this PR
@azure/microsoft-playwright-testing
### Describe the problem that is addressed by this PR
Changelog for 1.0.0-beta.5 (microsoft-playwright-testing) and
1.0.0-beta.2 (create-microsoft-playwright-testing)
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Vansh Vardhan Singh <vanshvsingh@gmail.com>
Co-authored-by: Siddharth Singha Roy <siddharthsingharoy@gmail.com>
### Packages impacted by this PR
@azure/openai
### Issues associated with this PR
N/A
### Describe the problem that is addressed by this PR
Preparing for releasing v2.0 that targets API
[v2024-10-21](https://github.com/Azure/azure-rest-api-specs/blob/main/specification/cognitiveservices/data-plane/AzureOpenAI/inference/stable/2024-10-21/inference.json).
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
N/A
### Are there test cases added in this PR? _(If not, why?)_
N/A
### Provide a list of related PRs _(if any)_
N/A
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [x] Added a changelog (if necessary)
---------
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
A recent package update broke the tool so we are adding a lock file to
ensure we have a reliable execution.
For details the newer version of
https://www.npmjs.com/package/shiki?activeTab=versions version 1.23.0
introduced a new dependency in https://github.com/shikijs/shiki/pull/832
which no longer compiles.
```
node_modules/oniguruma-to-es/types/parse.d.ts(61,49): error TS2339: Property 'orphan' does not exist on type '{}'.
node_modules/oniguruma-to-es/types/parse.d.ts(96,31): error TS2339: Property 'atomic' does not exist on type '{}'.
node_modules/oniguruma-to-es/types/parse.d.ts(96,39): error TS2339: Property 'flags' does not exist on type '{}'.
```
Until we figure out what the best way to fix those issues we are pinning
to the older version using a lock file.
Jeremy Meng
Deyaaeldeen Almahallawi
Azure SDK Bot
Matthew Podwysocki
EmmaZhu-MSFT
ZiWei Chen
cqnguy23
Manik Khandelwal
Wes Haggard
Aman Rao
Ujjwal Soni
Lazar
Jeff Fisher
Karolien Gellynck
Siddharth Singha Roy
Kashish Gupta
Daniel Jurek
Scott Beddall