### Packages impacted by this PR
@azure/monitor-opentelemetry-exporter
### Describe the problem that is addressed by this PR
We should follow the spec regarding which status codes should cause
statsbeat to shutdown and fail silently.
We should also align with other languages on the environment variable
used to disable statsbeat.
### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [x] Added a changelog (if necessary)
### Packages impacted by this PR
- `@azure-rest/core-client`
### Issues associated with this PR
- Fix https://github.com/Azure/azure-sdk-for-js/issues/31349
### Describe the problem that is addressed by this PR
We generate RLCs that allow for path parameters to be `number`. The
change for `allowReserved` assumed that path parameters could only be
`string`, causing number parameters to not be serialized properly. This
PR fixes that assumption.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
Added a test to check for a number path parameter
### Provide a list of related PRs _(if any)_
- #31058
### Packages impacted by this PR
`
@azure/microsoft-playwright-testing`
### Issues associated with this PR
Made browser name optional.
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/monitor-opentelemetry-exporter
### Describe the problem that is addressed by this PR
We should collect non-essential statsbeat about disk retry.
### Are there test cases added in this PR? _(If not, why?)_
Yes
### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [x] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/keyvault-keys
### Issues associated with this PR
Resolves#30822
### Describe the problem that is addressed by this PR
Migrate keyvault-keys to ESM and tshy
### Packages impacted by this PR
@azure/identity
### Issues associated with this PR
Resolves#31307
### Describe the problem that is addressed by this PR
It is not clear from our documentation that @azure/identity is optimized
for the "pass a credential to another client library" use-case and that
refreshing / caching / etc. are implementation details without proper API support and
documentation.
This PR attempts to provide additional information regarding when to use
something like MSAL directly.
---------
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
### Packages impacted by this PR
@azure/event-hubs
### Issues associated with this PR
https://github.com/Azure/azure-sdk-for-js/issues/31067
### Describe the problem that is addressed by this PR
This PR adds runtime validation to the input message structure. This is
needed so that strict receivers that follow the AMQP spec don't reject
non-compliant messages.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
N/A
### Are there test cases added in this PR? _(If not, why?)_
Yes
### Provide a list of related PRs _(if any)_
https://github.com/Azure/azure-sdk-for-js/pull/31330
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [x] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/monitor-opentelemetry
### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [x] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/cosmos
### Issues associated with this PR
#31119
### Describe the problem that is addressed by this PR
1. "http:" protocol now works properly
2. Unhandled errors in tests now properly include stack trace in STDERR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
We could possibly have done a further bifurcation of the logic for http:
vs https:. I chose this design because it was a minimal change and
maintains the original intent.
### Are there test cases added in this PR? _(If not, why?)_
No. There's not currently a good means to test http: against Cosmos DB,
but that's a WIP.
### Provide a list of related PRs _(if any)_
N/A
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
N/A
### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_ - N/A
- [ ] Added a changelog (if necessary) - N/A
---------
Co-authored-by: Chris Anderson <andersonc@microsoft.com>
### Packages impacted by this PR
- `@azure/keyvault-common`
- Downstream Key Vault packages
### Issues associated with this PR
- Private
### Describe the problem that is addressed by this PR
In future, the Key Vault service will be adding support for Continuous
Access Evaluation (CAE). This PR adds the necessary support to the SDK's
challenge-based authentication policy to enable this feature.
After the initial challenge, with CAE enabled, any future request may
result in a 401 response, even if the access token used is valid. This
PR adds a new policy that handles this CAE challenge alongside the
normal challenge. The new policy replaces the existing use of Core's
`bearerTokenAuthenticationPolicy`, which is no longer suitable for this
use case since it cannot handle a CAE challenge that comes immediately
after a regular challenge.
### Are there test cases added in this PR? _(If not, why?)_
Yes, added test cases with mock requests and responses to cover a number
of different scenarios, ensuring the policy is doing the right thing.
I also manually tested against a test resource provided by the Key Vault
team which returns a CAE challenge in response to any authorized request
to the vault, and got the expected result (a normal challenge handled
successfully, followed by a CAE challenge handled successfully, followed
by another CAE challenge which the policy does not handle).
### Provide a list of related PRs _(if any)_
- Java PR for same feature:
https://github.com/Azure/azure-sdk-for-java/pull/41814
Extract @MaryGao's fix from PR
https://github.com/Azure/azure-sdk-for-js/pull/31027
Fix an issue in `isStreamComplete` where the method never resolves when
the stream is not readable.
---------
Co-authored-by: Mary Gao <yanmeigao1210@gmail.com>
### Packages impacted by this PR
### Issues associated with this PR
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/montior-opentelemetry
### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [x] Added a changelog (if necessary)
### Packages impacted by this PR
Split tests for Public and INT environments
### Issues associated with this PR
### Describe the problem that is addressed by this PR
Int pipeline is not stable. Splitting public and int tests until we find
solution.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Dina Saparbaeva (from Dev Box) <dsaparbaeva@microsoft.com>
### Packages impacted by this PR
Nothing. Sample only
### Issues associated with this PR
Fixed samples to use proper environment variables. Use latest versions
of core tracing and instrumentation sdk.
I don't want users to change code to make the image url to work. So
change the code to make it run out of the box.
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
- @azure/template
### Issues associated with this PR
- #31296
### Describe the problem that is addressed by this PR
Adds a better timeout and retry logic for the issues with the best being
flaky.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/keyvault-secrets
### Issues associated with this PR
#30822
### Describe the problem that is addressed by this PR
Migrates keyvault-secrets to ESM and tshy
### Packages impacted by this PR
- @azure/template
### Issues associated with this PR
### Describe the problem that is addressed by this PR
Adds `supportsTracing` back to the template project.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Timo van Veenendaal <timov@microsoft.com>
### Packages impacted by this PR
- `@azure/template`
### Describe the problem that is addressed by this PR
Grants the "App Configuration Data Owner" when deploying the template
live test resources. This fixes some issues recording tests for the
template package (and possibly the live tests too).
Copied from the App Config test-resources.bicep
[here](https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/appconfiguration/test-resources.bicep)
### Packages impacted by this PR
@azure-rest/ai-inference
### Issues associated with this PR
N/A
### Describe the problem that is addressed by this PR
`@azure/core-tracing` will release as 1.2.0 as per
https://github.com/Azure/azure-sdk-for-js/pull/31272/files
This PR prepares ai-inference to use the correct version of
`@azure/core-tracing` and get support for `addEvent`
### Packages impacted by this PR
- @azure/create-microsoft-playwright-testing
### Issues associated with this PR
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
One of the template tests has been flaky on Mac OS. Given that template
is run as part of core and likely most PRs we decided to pend the test
for now and investigate it as part of #31296
### Packages impacted by this PR
@azure/dev-tool
### Issues associated with this PR
Resolves#29672
### Describe the problem that is addressed by this PR
With the move to ESM and tshy we've been running into issues using the
existing TS_NODE
based loader in dev-tool. Specifically we're seeing errors such as:
```
[run-samples] Error: Must use import to load ES Module: D:\a_work\1\s\sdk\template\template\samples-dev\getConfigurationSetting.ts
require() of ES modules is not supported.
require() of D:\a_work\1\s\sdk\template\template\samples-dev\getConfigurationSetting.ts from D:\a_work\1\s\common\tools\dev-tool\src\commands\samples\run.ts is an ES module file as it is a .ts file whose nearest parent package.json contains "type": "module" which defines all .ts files in that package scope as ES modules.
Instead change the requiring code to use import(), or remove "type": "module" from D:\a_work\1\s\sdk\template\template\package.json.
```
ts-node is being phased out for tsx, a modern alternative that handles
hybrid scenarios like us in much simpler manner.
This PR switches our loader from ts-node to tsx. Now we can run samples
again for both cjs and esm!
### Packages impacted by this PR
- `@azure-rest/core-client`
### Issues associated with this PR
- Fixes#30943
- Fixes#30944
### Describe the problem that is addressed by this PR
Adds support for passing in an object as a query or path parameter. At
present, this object allows for the user to specify a couple of
encoding-related options in addition to the value of the parameter:
- For path parameters: `allowReserved` can be set to true to indicate
that special characters appearing in the parameter should not be
URL-encoded. This allows for path parameters to contain characters like
`/`.
- For query parameters: `explode` can be set to true to change how
arrays are encoded. By default, array values are encoded as a single
query parameter, with each value separated by a comma (e.g. `foo=a,b,c`.
With `explode` set to true, each array value will be converted into a
single query parameter (e.g. `foo=a&foo=b&foo=c`).
***NO_CI***
Currently the rule only handles the case of
```ts
clientMethod(options: MethodOptions) {}
```
but not when the options bag parameter has a default value
```ts
clientMethod(options: MethodOptions = {}) {}
```
This change adds code to handle the latter.
- Add two unit tests
- Update the affected packages to suppress this rule as a warning
- react to the fix
### Packages impacted by this PR
@azure/opentelemetry-instrumentation-azure-sdk
### Issues associated with this PR
Resolves#31287
### Describe the problem that is addressed by this PR
Looks like Sinon's matchers are a little looser than vitest's - while we
are calling inject with 3 arguments we only care about the first in this
test.
This PR restores the tests and updates the assertion
### Packages impacted by this PR
- @azure/opentelemetry-instrumentation-azure-sdk
### Issues associated with this PR
### Describe the problem that is addressed by this PR
Migrates the package to ESM and vitest. Note one issue with mocking with
the propagator object.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Maor Leger <maorleger@users.noreply.github.com>
The baseline file suppresses errors and ideally should be empty. In this
PR, I'm trying to peel some of the low hanging fruit off like ensuring
our own team members are configured correctly and we're not assigning
issues to invalid labels.
Jackson Weber
Deyaaeldeen Almahallawi
Timo van Veenendaal
Kashish Gupta
Maor Leger
Christopher Anderson
Azure SDK Bot
Jeremy Meng
KarishmaGhiya
howieleung
Dina Saparbaeva
Matthew Podwysocki
Jeremy Meng
Jeff Fisher
Praven Kuttappan
cqnguy23