### Packages impacted by this PR
@azure/microsoft-playwright-testing
### Issues associated with this PR
Interrupted tests being incorrectly marked as failed.
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/microsoft-playwright-testing
### Issues associated with this PR
Fixing incorrect worker count with this change, calculating number of
workers based on runner index rather than config.
### Describe the problem that is addressed by this PR
Worker count was being picked up from config instead of actual value.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/batch
### Issues associated with this PR
N/A
### Describe the problem that is addressed by this PR
Release a new version of JS SDK according to Azure Batch's new API
version (2024-07-01)
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
N/A\
### Are there test cases added in this PR? _(If not, why?)_
Yes
### Provide a list of related PRs _(if any)_
Spec PR: https://github.com/Azure/azure-rest-api-specs/pull/29533
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Hoppe Wang <hoppewang@microsoft.com>
### Packages impacted by this PR
@azure/microsoft-playwright-testing
### Issues associated with this PR
Display informational messages to the user in case of errors during test
run.
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Siddharth Singha Roy <ssingharoy@microsoft.com>
### Packages impacted by this PR
@azure/create-microsoft-playwright-testing
### Issues associated with this PR
Ensure running prettier does not modify service configuration file
### Describe the problem that is addressed by this PR
- Missing comma
- Change double quotes to single quotes
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/microsoft-playwright-testing
### Issues associated with this PR
Display informational messages to the user in case of errors during test
run.
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
NA
### Are there test cases added in this PR? _(If not, why?)_
NA
### Provide a list of related PRs _(if any)_
NA
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
mixed-reality-remote-rendering
### Issues associated with this PR
Test pipeline failures in the mixed-reality-remote-rendering sdk tests.
### Describe the problem that is addressed by this PR
Test failures are fixed by removing the respectively failing check.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
The specific checks are ill formed currently, as the testing account is
internally load balanced. Azure Remote Rendering introduced this
recently as the tests created negative customer impact with regards to
session availability. Hence, the tests will not necessarily be served
the exact requested session type. Consequently the check is now
pointless.
### Are there test cases added in this PR? _(If not, why?)_
There isn't any functional change to the SDK in this PR.
### Provide a list of related PRs _(if any)_
N/A
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
N/A
### Checklists
- [x ] Added impacted package name to the issue description
- [x ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [x ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/cosmos
### Issues associated with this PR
### Describe the problem that is addressed by this PR
The default value of continueOnError in bulkRequestOptions has been set
to true.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Aditishree . <adlnu@microsoft.com>
### Packages impacted by this PR
@azure/cosmos
### Issues associated with this PR
N/A
### Describe the problem that is addressed by this PR
This PR updates changelog and release version of SDK from 4.1.0 to
4.1.1.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
N/A
### Are there test cases added in this PR? _(If not, why?)_
N/A
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
There's some change in `typescript-eslint` that breaks some eslint test
cases.
Previously when running tests, in a rule's `create()` method, we get a
relative
path for `context.filename`, and when we pass a setting of `{ main:
"src/test.ts" }` in rule tester option, the two were considered the same
file,
therefore the following condition check failed, and we continue to
report error
for default exports.
6dd8b582e2/common/tools/eslint-plugin-azure-sdk/src/rules/ts-modules-only-named.ts (L31)
After the upgrade, `context.filename` now contains the full path, the
file
`src/test.ts` in our test fixture has a full path of
`/.../common/tools/eslint-plugin-azure-sdk/tests/fixture/src/test.ts`.
It is not
considered the same file as the passed settings implies
`/.../common/tools/eslint-plugin-azure-sdk/src/test.ts` when we run the
tests.
So we return earlier instead of going to check for default exports.
This is not an issue in real scenario where we have settings of `{ main:
"src/index.ts" }`, which would match the full path of the file we are
linting
when we run `eslint` from a package directory.
This PR fixes the test by passing `tests/fixture/src/test.ts` in the
settings so
that it matches the full path of `context.filename` we get in
`create()`.
### Packages impacted by this PR
@azure/microsoft-playwright-testing
### Issues associated with this PR
Minimum playwright version required is 1.47.
### Describe the problem that is addressed by this PR
This PR enforces the >=1.47 playwright version check.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
Yes
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/create-microsoft-playwright-testing
### Issues associated with this PR
None
### Describe the problem that is addressed by this PR
1. Refactor reporter comments in service config file
2. Add list reporter by default
3. Init logs printed to console refactoring
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
None
### Are there test cases added in this PR? _(If not, why?)_
None, existing modified
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/create-microsoft-playwright-testing
@azure/microsoft-playwright-testing
### Issues associated with this PR
1. Missing sample build script
2. Invalid product slugs
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/monitor-opentelemetry
### Issues associated with this PR
#30900
### Describe the problem that is addressed by this PR
Removes the usage of a relative path such that changing the module
location will not break imports.
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [x] Added a changelog (if necessary)
### Packages impacted by this PR
- @azure/cosmos
### Issues associated with this PR
- https://github.com/Azure/azure-sdk-for-js/issues/30914
### Describe the problem that is addressed by this PR
Adds better checks for `process` which is not global in environments
such as Deno/Bun/React-Native and other places. Assumes the environment
variable is false in the browser case.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
- https://github.com/Azure/azure-sdk-for-js/pull/30295
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Manik Khandelwal <113669638+topshot99@users.noreply.github.com>
Co-authored-by: Manik Khandelwal <mkhandelwal@microsoft.com>
- [eslint-plugin] github-source-headers rule should use "MIT License".
This change updates our linter rule and the whole repository to have consistent
license header.
***NO_CI***
- remove "All rights reserved." from header
- "MIT license" => "MIT License"
### Packages impacted by this PR
@azure/keyvault-certificates
### Issues associated with this PR
#30822
### Describe the problem that is addressed by this PR
When migrating keyvault-certificates to ESM and vitest I forgot to port
over the extended timeout needed for these tests
(see [this
diff](58ac994ec5 (diff-238f0a9c86d168f8a93aba09420e13a2cdc1bb6d157e76949a197eacd26774a3L54)))
and noticed that the live tests started failing with a timeout.
This commit adds the timeout back in a command line argument. It also
addresses an issue in our dependency-testing script where min/max tests
were no longer carrying over the timeout from the package json's path in
tests that have migrated to vitest.
Successful run:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4083622&view=results
This PR introduces a new Azure DevOps pipeline that automatically lints
all Bicep files in the repository and generates a report of any linting
warnings. These reports are stored as artifacts and uploaded to Azure
Blob Storage for tracking over time.
### Benefits
- Automated Linting: Ensures that all Bicep files are consistently
checked for best practices and potential issues.
- Historical Tracking: By appending the date to the lint warnings file,
we can monitor progress and improvements over time.
### Next Steps
- Monitor the lint warnings reports over time to identify and address
recurring issues.
- Use the stored reports to guide refactoring efforts and improve Bicep
code quality across the repository.
### Current warnings:
```
WARNING: /home/codespace/window3/sdk/textanalytics/test-resources.bicep(32,34) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/textanalytics/test-resources.bicep(33,38) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/formrecognizer/test-resources.bicep(60,41) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/formrecognizer/test-resources.bicep(61,157) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/formrecognizer/test-resources.bicep(62,155) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/formrecognizer/test-resources.bicep(63,184) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/translation/test-resources.bicep(67,42) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/storage/test-resources.bicep(294,29) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(295,33) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(296,115) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(299,33) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(300,37) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(301,127) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(304,45) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(305,49) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(308,34) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(309,38) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(310,124) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(313,41) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(314,45) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(315,131) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(318,42) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(319,46) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/storage/test-resources.bicep(320,139) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/mixedreality/test-resources.bicep(25,42) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/communication/test-resources/test-resources.bicep(28,49) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/communication/test-resources/test-resources.bicep(29,66) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/communication/test-resources/test-resources.bicep(31,50) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/communication/communication-email/test-resources.bicep(52,49) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/communication/communication-email/test-resources.bicep(53,66) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/communication/communication-email/test-resources.bicep(55,55) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/template/test-resources.bicep(29,45) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/remoterendering/test-resources.bicep(111,49) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/remoterendering/test-resources.bicep(112,57) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/remoterendering/test-resources.bicep(117,47) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/tables/test-resources.bicep(62,29) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/tables/test-resources.bicep(63,31) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/tables/test-resources.bicep(64,133) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAccountSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/tables/test-resources.bicep(65,115) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/eventgrid/test-resources.bicep(139,47) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/cognitivelanguage/test-resources.bicep(153,34) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/cognitivelanguage/test-resources.bicep(154,38) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/eventhub/event-hubs/perf-resources.bicep(5,9) : Warning BCP334: The provided value can have a length as small as 3 and may be too short to assign to a target with a configured minimum length of 6.
/home/codespace/window3/sdk/eventhub/event-hubs/perf-resources.bicep(13,12) : Warning BCP035: The specified "resource" declaration is missing the following required properties: "location". If this is an inaccuracy in the documentation, please report it to the Bicep Team. [https://aka.ms/bicep-type-issues]
/home/codespace/window3/sdk/eventhub/event-hubs/perf-resources.bicep(23,44) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listkeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(11,39) : Warning no-hardcoded-env-urls: Environment URLs should not be hardcoded. Use the environment() function to ensure compatibility across clouds. Found this disallowed host: "core.windows.net" [https://aka.ms/bicep/linter/no-hardcoded-env-urls]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(16,5) : Warning decompiler-cleanup: The name of variable 'eventHubsNamespace_var' appears to have originated from a naming conflict during a decompilation from JSON. Consider renaming it and removing the suffix (using the editor's rename functionality). [https://aka.ms/bicep/linter/decompiler-cleanup]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(19,5) : Warning decompiler-cleanup: The name of variable 'storageAccount_var' appears to have originated from a naming conflict during a decompilation from JSON. Consider renaming it and removing the suffix (using the editor's rename functionality). [https://aka.ms/bicep/linter/decompiler-cleanup]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(22,5) : Warning no-unused-vars: Variable "eventHubsAuthRuleResourceId" is declared but never used. [https://aka.ms/bicep/linter/no-unused-vars]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(26,9) : Warning BCP334: The provided value can have a length as small as 3 and may be too short to assign to a target with a configured minimum length of 6.
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(36,9) : Warning use-parent-property: Resource "eventHubsNamespace_eventHubName" has its name formatted as a child of resource "eventHubsNamespace". The syntax can be simplified by using the parent property. [https://aka.ms/bicep/linter/use-parent-property]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(37,3) : Warning BCP187: The property "location" does not exist in the resource or type definition, although it might still be valid. If this is an inaccuracy in the documentation, please report it to the Bicep Team. [https://aka.ms/bicep-type-issues]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(48,9) : Warning use-parent-property: Resource "eventHubsNamespace_eventHubName_eventHubAuthRuleName" has its name formatted as a child of resource "eventHubsNamespace_eventHubName". The syntax can be simplified by using the parent property. [https://aka.ms/bicep/linter/use-parent-property]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(66,5) : Warning BCP073: The property "tier" is read-only. Expressions cannot be assigned to read-only properties. If this is an inaccuracy in the documentation, please report it to the Bicep Team. [https://aka.ms/bicep-type-issues]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(81,71) : Warning BCP081: Resource type "Microsoft.Authorization/roleAssignments@2019-04-01-preview" does not have types available. Bicep is unable to validate resource properties prior to deployment, but this will not block the resource from being deployed.
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(90,64) : Warning BCP081: Resource type "Microsoft.Authorization/roleAssignments@2019-04-01-preview" does not have types available. Bicep is unable to validate resource properties prior to deployment, but this will not block the resource from being deployed.
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(101,45) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listkeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(104,35) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listkeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(105,129) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(105,156) : Warning BCP241: The "providers" function is deprecated and will be removed in a future release of Bicep. Please add a comment to https://github.com/Azure/bicep/issues/2017 if you believe this will impact your workflow.
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(107,42) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/eventhub/event-hubs/test/stress/stress-test-resources.bicep(107,69) : Warning BCP241: The "providers" function is deprecated and will be removed in a future release of Bicep. Please add a comment to https://github.com/Azure/bicep/issues/2017 if you believe this will impact your workflow.
WARNING: /home/codespace/window3/sdk/servicebus/test-resources.bicep(123,46) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/servicebus/test-resources.bicep(124,54) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/servicebus/test-resources.bicep(131,36) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/servicebus/service-bus/perf-resources.bicep(9,5) : Warning decompiler-cleanup: The name of variable 'authorizationRuleName_var' appears to have originated from a naming conflict during a decompilation from JSON. Consider renaming it and removing the suffix (using the editor's rename functionality). [https://aka.ms/bicep/linter/decompiler-cleanup]
/home/codespace/window3/sdk/servicebus/service-bus/perf-resources.bicep(38,46) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/servicebus/service-bus/test/stress/stress-test-resources.bicep(9,5) : Warning decompiler-cleanup: The name of variable 'authorizationRuleName_var' appears to have originated from a naming conflict during a decompilation from JSON. Consider renaming it and removing the suffix (using the editor's rename functionality). [https://aka.ms/bicep/linter/decompiler-cleanup]
/home/codespace/window3/sdk/servicebus/service-bus/test/stress/stress-test-resources.bicep(38,46) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/web-pubsub/test-resources.bicep(57,39) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/web-pubsub/test-resources.bicep(58,29) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/web-pubsub/test-resources.bicep(59,42) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/web-pubsub/test-resources.bicep(60,56) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/search/test-resources.bicep(19,38) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAdminKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/search/test-resources.bicep(20,42) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listAdminKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/maps/test-resources.bicep(43,39) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/documentintelligence/test-resources.bicep(64,47) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listKeys' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/documentintelligence/test-resources.bicep(65,168) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/documentintelligence/test-resources.bicep(66,161) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/documentintelligence/test-resources.bicep(67,187) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/documentintelligence/test-resources.bicep(68,189) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/documentintelligence/test-resources.bicep(69,179) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
/home/codespace/window3/sdk/documentintelligence/test-resources.bicep(70,186) : Warning outputs-should-not-contain-secrets: Outputs should not contain secrets. Found possible secret: function 'listServiceSas' [https://aka.ms/bicep/linter/outputs-should-not-contain-secrets]
WARNING: /home/codespace/window3/sdk/healthdataaiservices/azure-health-deidentification/test-resources.bicep(21,7) : Warning no-unused-params: Parameter "deploymentTime" is declared but never used. [https://aka.ms/bicep/linter/no-unused-params]
/home/codespace/window3/sdk/healthdataaiservices/azure-health-deidentification/test-resources.bicep(32,9) : Warning BCP334: The provided value can have a length as small as 0 and may be too short to assign to a target with a configured minimum length of 3.
/home/codespace/window3/sdk/healthdataaiservices/azure-health-deidentification/test-resources.bicep(168,26) : Warning BCP081: Resource type "microsoft.healthdataaiservices/deidservices@2024-02-28-preview" does not have types available. Bicep is unable to validate resource properties prior to deployment, but this will not block the resource from being deployed.
```
---------
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
In our current setup, tshy won't build test and samples-dev folder even
they are
included in tsconfig.json. This PR adds a command that does the
type-checking
for all files included in tsconfig.json, and allow additional files to
be passed
in as well.
to be consistent with `eslint` version.
Also removed the eslint plugin helper. It was added to help
vscode-eslint
extension to resolve plugin packages. With flat config it is no longer
needed.
Moving to a modular bicep definition so that we can share bits and
pieces between all of them. This PR factors out the key vault definition
so other bicep scripts can import it too. For now, it lives next to the
event hub's test-resources.bicep script but I'll consider moving it to a
central place once other libraries move to import it.
The PR also edits the script to make it more compact.
Live tests run:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4079360&view=results
Azure SDK Bot
Pratik Sharma
Haopeng Wang
Wes Haggard
Kashish Gupta
Siddharth Singha Roy
Jeremy Meng
Julian Meder
Albert Cheng
ZiWei Chen
aditishree1
Manik Khandelwal
Jackson Weber
Matthew Podwysocki
Deyaaeldeen Almahallawi
KarishmaGhiya
Jeremy Meng
Maor Leger