- add dep to `uglify-js` in dev-tool
- rush update
- replace "uglifyjs" with "dev-tool run vendored yglifyjs"
- remove dependency to "uglifyjs" in sdk packages
***NO_CI***
also remove dependency on `@microsoft/api-extractor` as we already move to
`dev-tool run extract-api` which calls api-extractor Api instead.
***NO_CI***
***NO_CI***
- replace version to "~5.6.2"
- rush update
- add `"skipLibCheck": true` for several packages that are affected by https://github.com/vitest-dev/vitest/issues/4688
- [formrecognizer] help TypeScript to understand with more explicit type
- [schema-registry-{avro,json}] skip lib check due to lru-cache issue with the Iterator TReturn change
https://github.com/isaacs/node-lru-cache/issues/348
- [eslint-plugin] github-source-headers rule should use "MIT License".
This change updates our linter rule and the whole repository to have consistent
license header.
***NO_CI***
- remove "All rights reserved." from header
- "MIT license" => "MIT License"
Previously dev-tool has been fixed to generate correct include path in samples
tsconfig.json but samples were not updated.
This PR fixes the samples tsconfig.json in one run; otherwise with the recent
branch protection policy changes, when individual packages re-publish samples,
js-core team would have to approve the tsconfig.json changes.
***NO_CI***
### Packages impacted by this PR
`@azure/cognitiveservices-face`
`@azure/cognitiveservices-computervision`
`@azure/cognitiveservices-contentmoderator`
`@azure/cognitiveservices-customvision-prediction`
`@azure/cognitiveservices-customvision-training`
`@azure/cognitiveservices-personalizer`
`@azure/cognitiveservices-translatortext`
### Describe the problem that is addressed by this PR
These are old track1 packages that haven't been built or maintained in
years. They're not managed by Rush, nor do they use the common core.
This change migrates every package to the latest major version of
identity in order to ensure we can catch any regressions earlier in the
development process.
I chose to upgrade the samples' package.json as well - but happy to
revert that if there are objections.
***NO_CI***
Our tests use the type `Mocha.Context` when they need to pass the test context
to test recorder. However, without a dev dependency on `@types/mocha`
compilation may fail when recorder constructor is changed from taking a
`Mocha.Test` to taking an interface that is compatible.
This change ensures the dev depedency on `@types/mocha` too if there's a dev
dependency on `mocha`.
***NO_CI***
***NO_CI***
- update engine.node to >=16.0.0 in package.json
- update @types/node version to ^16.0.0
- update dev-tool sample's MIN_SUPPORTED_NODE_VERSION to 16
- update eslint-plugin's rules and tests related to engine.node version
- remove TextEncoder and TextDecoder stubs as they are now on global object
- fix tests compiler error due to better typings in v16
- update some README files to not reference version like 14.x.x
- along with it, `@types/mocha` version to `^10.0.0`
- add `esm` dev dependency as they are used, but not explicitly list
- use dev-tool run command for test scripts as much as possible
- fix test issue caused by Mocha behavior change around test name
- move `import "chai/register-should"` to mocha -r command line option for core
http tests
***NO_CI***
***NO_CI***
Most of our packages, if not all, have dev dependency on `ts-node` either
directly (`mocha --require ts-node/register`) or indirectly via dev-tool (`run
test:node-ts-input`). Currently tests are running fine because mocha is able to
resolve ts-node currently. It may fail in other cases though (e.g., after
migrating a package to ESM).
This ensures `ts-node@^10.0.0` and `types/node` are included for our rush
packages.
### Packages impacted by this PR
`@azure/cognitiveservices-luis-authoring`
`@azure/cognitiveservices-luis-runtime`
`@azure/cognitiveservices-qnamaker`
`@azure/cognitiveservices-qnamaker-runtime`
### Issues associated with this PR
https://github.com/Azure/azure-sdk-for-js/issues/25726
### Describe the problem that is addressed by this PR
Removing deprecated packages for services that are in the process of
being decommissioned and their workloads migrated to other services.
### Packages impacted by this PR
`@azure/cognitiveservices-textanalytics`
`@azure/cognitiveservices-formrecognizer`
`@azure/cognitiveservices-anomalydetector`
### Issues associated with this PR
https://github.com/Azure/azure-sdk-for-js/issues/25726
### Describe the problem that is addressed by this PR
All three of these packages have track 2 packages that supersede them.
### Packages impacted by this PR
`@azure/cognitiveservices-autosuggest`
`@azure/cognitiveservices-customsearch`
`@azure/cognitiveservices-customimagesearch`
`@azure/cognitiveservices-entitysearch`
`@azure/cognitiveservices-imagesearch`
`@azure/cognitiveservices-newssearch`
`@azure/cognitiveservices-localsearch`
`@azure/cognitiveservices-spellcheck`
`@azure/cognitiveservices-videosearch`
`@azure/cognitiveservices-visualsearch`
`@azure/cognitiveservices-websearch`
### Issues associated with this PR
https://github.com/Azure/azure-sdk-for-js/issues/25726
### Describe the problem that is addressed by this PR
These APIs were migrated from Cognitive into Bing Search.
***NO_CI***
- `@rollup/plugin-commonjs` to `^24.0.0`
- `@rollup/plugin-json` to `^6.0.0`
- `@rollup/plugin-multi-entry` to `^6.0.0`
- `rollup-plugin-polyfill-node` to `^0.12.0`
- `@rollup/plugin-inject` to `^5.0.0`
- `@rollup/plugin-replace` to `^5.0.0`
Fix notification-hubs rollup test config: now sourcemaps plugin is complaining
about .ts file. Move typescript plugin before it.
Fix service-bus to include needed rollup dependencies. It was lucky to be able
to re-use on other packages to install them but is failing in some builds.
### Packages impacted by this PR
`sdk\cognitiveservices\cognitiveservices-luis-runtime`
### Issues associated with this PR
#13005
### Describe the problem that is addressed by this PR
The existing mocha tests for the
`sdk\cognitiveservices\cognitiveservices-luis-runtime` made use of the
arrow syntax for callback functions. Mocha recommends not to do this
because you lose access to the mocha context
(https://mochajs.org/#arrow-functions).
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
The reason for utilizing the function keyword instead of an arrow syntax
to write the callback functions in these mocha tests is to maintain
access to the mocha context.
### Are there test cases added in this PR? _(If not, why?)_
No additional test cases were added in this PR as the change only
required modifying existing test cases.
### Provide a list of related PRs _(if any)_
#23761 - Same fix, but for the `sdk\search\search-documents` package
#23789 - Same fix but for the `sdk\attestation\attestation` package
#23835 - Same fix but for the `sdk\batch\batch` package
#23850 - Same fix but for the
`sdk\cognitivelanguage\ai-language-conversations` package
#23881 - Same fix but for the
`sdk\cognitiveservices\cognitiveservices-luis-authoring`
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
**_Not applicable_**
### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- **_I don't believe this is relevant._**
- [ ] Added a changelog (if necessary)
- **_I don't believe this is necessary_**
***NO_CI***
- string replace in package json: 12 => 14 for engines/node and for dependency @types/node
- eslint: update `json-engine-is-present` rule to 14.0.0 as LTS version
- identity: react to typing improvements for `readFile()`'s `options.encoding`
- trivial generated api.md file changes due to @types/node version bump
Jeremy Meng
Matthew Podwysocki
ZiWei Chen
Jeremy Meng
Maor Leger
Jeff Fisher
Maor Leger
Deyaaeldeen Almahallawi
Mary Gao
Azure SDK Bot
Stevan Freeborn
Dina Berry (personal)