### Packages impacted by this PR
### Issues associated with this PR
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: Asaf Levi <asaflevi@microsoft.com>
Co-authored-by: KarolGel <138193722+KarolGel@users.noreply.github.com>
Co-authored-by: tomsft <138026577+tomsft@users.noreply.github.com>
Co-authored-by: Karolien Gellynck <kgellynck@microsoft.com>
Co-authored-by: Tom Deray <tomderay@microsoft.com>
### Packages impacted by this PR
### Issues associated with this PR
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
### Issues associated with this PR
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
### Issues associated with this PR
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/app-configuration
### Issues associated with this PR
### Describe the problem that is addressed by this PR
Run prepare release script with the correct version
### Packages impacted by this PR
@azure/identity
### Issues associated with this PR
Resolves#28679
### Describe the problem that is addressed by this PR
When migrating plugin support to MSALClient I noticed that
msalNodeCommon defines all the plugin declarations. To avoid
duplication, provide an easy path to migrate (by avoiding imports
on msalNodeCommon) and provide a single source of truth for plugin
settings it made sense to migrate all the definitions to a single file.
This is purely mechanical, just moving things around and updating
imports
### Provide a list of related PRs _(if any)_
#28493
Automation failed to increment package version due to the prepush hook
not working on CI. This PR runs the same script and increments the package
version for @azure/identity-cache-persistence after release.
Adds two new features to the App config SDK
- [x] Support etags in the list by page method
- [ ] ~~Tags filter for the listing methods~~ (Wait on service)
- [x] Tests/recordings
- [x] Changelog
---------
Co-authored-by: Minh-Anh Phan <minhanhphan@microsoft.com>
### Packages impacted by this PR
`dev-tool`
### Issues associated with this PR
Fixes#28763
### Describe the problem that is addressed by this PR
From their CHANGELOG.md entry, the only "breaking" change is removal of
Node 12 support, so this is a simple bump.
### Packages impacted by this PR
- All
### Issues associated with this PR
### Describe the problem that is addressed by this PR
Removes the git hooks for now so that we do not block our workflows with
automation.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/core-amqp
### Issues associated with this PR
N/A
### Describe the problem that is addressed by this PR
The errors thrown between retries could differ and the customer wouldn't
be able to know them unless they enable logging.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
Another design is to provide an error handler callback to be called on
all errors but since it is an extreme measure, we can revisit this
latter if we get an ask for it.
### Are there test cases added in this PR? _(If not, why?)_
N/A
### Provide a list of related PRs _(if any)_
N/A
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [x] Added a changelog (if necessary)
---------
Co-authored-by: Jeff Fisher <jeffish@microsoft.com>
The Pre Push script has some scenarios which is causing issues to
developers. I am working on resolving these issues. But, In the mean
time, there must be an easy way for the developers to push their commits
to github,
As discussed with @xirzec, I am adding an environment variable to skip
these checks.
### Packages impacted by this PR
- @azure-rest/ai-document-intelligence
### Issues associated with this PR
### Describe the problem that is addressed by this PR
Removes the ESM module and updates to ES2020
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
### Issues associated with this PR
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
---------
Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: Mary Gao <yanmeigao1210@gmail.com>
This PR is not related to any specific package. It is related to the fix
in the pre-push script. In the previous version of the script, there
were 2 issues reported:
1. Script was slow
2. There was a error in the line `err = error.stdout.toString();`.
The second issue is simple and straightforward. There was a missing
check. Once, it is added, the issue is resolved. The first issue is
little tricky.
I always assumed the new packages will be created from the `main` branch
in the `Azure` fork. Based on my recent conversations, it does not seem
to be valid. Some people (based on our project documentation) create the
branch from the `main` branch in their respective fork. (They do sync
their `main` branch with the `Azure` fork frequently. But, this is not
mandatory which causes the problem).As a result, sometimes I see the
difference in about 300+ commits to be validated which causes excess
time.
Now, I have fixed the issue with adding a new remote specific to prepush
tool and using that for comparison. This will reduce the number of
commits significantly which has increased the speed.
@HarshaNalluru Please approve the PR
### Packages impacted by this PR
@azure/identity
### Issues associated with this PR
N/A - nightly tests
### Describe the problem that is addressed by this PR
Two issues are addressed in this PR:
When I added the live tests for MSAL Client via #28680 I did not realize
Identity differs from other packages
in the env vars we use. In Identity, as shown in other live tests, we
use `IDENTITY_SP_CLIENT_SECRET`,
`IDENTITY_SP_TENANT_ID`, and `IDENTITY_SP_CLIENT_ID` instead of the
usual `AZURE_` naming convention.
Not sure why that is, but I'm sure there's a reason. Using these env
vars fixes the live test.
The second fixes an issue with our existing mocking solution that no
longer plays nicely with core. When
core was switched to ESM, our integration tests started failing because
`http` and `https` are no longer being correctly mocked
[here](https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/identity/identity/test/httpRequests.ts#L191-L192)
I have some suspicions but given that we're soon moving to ESM, Karishma
and I decided to forgo the `js-input` style integration tests and use `ts-input` style tests
instead until we migrate over.
### Packages impacted by this PR
@azure/openai-assistants
### Issues associated with this PR
### Describe the problem that is addressed by this PR
Fixes date issue in src
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ x] Added a changelog (if necessary)
This reverts commit 91df305c67.
### Issues associated with this PR
Fixes#28737
### Describe the problem that is addressed by this PR
Revert the pre-push hook until we can test it a bit more.
### Packages impacted by this PR
@azure/identity
### Issues associated with this PR
Resolves#28692
### Describe the problem that is addressed by this PR
Before we start adding features to MSAL Client, we need to have
confidence that our stack and integration
with MSAL is properly setup.
This PR adds a place for recorded tests, removes the msalNodeTestSetup
call from non-recorded tests,
and moves the "it supports clientSecretCredential" test to a recorded
test
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
We could have pushed for _everything_ to be recorded, but some of the
niche scenarios we setup are convoluted
to test without mocking anyway. This moves us in the direction we want
without over-complicating things
Preparing release for @azure/notification-hubs v1.1.0
Features Added:
- Added Support for [Firebase Cloud Messaging
(FCM)](https://firebase.google.com/docs/cloud-messaging) V1 API with the
following:
- `FcmV1RegistrationDescription` and
`FcmV1TemplateRegistrationDescription` for registrations with associated
factory methods.
- `FcmV1Installation` for installation operations and associated factory
methods.
- `FcmV1Notification` for notification send support and associated
factory methods.
### Packages impacted by this PR
### Issues associated with this PR
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
In order to aid with autotriage, we have to set some additional metadata
inside of CODEOWNERS.
The main shift is we need to tag things with #ServiceLabel in order to
have issues be triaged appropriately. Secondarily, for SDKs that are
owned by the SDK team (anyone under Peter) we need to add an
AzureSdkOwners entry even if it's redundant with the path ownership.
Related PRs from other languages:
https://github.com/Azure/azure-sdk-for-net/pull/41995https://github.com/Azure/azure-sdk-for-java/pull/38797
I didn't touch Mgmt paths, will check with @lirenhe if this is something
he can take care of.
While I was making changes, I cleaned up some errors that GitHub was
complaining about when viewing the file.
### Packages impacted by this PR
None
### Describe the problem that is addressed by this PR
Our friendly CI linkchecker noticed that the GPL link in contributing.md
was broken, so I updated the links to opensource.org. Other license
links were still active, but were being redirected, so I updated those
as well.
### Packages impacted by this PR
@azure/identity
### Issues associated with this PR
Fixes https://github.com/Azure/azure-sdk-for-js/issues/28511
### Describe the problem that is addressed by this PR
Begin using the new, human-readable scope
(https://redis.azure.com/.default) in the ioredis & node-redis
passwordless code samples for Redis.
### Provide a list of related PRs _(if any)_
https://github.com/Azure/azure-sdk-for-java/pull/38747/files
### Checklists
- [x] Added impacted package name to the issue description
- [x] Added a changelog (if necessary)
---------
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
koen-mertens
Tianen
Rajarshi Sarkar
Arif Ibrahim Mohamed
Azure SDK Bot
Minh-Anh Phan
Maor Leger
Deyaaeldeen Almahallawi
Harsha Nalluru
Jeff Fisher
Matthew Podwysocki
Sarangan Rajamanickam
Yifan Zhou
Glenn Harper
ZiWei Chen
Azee
Daniel Getu
KarishmaGhiya