Граф коммитов

1302 Коммитов

Автор SHA1 Сообщение Дата
praveenkuttappan d17c878e13
APIStubGen skips public classes defined in internal modules (#1480)
* Include all module members in root package namespace
2021-03-11 06:19:53 -08:00
Heath Stewart f1c5a2ab67
Sort changelogs by date then version (#1479)
Fixes #1389
2021-03-10 19:59:22 +00:00
Mitch Denny 0a0b8724f3
Use latest pipeline generator (#1475)
Pipeline Generator has been updated to support generating CI triggers for public pipelines. This PR moves the version of pipeline generator we use to this new version. This will impact the scheduled pipeline generation job, as well as the single generation job and the prepare pipelines jobs.
2021-03-09 23:43:47 +00:00
Ben Broderick Phillips 0e24ca516a
Use sparse checkout for generate matrix job (#1452)
From a functional standpoint, the generate matrix job only takes a few seconds to run. Depending on the repository, the job can take a total time of 4 minutes before the test jobs are able to start, because azure pipelines does a clone of the entire repository (among other things). This PR makes a change to skip the azure pipelines checkout step, and add a lightweight git clone along with a sparse checkout of just the `eng` and service directory locations (which contain the matrix scripts and/or matrix configs).

This change reduces the total job runtime to around 20 seconds from 4 minutes (repo checkouts + auto-injected policy steps).
2021-03-09 02:14:45 +00:00
Mitch Denny 1a5b4774f6
Add CI trigger back to pipeline generator (#1410)
* Add CI trigger back to pipeline generator
2021-03-09 11:38:19 +11:00
Chidozie Ononiwu deddf161fb
Move SetTestPipeline into its own template (#1472)
Create `set-test-pipeline-version.yml`
2021-03-06 01:22:06 +00:00
praveenkuttappan 428da88b89
Update java parser version to rebuild existing reviews (#1469)
* Update java parser version to rebuild existing reviews
* Update parser version in deployment artifcat
2021-03-05 14:42:40 -08:00
Chidozie Ononiwu d8addb772b
Fix logic in SetTestPipelineVersionInEngCommon (#1470)
Fixing up errors in `SetTestPipelineVersion.ps1`
2021-03-05 21:53:36 +00:00
Ben Broderick Phillips c9b5add182
Fix bug where imported matrix parameter duplicates are not overrided (#1461)
When importing a matrix from another matrix, the intended behavior is that any duplicate parameter keys favor the value in the matrix doing the import. This PR fixes a bug where this did not happen (instead the imported matrix's value is favored).
2021-03-05 21:00:55 +00:00
praveenkuttappan d417685918
Disable maven dependency properties from API review temporarily (#1468) 2021-03-05 11:16:13 -08:00
praveenkuttappan 1f41cb4782
Added more logging to API view create (#1448)
Updated logging in create review step
2021-03-05 14:47:46 +00:00
praveenkuttappan 3f7ec1b503
Enable APIView status check (#1465)
Change API status check as hard error
2021-03-05 11:12:52 +00:00
Chidozie Ononiwu b11e017fc3
Fix PackageName typo (#1467) 2021-03-05 04:41:45 +00:00
Chidozie Ononiwu 15b968b8a0
Move SetTestPipelineVersion.ps1 to eng/common (#1459)
Move SetTestPipelineVersion.ps1 to eng/common.
2021-03-05 02:44:19 +00:00
Wes Haggard 5fdc593da6
Import global variables from mgmt pipeline (#1460)
* Import global variables from mgmt pipeline
* Switch .NET tasks
* Update MS.Az.Mgmt.CI.BuildTasks.csproj
2021-03-04 09:08:22 -08:00
Chidozie Ononiwu b77782153e
Fix language short typo (#1456)
Fix typo in variable name
2021-03-03 20:31:58 +00:00
Jonathan Giles e908a962cf
Fix issue that prevents apiview automatic workflow for Java (#1455)
* Small fix that validates for leaking implementation code if the parameter string is fully-qualified

* Don't include the maven parent or maven properties to avoid diff issues in apiview auto API workflow
2021-03-03 10:25:07 -08:00
Christopher Scott 8339ed75d4
AZC0011 allows Perf assemblies (#1457)
* AZC0011 allows Perf assemblies
* update Microsoft.CodeAnalysis.CSharp.Analyzer.Testing.XUnit version
2021-03-03 10:57:38 -06:00
Minghao Chen fc6720c981
Update AutoRestCodeGenerationModule.psm1 (#1453) 2021-03-02 16:00:33 -08:00
praveenkuttappan 4db3347656
Auto update all reviews in the background after parser is updated (#1450)
* Auto update all reviews in the background after parser is updated

* Updated query as per review suggestion

* Simplified cosmos query
2021-03-01 17:14:43 -08:00
Wes Haggard 1265e07d08
Update Prepare-Release script (#1447)
- Remove BuildType parameter as we can default it from package properties
- Stop passing BuildType and GroupId and instead defaul them from package properties
- Enable StrictMode to help identify potential errors
- Start passing sdktype and isnewsdk properties to devops script
- Sync latest changes with devops work item to fix a couple bugs


Once https://github.com/Azure/azure-sdk-for-java/pull/19495 is merged and we merge this change the buildtype and groupid for java will come from the package properties.
2021-02-27 02:47:21 +00:00
praveenkuttappan 9148ed8a15
Add background process to update reviews (#1441)
* Changes to run background task to update reviews
2021-02-24 11:28:20 -08:00
Daniel Jurek 1bced20495
Add spell check tools to eng/common (#1421)
See example run in Embedded C repo -- https://dev.azure.com/azure-sdk/public/_build/results?buildId=739511&view=logs&j=a129effc-2dd1-54d1-fb5a-ad7bdc0e851d&t=7b4713e3-e110-5049-e231-cc8a1e664c68

Logs: 
![image](https://user-images.githubusercontent.com/2158838/108313470-418bff80-716d-11eb-9879-d0faecc965fc.png)

Pipeline warnings: 
![image](https://user-images.githubusercontent.com/2158838/108313518-4ea8ee80-716d-11eb-83c0-6ba3238b4c2a.png)

check-spelling.yml 
 * Runs only on PRs 
 * Fetches the "base" ref (usually the `master` branch) of the PR.. this takes some work as the git config in DevOps is not set to match branch names the way a typical `git clone` would 
 * Runs `Test-Spelling.ps1` 
 * Needs to be wired into a build job

Test-Spelling.ps1 is designed to run on a dev box as well as in DevOps. It will advise if there are errors. 

I would have preferred to put `cspell.json` in the `eng/` folder in each repo. However the [configuration in the vcsode plugin](https://github.com/streetsidesoftware/vscode-spell-checker/blob/master/packages/client/README.md#customization) searches only in the root of the repo, the `.vscode` folder, or specific preferences set in `.vscode/settings.json` (or at a user level). If we want to keep the root of the repo less cluttered then it makes sense to put `cspell.json` into `.vscode` (see [demo PR](https://github.com/Azure/azure-sdk-for-c/pull/1610/files#diff-d9f1a54e1f1a4c8324f4756f08a6af27671a3ae9312190d4a5fe981cc1722824)). 

Of note: there are [notes in the vscode extension repo ](https://github.com/streetsidesoftware/vscode-spell-checker/blob/master/packages/client/docs/settings.md) about possibly using a `cspell.configLocation` setting but that functionality does not yet exist.
2021-02-23 06:17:14 +00:00
Ben Broderick Phillips d4b9011ee1
Restore pipeline output variable for Agent OS name (#1428) 2021-02-22 16:48:36 -05:00
praveenkuttappan f3f3c353c9
Retain file name and handle older reviews without file name when upda… (#1438)
* Retain file name and handle older reviews without file name when updating review
2021-02-22 11:03:07 -08:00
Ben Broderick Phillips ccb6ead4f8
Update pipeline generator version to include weekly convention name fix (#1436)
Updating the pipeline install tool to use the version published for https://github.com/Azure/azure-sdk-tools/pull/1435
2021-02-19 23:28:20 +00:00
Ben Broderick Phillips c770daa2a6
Add job matrix generation scripts (#1429)
This PR is a port of functionality that is currently duplicated across the net/java/python repositories. The intent was to settle on an implementation before moving it to the /eng/common/scripts directory. After merge to this location, I'll update the net/java/python and js repos to point to the `eng/common/scripts` location and remove the scripts from `eng/scripts`.

Here is the PR text used against the other repos for reference:

This adds scripts, docs and samples supporting dynamic, cross-product matrix generation for azure pipeline jobs.
It aims to replicate the [cross-product matrix functionality in github actions](https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#example-running-with-more-than-one-version-of-nodejs),
but also adds some additional features like sparse matrix generation, cross-product includes and excludes, parameter grouping and matrix filters.

This functionality is made possible by the ability for the azure pipelines yaml to take a [dynamic variable as an input
for a job matrix definition](https://docs.microsoft.com/en-us/azure/devops/pipelines/process/phases?view=azure-devops&tabs=yaml#multi-job-configuration) (see the code sample at the bottom of the linked section).

See the README.md file for more details on the config file syntax and usage, as well as implementation details.

The tests (`test-matrix-functions.tests.ps1`) contain a lot of detail on expected data structures at various processing stages. The `-`test-matrix-functions.ps1` file could perhaps be split up or use some more organization, so let me know if it's hard to navigate.

Example:
```
{
  "displayNames": {
    "true": "TestFromSource"
  },
  "matrix": {
    "Agent": {
      "ubuntu-18.04": { "OSVmImage": "MMSUbuntu18.04", "Pool": "azsdk-pool-mms-ubuntu-1804-general" },
      "windows-2019": { "OSVmImage": "MMS2019", "Pool": "azsdk-pool-mms-win-2019-general" },
      "macOS-10.15": { "OSVmImage": "macOS-10.15", "Pool": "Azure Pipelines" }
    },
    "JavaTestVersion": [ "1.8", "1.11" ],
    "AZURE_TEST_HTTP_CLIENTS": [ "okhttp", "netty" ]
  },
  "include": [
    {
      "Agent": {
          "ubuntu-18.04": { "OSVmImage": "MMSUbuntu18.04", "Pool": "azsdk-pool-mms-ubuntu-1804-general" }
      },
      "JavaTestVersion": "1.11",
      "AZURE_TEST_HTTP_CLIENTS": "netty",
      "TestFromSource": true
    }
  ]
}
```

Sparse matrix job generation in a pipeline: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=705622&view=results

![image](https://user-images.githubusercontent.com/1020379/106040177-151e1f80-60a8-11eb-823c-2af96b5e84aa.png)

Related discussion: https://github.com/microsoft/azure-pipelines-yaml/issues/20
2021-02-19 22:52:45 +00:00
Ben Broderick Phillips 0367c147c0
Fix non-variant default name for tests-weekly (#1435) 2021-02-19 16:56:21 -05:00
Sima Zhu fe0e62fbc1
Trim off the target branch (#1425)
CI build:
![image](https://user-images.githubusercontent.com/48036328/108540936-af801600-7296-11eb-8709-c0da56480300.png)
PR validation:
![image](https://user-images.githubusercontent.com/48036328/108540959-b9a21480-7296-11eb-81f4-3672b3265375.png)

PR: 
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=740901&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=bdeefc16-b669-5ebd-ad94-a2c19ade53b0
2021-02-19 20:03:28 +00:00
Chidozie Ononiwu 4e68043628
Only run eng/common check when target branch is master (#1415)
Only run eng/common check when target branch is master
2021-02-19 19:08:58 +00:00
Mitch Denny 3e70f4a842
Disable NuGet sec analysis error. (#1422)
* Disable NuGet sec analysis error.
2021-02-19 14:13:29 +11:00
Sima Zhu dc4c60f13c
Change other version to all versions (#1396)
![image](https://user-images.githubusercontent.com/48036328/108280990-d114bc80-7133-11eb-88e5-6ea1e4aeca42.png)
2021-02-18 19:56:02 +00:00
Srikanta 96adb5f722
Ignore warning for com.azure.core module (#1420) 2021-02-18 11:20:30 -08:00
Jonathan Giles 8463b4ce97
Apiview maven simplifications (#1419)
Simplifying the maven output in APIView
2021-02-18 19:02:55 +13:00
praveenkuttappan 97cc3c34f2
Approve automatic reviews if approved manual review matches (#1411)
* Approve automatic reviews if approved manual review matches
2021-02-17 16:30:16 -08:00
Jonathan Giles 3319c81946
Fix for NPE in APIView for Java libraries that lack maven pom information (#1417) 2021-02-18 13:15:59 +13:00
Jonathan Giles 4ad6da6c2d
[APIView] Java - don't create multiple 'compile scope' sections (#1412) 2021-02-17 19:49:50 +13:00
praveenkuttappan 405b6ae8a2
Create package property file using artifact name (#1374)
* Create package property file using artifact name

* Add option to pass config file dir

* Set default config file directory to avoid script execution failure
2021-02-16 13:29:25 -08:00
Jonathan Giles 6d5e18ab1c
[APIView] add support for displaying important maven details (#1406) 2021-02-16 11:51:33 +13:00
Mitch Denny e261199868
Rework verify agent OS step. (#1371)
This PR reworks the verify agent OS logic so that the agent pool and image are passed into a PowerShell script, and then is checked against a list of valid configuration entries.
2021-02-14 23:57:13 +00:00
Heath Stewart 345a610e78
Improve TestResources docs and logging (#1408)
Resolves #1388
Resolves #1407

Also ignores cached service principal if it no longer exists. I ran into this while testing since I cleaned up old SPs.
2021-02-13 03:08:51 +00:00
Heath Stewart fb8d805259
Allow logging into specific subscription (#1405)
Resolves #1404
2021-02-12 22:26:22 +00:00
Chidozie Ononiwu b11ee82944
Update eng-common-workflow-enforcer (#1401)
Fix error in eng-common-workflow-enforcer
2021-02-12 19:42:25 +00:00
Daniel Jurek fce6d94ace
Add vcpkg fork to sync (#1395) 2021-02-12 10:55:22 -08:00
Chidozie Ononiwu e05045c2bd
Change script parameters to Boolean (#1307)
Change Update-ChangeLog.ps1Parameters to used Boolean.
2021-02-11 21:45:19 +00:00
Wes Haggard 6d37f1a42c
Enable passing devops pat for work item scripts (#1386) 2021-02-11 13:21:02 -08:00
Chidozie Ononiwu f703e4e08f
Revert "Update repo parameter for eng/common sync (#1372)" (#1400)
This reverts commit ba881c416d.
2021-02-11 12:34:23 -08:00
Chidozie Ononiwu d5eb1ba220
Revert "Update repos sub parameters (#1398)" (#1399)
This reverts commit c4243ba362.
2021-02-11 12:12:12 -08:00
Chidozie Ononiwu c4243ba362
Update repos sub parameters (#1398) 2021-02-11 11:36:48 -08:00
Chidozie Ononiwu 3490c23553
Add eng/common break check (#1358)
* Extend Get-GitHubPullRequest to return only files

* Add check to prevent eng/common changes that are not proper syncs

* Update eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

* Update eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
2021-02-11 10:13:57 -08:00