4 Code Review Check List

bganapa редактировал(а) эту страницу 2022-03-28 16:12:05 -07:00

• Mark the AzureStack Update Release as part of the PR Title like [2204]
• Look for approved powershell verb usages

1. PUT calls should use Set-* or New-*
2. PATCH calls should use Update-*
3. DELETE calls should use Remove-*
4. Post calls generally should use Invoke-*, other approved verbs like Stop/Start may be used

• Look for cmdlet prefixes, In General the RP name is preferred as part of the prefix. For Example Get-AzsComputeFeature instead of Get-AzsFeature
• Ensure Module dependency on Az.Accounts and Az.Resources
• Ensure every cmdlet of the module have associated Pester Tests
• Ensure that Examples and Docs are updated
• Ensure that module version is updated for changes and also update the module version references under AzureStack module https://github.com/Azure/azurestack-powershell/blob/dev/src/AzureStack/
• Ensure that the ChangeLog.md is updated