Ensure that all packlets have consistent versions (#732)

2021-08-31 15:01:23 -07:00 · 2021-08-31 15:01:23 -07:00 · 27624cdcd3
--- a/.github/workflows/alpha-release.yml
+++ b/.github/workflows/alpha-release.yml
@ -52,6 +52,10 @@ jobs:
      - name: Test @azure/communication-react package
        run: rush test -t @azure/communication-react

+      # Important to check version consistency again after bumping versions.
+      - name: Ensure all package versions are consistent
+        run: rush ensure-consistent-versions
+
      # Retrieve new version to tag and publish release with
      - name: Retrieve new version from package.json
        id: version
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@ -62,6 +62,8 @@ jobs:
      # Tree-shaking check
      - name: Treeshaking check
        run: rush build --only @internal/check-treeshaking
+      - name: Ensure all package versions are consistent
+        run: rush ensure-consistent-versions
      # Tests
      - name: Test Packages
        run: rush test -t @azure/communication-react
--- a/.github/workflows/create-release-branch.yml
+++ b/.github/workflows/create-release-branch.yml
@ -54,6 +54,10 @@ jobs:
      - name: Bump package versions
        run: node common/config/node_modules/beachball/bin/beachball bump

+      # Important to check version consistency again after bumping versions.
+      - name: Ensure all package versions are consistent
+        run: rush ensure-consistent-versions
+
      # Retrieve new version to create branch with
      - name: Retrieve new version from package.json
        id: version
--- a/.github/workflows/nightly-ci.yml
+++ b/.github/workflows/nightly-ci.yml
@ -97,6 +97,10 @@ jobs:
      - name: Test @azure/communication-react package
        run: rush test -t @azure/communication-react

+      # Important to check version consistency again after bumping versions.
+      - name: Ensure all package versions are consistent
+        run: rush ensure-consistent-versions
+
      # Retrieve new version to tag and publish release with
      - name: Retrieve new version from package.json
        id: version
--- a/change/@internal-acs-ui-common-41e70d4f-0c74-45bb-909d-9ba94c5e0192.json
+++ b/change/@internal-acs-ui-common-41e70d4f-0c74-45bb-909d-9ba94c5e0192.json
@ -0,0 +1,7 @@
+{
+  "type": "prerelease",
+  "comment": "Bump version to match other packlets",
+  "packageName": "@internal/acs-ui-common",
+  "email": "82062616+prprabhu-ms@users.noreply.github.com",
+  "dependentChangeType": "patch"
+}
--- a/change/@internal-calling-component-bindings-cc42a1c8-78ec-4828-bebc-f72defc1ec63.json
+++ b/change/@internal-calling-component-bindings-cc42a1c8-78ec-4828-bebc-f72defc1ec63.json
@ -0,0 +1,7 @@
+{
+  "type": "prerelease",
+  "comment": "Bump acs-ui-common dep",
+  "packageName": "@internal/calling-component-bindings",
+  "email": "82062616+prprabhu-ms@users.noreply.github.com",
+  "dependentChangeType": "patch"
+}
--- a/change/@internal-calling-stateful-client-372bdb70-d08f-47b6-9470-f6758af07ae0.json
+++ b/change/@internal-calling-stateful-client-372bdb70-d08f-47b6-9470-f6758af07ae0.json
@ -0,0 +1,7 @@
+{
+  "type": "prerelease",
+  "comment": "Bump acs-ui-common dep",
+  "packageName": "@internal/calling-stateful-client",
+  "email": "82062616+prprabhu-ms@users.noreply.github.com",
+  "dependentChangeType": "patch"
+}
--- a/change/@internal-chat-component-bindings-9fd32e69-984e-4e8c-bcdc-826f2f7d589a.json
+++ b/change/@internal-chat-component-bindings-9fd32e69-984e-4e8c-bcdc-826f2f7d589a.json
@ -0,0 +1,7 @@
+{
+  "type": "prerelease",
+  "comment": "Bump acs-ui-common dep",
+  "packageName": "@internal/chat-component-bindings",
+  "email": "82062616+prprabhu-ms@users.noreply.github.com",
+  "dependentChangeType": "patch"
+}
--- a/change/@internal-chat-stateful-client-ed3a7379-55a7-4f85-a961-d91d7379f2eb.json
+++ b/change/@internal-chat-stateful-client-ed3a7379-55a7-4f85-a961-d91d7379f2eb.json
@ -0,0 +1,7 @@
+{
+  "type": "prerelease",
+  "comment": "Bump acs-ui-common dep",
+  "packageName": "@internal/chat-stateful-client",
+  "email": "82062616+prprabhu-ms@users.noreply.github.com",
+  "dependentChangeType": "patch"
+}
--- a/change/@internal-react-components-0afeeb32-d8de-4672-b496-0b417ed874f8.json
+++ b/change/@internal-react-components-0afeeb32-d8de-4672-b496-0b417ed874f8.json
@ -0,0 +1,7 @@
+{
+  "type": "prerelease",
+  "comment": "Bump acs-ui-common dep",
+  "packageName": "@internal/react-components",
+  "email": "82062616+prprabhu-ms@users.noreply.github.com",
+  "dependentChangeType": "patch"
+}
--- a/change/@internal-react-composites-fdf9dee8-a721-4b49-b3d2-28378f1a9182.json
+++ b/change/@internal-react-composites-fdf9dee8-a721-4b49-b3d2-28378f1a9182.json
@ -0,0 +1,7 @@
+{
+  "type": "prerelease",
+  "comment": "Bump acs-ui-common dep",
+  "packageName": "@internal/react-composites",
+  "email": "82062616+prprabhu-ms@users.noreply.github.com",
+  "dependentChangeType": "patch"
+}
--- a/change/@internal-storybook-68f218e5-3e53-4dd8-8f71-93bc386772d1.json
+++ b/change/@internal-storybook-68f218e5-3e53-4dd8-8f71-93bc386772d1.json
@ -0,0 +1,7 @@
+{
+  "type": "prerelease",
+  "comment": "Mark package as public so it is versioned with other packlets",
+  "packageName": "@internal/storybook",
+  "email": "82062616+prprabhu-ms@users.noreply.github.com",
+  "dependentChangeType": "patch"
+}
--- a/common/config/beachball/changelog-config.ts
+++ b/common/config/beachball/changelog-config.ts
@ -10,5 +10,12 @@ export const config: BeachballConfig = {
      renderEntry
    }
  },
-  changehint: 'Run "rush changelog" to create required change files'
+  changehint: 'Run "rush changelog" to create required change files',
+  groups: [
+    {
+      name: "@azure/communication-react and its packlets",
+      include: "packages/",
+      disallowedChangeTypes: ['major']
+    }
+  ]
 };
--- a/common/config/rush/command-line.json
+++ b/common/config/rush/command-line.json
@ -23,6 +23,14 @@
      "shellCommand": "node common/config/node_modules/beachball/bin/beachball check",
      "safeForSimultaneousRushProcesses": true
    },
+    {
+      "commandKind": "global",
+      "name": "ensure-consistent-versions",
+      "summary": "Ensure that package versions for released artifacts are consistent",
+      "description": "Ensure that package versions for released artifacts are consistent.",
+      "shellCommand": "node common/scripts/ensure-consistent-versions.js",
+      "safeForSimultaneousRushProcesses": true
+    },
    {
      "commandKind": "bulk",
      "name": "test",
--- a/common/config/rush/pnpm-lock.yaml
+++ b/common/config/rush/pnpm-lock.yaml
@ -44,6 +44,7 @@ packages:
      '@opentelemetry/api': 0.10.2
      events: 3.3.0
      tslib: 2.3.1
+    deprecated: This version is deprecated. Please update to the latest @azure/communication-chat
    dev: false
    engines:
      node: '>=8.0.0'
@ -19072,7 +19073,7 @@ packages:
    dev: false
    name: '@rush-temp/calling-component-bindings'
    resolution:
-      integrity: sha512-WPXKzr7RYybkbu7ELuO0QLvVcqJr3hWW0I0PqQzWxXwyaLBePosNNZqv4btakTDlEH1mGSmwiGm7M2UmNP8NPg==
+      integrity: sha512-qcWoEmiEkhSPeR61y2Lj/g3g9KN219qO4JUck6TpUSeGnIKuYLXLxfKSfclc1ohK6kp7RdX8DtrDNO4+2wZiqw==
      tarball: file:projects/calling-component-bindings.tgz
    version: 0.0.0
  file:projects/calling-stateful-client.tgz:
@ -19102,7 +19103,7 @@ packages:
    dev: false
    name: '@rush-temp/calling-stateful-client'
    resolution:
-      integrity: sha512-iFe5LiwhHZXt9+jxqKHZuX6/w4AY9OokZNu3Z0hwwe+vrbbdm2Tvg9LnsjLqzGi9156iyuugI2K+i7Uw6WYCrg==
+      integrity: sha512-dpg41OL56Vd03+/AfCxa2NgA7TWRD+dFwXfmKMmJZZsHgYy3Z/Sfx/OCqjuHQtEjem8KzDG7PpS7nCfak6p1BA==
      tarball: file:projects/calling-stateful-client.tgz
    version: 0.0.0
  file:projects/calling.tgz:
@ -19169,7 +19170,7 @@ packages:
    dev: false
    name: '@rush-temp/calling'
    resolution:
-      integrity: sha512-RdkbHYGXyIt223kwxOdEupGzmFo40qmvRnzbCRarwRhkXnp5Dj6J3A0bWlWshCm36rAmykmHpA0lQlDtqpjxzA==
+      integrity: sha512-RNZVu/zfhoch3A5LzMXVlXqP+8oNliUmP30grqjlwnsukQM9KtoWiN0gSdQKJjrmFX+6Bq0MHhvqY3TFINZ6Mg==
      tarball: file:projects/calling.tgz
    version: 0.0.0
  file:projects/chat-component-bindings.tgz:
@ -19198,7 +19199,7 @@ packages:
    dev: false
    name: '@rush-temp/chat-component-bindings'
    resolution:
-      integrity: sha512-FBbNhojdZMyKlkC86BTq4FRwOLt5xU4V/stUlEHNWsirPj6hSpjZ9nfuCGtxZblon66LD1QFZKkH3UCg/SgaUw==
+      integrity: sha512-o05/2h8/i6BTjA/2Df9NaFVH2g4j7Y5ipy4H6/RKnDOc3aE+uHemqTt7q1U86Y2JIagAQ2DoAPAf1FN6H0UP4Q==
      tarball: file:projects/chat-component-bindings.tgz
    version: 0.0.0
  file:projects/chat-stateful-client.tgz:
@ -19230,7 +19231,7 @@ packages:
    dev: false
    name: '@rush-temp/chat-stateful-client'
    resolution:
-      integrity: sha512-1PMIQoOfIMfu4gaORJWp4RAK1RJDrRBgcUAPNi3Uw9RL34bn5H0AN4V7LxoQRPVjk6Kuw/4ZWqOWG3tYm8F7Ww==
+      integrity: sha512-iJRoNZxaTFIK2Yc4CPlLLOL3kxkqshv7SFK2/s5zNlaRhz7iYWbuUPCzbEDt03HuTn4tjZPCXkeFVWFF54XRdQ==
      tarball: file:projects/chat-stateful-client.tgz
    version: 0.0.0
  file:projects/chat.tgz:
@ -19290,7 +19291,7 @@ packages:
    dev: false
    name: '@rush-temp/chat'
    resolution:
-      integrity: sha512-SF4N39R8Ssl0lJShCNn+n1xy5dyUldEWjCDTShG7x0PZ6CvVs368kbZidiFgQaIwzcpa/fNPCCqs3296QWT7fA==
+      integrity: sha512-HKllEH1W7PHx/YznMD5O6+qGMfQHJ3lQHLL8jjczck0M0nDRrw1qIaY17jLg/S9FpMySiCQQ3e+piE8GzVrWVw==
      tarball: file:projects/chat.tgz
    version: 0.0.0
  file:projects/check-treeshaking.tgz:
@ -19306,7 +19307,7 @@ packages:
    dev: false
    name: '@rush-temp/check-treeshaking'
    resolution:
-      integrity: sha512-AspLSnBzEdZyyl6xSmdafrRRpIeazc4ymKhVFFe6/22NT1YscF6hSfbVh4e7lYTvGs+0aX5UdxoN1qcdENLzog==
+      integrity: sha512-zxKyBrPXu85w+bEGErm6YM+HmttWVxGzMjJuYq8XtYz5mdPK7b4Al8iS8A/8pWD9hXhxmpCOMWIWTd0K3/PupA==
      tarball: file:projects/check-treeshaking.tgz
    version: 0.0.0
  file:projects/communication-react.tgz:
@ -19470,7 +19471,7 @@ packages:
    dev: false
    name: '@rush-temp/react-components'
    resolution:
-      integrity: sha512-2YIsRjUN0HvOHMJhBf4kTAgUQh2ITx0u9ZoWZsWu9yIMmVndEMUPLOhXEbUCs0hINWsFbnCWGbkyN14vpMVQng==
+      integrity: sha512-CMpZPNNiEsdJrx6F7QJekaX59l30qGZl9HwiEln9X4fBWihsJK38eNrXi6rdx9rBbHlUg7XG8rj9QOvSV+ZGNQ==
      tarball: file:projects/react-components.tgz
    version: 0.0.0
  file:projects/react-composites.tgz:
@ -19559,7 +19560,7 @@ packages:
    dev: false
    name: '@rush-temp/react-composites'
    resolution:
-      integrity: sha512-Pi/oHpFWnK896t61uE7gUGyjY9fOrNJ8Ws74c9Lo8JfveJdn5amgbshqv3SiP0lRDQVy7DPgvOIi6HFnoIN8Vw==
+      integrity: sha512-bNdn98VpY6b6dtmYk1Uj0rqIclxHykgrfXhhUJ/gSbj+YzaFmonvftq0Msw6z1NwjPDPgj0GoO2CviC2qmMStw==
      tarball: file:projects/react-composites.tgz
    version: 0.0.0
  file:projects/sample-static-html-composites.tgz:
--- a/common/scripts/ensure-consistent-versions.js
+++ b/common/scripts/ensure-consistent-versions.js
@ -0,0 +1,55 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
+"use strict";
+
+const fs = require('fs');
+const path = require('path');
+
+const PACKAGES_DIR = path.join(__dirname, '..', '..', 'packages');
+
+function _findAllPackageJSON(root){
+    return fs.readdirSync(root).map(
+        (pkg) => {
+            const packageJSON = path.join(root, pkg, 'package.json');
+            const stat = fs.lstatSync(packageJSON);
+            if (!stat.isFile()) {
+                throw new Error(packageJSON + ' does not exist!');
+            }
+            return packageJSON;
+        }
+    )
+}
+
+function _readPackageVersion(packageJSON) {
+    const parsed = JSON.parse(fs.readFileSync(packageJSON));
+    const version = parsed['version'];
+    if (!version) {
+        throw new Error('Malformed version in ' + packageJSON);
+    }
+    return version;
+}
+
+function _areVersionsIdentical(versions) {
+    if (versions.length === 0) {
+        return true;
+    }
+    const goldenVersion = versions[0];
+    return versions.every((ver) => ver === goldenVersion);
+}
+
+function _main(){
+    const _packages = _findAllPackageJSON(PACKAGES_DIR);
+    const _versions = _packages.map((pkg) => _readPackageVersion(pkg));
+
+    if (!_areVersionsIdentical(_versions)) {
+        console.log('Discovered package versions:');
+        for (let i = 0; i < _packages.length; i++) {
+            console.log(_packages[i], ': ', _versions[i]);
+        }
+        throw new Error('Error: found mismatched versions!');
+    }
+    console.log('All good!')
+}
+
+_main()
--- a/packages/acs-ui-common/package.json
+++ b/packages/acs-ui-common/package.json
@ -1,6 +1,6 @@
 {
  "name": "@internal/acs-ui-common",
-  "version": "1.0.0-beta.3",
+  "version": "1.0.0-beta.4",
  "description": "Common types and utilities for all Azure Communication Serves UI libraries",
  "module": "dist/dist-esm/index.js",
  "main": "dist/dist-cjs/index.js",
--- a/packages/calling-component-bindings/package.json
+++ b/packages/calling-component-bindings/package.json
@ -23,7 +23,7 @@
  "dependencies": {
    "@azure/communication-common": "1.0.0",
    "@azure/communication-calling": "1.2.0-beta.1",
-    "@internal/acs-ui-common": "1.0.0-beta.3",
+    "@internal/acs-ui-common": "1.0.0-beta.4",
    "@internal/calling-stateful-client": "1.0.0-beta.4",
    "@internal/react-components": "1.0.0-beta.4",
    "reselect": "~4.0.0",
--- a/packages/calling-stateful-client/package.json
+++ b/packages/calling-stateful-client/package.json
@ -23,7 +23,7 @@
  "dependencies": {
    "@azure/communication-common": "1.0.0",
    "@azure/communication-calling": "1.2.0-beta.1",
-    "@internal/acs-ui-common": "1.0.0-beta.3",
+    "@internal/acs-ui-common": "1.0.0-beta.4",
    "events": "~3.3.0",
    "immer": "~8.0.1"
  },
--- a/packages/chat-component-bindings/package.json
+++ b/packages/chat-component-bindings/package.json
@ -25,7 +25,7 @@
    "@azure/communication-common": "1.0.0",
    "@azure/communication-signaling": "1.0.0-beta.5",
    "@azure/core-paging": "~1.1.3",
-    "@internal/acs-ui-common": "1.0.0-beta.3",
+    "@internal/acs-ui-common": "1.0.0-beta.4",
    "@internal/chat-stateful-client": "1.0.0-beta.4",
    "@internal/react-components": "1.0.0-beta.4",
    "reselect": "~4.0.0",
--- a/packages/chat-stateful-client/package.json
+++ b/packages/chat-stateful-client/package.json
@ -24,7 +24,7 @@
    "@azure/communication-chat": "1.0.0",
    "@azure/communication-signaling": "1.0.0-beta.5",
    "@azure/core-paging": "~1.1.3",
-    "@internal/acs-ui-common": "1.0.0-beta.3",
+    "@internal/acs-ui-common": "1.0.0-beta.4",
    "events": "~3.3.0",
    "immer": "~8.0.1",
    "nanoid": "~3.1.20",
--- a/packages/react-components/package.json
+++ b/packages/react-components/package.json
@ -30,7 +30,7 @@
    "@fluentui/react-northstar": "^0.51.2",
    "@uifabric/react-hooks": "~7.13.11",
    "copy-to-clipboard": "~3.3.1",
-    "@internal/acs-ui-common": "1.0.0-beta.3",
+    "@internal/acs-ui-common": "1.0.0-beta.4",
    "react-aria-live": "^2.0.5",
    "react-linkify": "^1.0.0-alpha",
    "html-to-react": "~1.4.5"
--- a/packages/react-composites/package.json
+++ b/packages/react-composites/package.json
@ -39,7 +39,7 @@
    "@azure/core-paging": "~1.1.3",
    "@fluentui/react": "~8.17.2",
    "@fluentui/react-icons": "~1.1.137",
-    "@internal/acs-ui-common": "1.0.0-beta.3",
+    "@internal/acs-ui-common": "1.0.0-beta.4",
    "@internal/calling-stateful-client": "1.0.0-beta.4",
    "@internal/calling-component-bindings": "1.0.0-beta.4",
    "@internal/chat-stateful-client": "1.0.0-beta.4",
--- a/packages/storybook/package.json
+++ b/packages/storybook/package.json
@ -1,7 +1,6 @@
 {
  "name": "@internal/storybook",
-  "private": true,
-  "version": "0.1.0",
+  "version": "1.0.0-beta.4",
  "description": "Azure Communication Services UI Library Storybook",
  "scripts": {
    "build": "build-storybook -s stories,public,.storybook  --quiet --loglevel warn",
--- a/samples/Calling/package.json
+++ b/samples/Calling/package.json
@ -25,7 +25,7 @@
    "@babel/preset-react": "^7.12.7",
    "@fluentui/react": "~8.17.2",
    "@fluentui/react-icons": "~1.1.137",
-    "@internal/acs-ui-common": "1.0.0-beta.3",
+    "@internal/acs-ui-common": "1.0.0-beta.4",
    "@internal/calling-component-bindings": "1.0.0-beta.4",
    "@internal/calling-stateful-client": "1.0.0-beta.4",
    "@internal/react-components": "1.0.0-beta.4",
--- a/samples/Chat/package.json
+++ b/samples/Chat/package.json
@ -24,7 +24,7 @@
    "@azure/core-http": "1.2.4",
    "@fluentui/react": "~8.17.2",
    "@fluentui/react-icons": "~1.1.137",
-    "@internal/acs-ui-common": "1.0.0-beta.3",
+    "@internal/acs-ui-common": "1.0.0-beta.4",
    "@internal/chat-stateful-client": "1.0.0-beta.4",
    "@internal/chat-component-bindings": "1.0.0-beta.4",
    "@internal/react-components": "1.0.0-beta.4",
--- a/tools/check-treeshaking/package.json
+++ b/tools/check-treeshaking/package.json
@ -15,7 +15,7 @@
    "lint:quiet": "npm run lint -- --quiet"
  },
  "dependencies": {
-    "@internal/acs-ui-common": "1.0.0-beta.3",
+    "@internal/acs-ui-common": "1.0.0-beta.4",
    "@internal/react-components": "1.0.0-beta.4",
    "@internal/chat-stateful-client": "1.0.0-beta.4",
    "@internal/calling-stateful-client": "1.0.0-beta.4",